Pull request: u-boot-dfu

U-Boot Lukasz Majewski 3 participants 6 messages May 6, 2014 – May 8, 2014

lore

Share & tools

lore

Lukasz Majewski

author

2014-05-06 09:29 UTC #0 lore raw

Hi Marek,

The following changes since commit
af41d6b4cb1602abebaaa9c8774a9b0ece564796:

common: fixed linker-list example (2014-05-05 10:24:13 +0200)

are available in the git repository at:

ssh://gu-dfu at git.denx.de/u-boot-dfu master

for you to fetch changes up to c805776ce7079c7b7dd54c644b499e1b8f6296b1:

ums: allow the user to specify the device type (2014-05-06 11:13:23 +0200)

----------------------------------------------------------------
Stephen Warren (9):
usb: ums: add error handling for failed registration
ums: support block devices not MMC devices
ums: remove UMS_{NUM,START}_SECTORS + UMS_START_SECTOR
ums: remove error-checking of MMC device size
ums: remove ums_disk_init()
ums: move IO support code to common location
ums: use get_device() not find_mmc_device();
ums: move all variable declarations to the start of the block
ums: allow the user to specify the device type

 board/samsung/common/Makefile |    1 -
 board/samsung/common/ums.c    |   74
 --------------------------------------------------------------------------
 common/cmd_usb_mass_storage.c |   91
 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------
 include/usb_mass_storage.h    |   13 ++-----------

4 files changed, 81 insertions(+), 98 deletions(-)

delete mode 100644 board/samsung/common/ums.c

Signature · 5 lines

Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

Marek Vasut

2014-05-07 21:38 UTC #1 lore raw

Quoted 16 lines · Lukasz Majewski

Hi Marek,
The following changes since commit
af41d6b4cb1602abebaaa9c8774a9b0ece564796:
common: fixed linker-list example (2014-05-05 10:24:13 +0200)
are available in the git repository at:
ssh://gu-dfu at git.denx.de/u-boot-dfu master
for you to fetch changes up to c805776ce7079c7b7dd54c644b499e1b8f6296b1:
ums: allow the user to specify the device type (2014-05-06 11:13:23 +0200)

Quoted 11 lines

----------------------------------------------------------------
Stephen Warren (9):
usb: ums: add error handling for failed registration
ums: support block devices not MMC devices
ums: remove UMS_{NUM,START}_SECTORS + UMS_START_SECTOR
ums: remove error-checking of MMC device size
ums: remove ums_disk_init()
ums: move IO support code to common location
ums: use get_device() not find_mmc_device();
ums: move all variable declarations to the start of the block
ums: allow the user to specify the device type

This doesn't match what's in U-Boot-dfu.git/master [1] it seems. Or does it ... ?

[1] http://git.denx.de/?p=u-boot/u-boot-dfu.git;a=summary

Best regards,
Marek Vasut

Lukasz Majewski

author

2014-05-08 06:30 UTC #2 lore raw

Hi Marek,

Quoted 30 lines · Lukasz Majewski

Quoted 17 lines
Hi Marek,
The following changes since commit
af41d6b4cb1602abebaaa9c8774a9b0ece564796:
common: fixed linker-list example (2014-05-05 10:24:13 +0200)
are available in the git repository at:
ssh://gu-dfu at git.denx.de/u-boot-dfu master
for you to fetch changes up to
c805776ce7079c7b7dd54c644b499e1b8f6296b1:
ums: allow the user to specify the device type (2014-05-06
11:13:23 +0200)
Quoted 11 lines
----------------------------------------------------------------
Stephen Warren (9):
usb: ums: add error handling for failed registration
ums: support block devices not MMC devices
ums: remove UMS_{NUM,START}_SECTORS + UMS_START_SECTOR
ums: remove error-checking of MMC device size
ums: remove ums_disk_init()
ums: move IO support code to common location
ums: use get_device() not find_mmc_device();
ums: move all variable declarations to the start of the block
ums: allow the user to specify the device type

Quoted 2 lines

This doesn't match what's in U-Boot-dfu.git/master [1] it seems. Or does it ... ?

This PR seems outdated :-).

I've also added to u-boot-dfu work done Rob Herring in the meantime.

I will prepare new PR with those changes included. Thanks for pointing out.

Quoted 5 lines

[1] http://git.denx.de/?p=u-boot/u-boot-dfu.git;a=summary
Best regards,
Marek Vasut

Signature · 5 lines

Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

Heiko Schocher

2014-05-08 06:46 UTC #3 lore raw

Hello Lukasz,

Am 08.05.2014 08:30, schrieb Lukasz Majewski:

Quoted 35 lines

Hi Marek,
Quoted 30 lines · Lukasz Majewski
Quoted 17 lines
Hi Marek,
The following changes since commit
af41d6b4cb1602abebaaa9c8774a9b0ece564796:
   common: fixed linker-list example (2014-05-05 10:24:13 +0200)
are available in the git repository at:
ssh://gu-dfu at git.denx.de/u-boot-dfu master
for you to fetch changes up to
c805776ce7079c7b7dd54c644b499e1b8f6296b1:
ums: allow the user to specify the device type (2014-05-06
11:13:23 +0200)
Quoted 11 lines
----------------------------------------------------------------
Stephen Warren (9):
usb: ums: add error handling for failed registration
ums: support block devices not MMC devices
ums: remove UMS_{NUM,START}_SECTORS + UMS_START_SECTOR
ums: remove error-checking of MMC device size
ums: remove ums_disk_init()
ums: move IO support code to common location
ums: use get_device() not find_mmc_device();
ums: move all variable declarations to the start of the block
ums: allow the user to specify the device type
Quoted 2 lines
This doesn't match what's in U-Boot-dfu.git/master [1] it seems. Or does it ... ?

Quoted 6 lines

This PR seems outdated :-).
I've also added to u-boot-dfu work done Rob Herring in the meantime.
I will prepare new PR with those changes included. Thanks for pointing out.

Hmm, I have 2 patches pending ...

[U-Boot,1/2] musb-new, dfu: first send request answer then call completions
http://patchwork.ozlabs.org/patch/337982/

and

[U-Boot,v2] dfu, nand: add medium specific polltimeout function
http://patchwork.ozlabs.org/patch/338369/

Could you (or Marek) add them? Or are there some issues with them?

Thanks!

bye,
Heiko

Signature · 2 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Lukasz Majewski

author

2014-05-08 07:08 UTC #4 lore raw

Hi Heiko,

Quoted 50 lines

Hello Lukasz,
Am 08.05.2014 08:30, schrieb Lukasz Majewski:
Quoted 35 lines
Hi Marek,
Quoted 30 lines · Lukasz Majewski
Quoted 17 lines
Hi Marek,
The following changes since commit
af41d6b4cb1602abebaaa9c8774a9b0ece564796:
   common: fixed linker-list example (2014-05-05 10:24:13 +0200)
are available in the git repository at:
ssh://gu-dfu at git.denx.de/u-boot-dfu master
for you to fetch changes up to
c805776ce7079c7b7dd54c644b499e1b8f6296b1:
ums: allow the user to specify the device type (2014-05-06
11:13:23 +0200)
Quoted 11 lines
----------------------------------------------------------------
Stephen Warren (9):
usb: ums: add error handling for failed registration
ums: support block devices not MMC devices
ums: remove UMS_{NUM,START}_SECTORS + UMS_START_SECTOR
ums: remove error-checking of MMC device size
ums: remove ums_disk_init()
ums: move IO support code to common location
ums: use get_device() not find_mmc_device();
ums: move all variable declarations to the start of the
block ums: allow the user to specify the device type
Quoted 2 lines
This doesn't match what's in U-Boot-dfu.git/master [1] it seems. Or does it ... ?
Quoted 6 lines
This PR seems outdated :-).
I've also added to u-boot-dfu work done Rob Herring in the meantime.
I will prepare new PR with those changes included. Thanks for pointing out.
Hmm, I have 2 patches pending ...
[U-Boot,1/2] musb-new, dfu: first send request answer then call completions http://patchwork.ozlabs.org/patch/337982/

Quoted 6 lines

and
[U-Boot,v2] dfu, nand: add medium specific polltimeout function
http://patchwork.ozlabs.org/patch/338369/
Could you (or Marek) add them? Or are there some issues with them?

I will test them and if no regressions appear I will add them to u-boot-dfu tree.

Quoted 5 lines

Thanks!
bye,
Heiko

Signature · 5 lines

Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

Marek Vasut

2014-05-08 10:12 UTC #5 lore raw

Quoted 56 lines · Lukasz Majewski

Hi Heiko,
Quoted 54 lines
Hello Lukasz,
Am 08.05.2014 08:30, schrieb Lukasz Majewski:
Quoted 37 lines
Hi Marek,
Quoted 30 lines · Lukasz Majewski
Quoted 29 lines
Hi Marek,
The following changes since commit
af41d6b4cb1602abebaaa9c8774a9b0ece564796:
   common: fixed linker-list example (2014-05-05 10:24:13 +0200)
are available in the git repository at:
ssh://gu-dfu at git.denx.de/u-boot-dfu master
for you to fetch changes up to
c805776ce7079c7b7dd54c644b499e1b8f6296b1:
ums: allow the user to specify the device type (2014-05-06
11:13:23 +0200)
----------------------------------------------------------------
Stephen Warren (9):
usb: ums: add error handling for failed registration
ums: support block devices not MMC devices
ums: remove UMS_{NUM,START}_SECTORS + UMS_START_SECTOR
ums: remove error-checking of MMC device size
ums: remove ums_disk_init()
ums: move IO support code to common location
ums: use get_device() not find_mmc_device();
ums: move all variable declarations to the start of the
Quoted 4 lines
Quoted 1 line
block ums: allow the user to specify the device type
This doesn't match what's in U-Boot-dfu.git/master [1] it seems. Or does it ... ?
Quoted 6 lines
This PR seems outdated :-).
I've also added to u-boot-dfu work done Rob Herring in the meantime.
I will prepare new PR with those changes included. Thanks for pointing out.
Hmm, I have 2 patches pending ...
[U-Boot,1/2] musb-new, dfu: first send request answer then call completions http://patchwork.ozlabs.org/patch/337982/
and

Quoted 7 lines

Quoted 4 lines
[U-Boot,v2] dfu, nand: add medium specific polltimeout function
http://patchwork.ozlabs.org/patch/338369/
Could you (or Marek) add them? Or are there some issues with them?
I will test them and if no regressions appear I will add them to u-boot-dfu tree.

Thanks.

Best regards,
Marek Vasut