Skip to contentSkip to conversation

ARM: dts: i.MX53: Fix ipu register space size

PATCH New Sascha Hauer 4 participants 7 messages May 6, 2014 – May 11, 2014

Subsystems (2)
lore
Share & tools
lore

Sascha Hauer

author maintainer
#0 lore raw

PATCH 1/1 ARM: dts: i.MX53: Fix ipu register space size

The IPU register space is 128MB, not 2GB.

---
 arch/arm/boot/dts/imx53.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx53.dtsi +1 -1
index 9c2bff2..6a1bf4f 100644
@@ -115,7 +115,7 @@
 			#address-cells = <1>;
 			#size-cells = <0>;
 			compatible = "fsl,imx53-ipu";
-			reg = <0x18000000 0x080000000>;
+			reg = <0x18000000 0x08000000>;
 			interrupts = <11 10>;
 			clocks = <&clks IMX5_CLK_IPU_GATE>,
 			         <&clks IMX5_CLK_IPU_DI0_GATE>,
Signature · 1 line
2.0.0.rc0
#1 lore raw

PATCH 1/1 ARM: dts: i.MX53: Fix ipu register space size

Hi,

Quoted 12 lines · Sascha Hauer

The IPU register space is 128MB, not 2GB.

---
 arch/arm/boot/dts/imx53.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx53.dtsi +0 -0
index 9c2bff2..6a1bf4f 100644

arch/arm/boot/dts/imx53.dtsi line 119

Quoted 6 lines
arch/arm/boot/dts/imx53.dtsi +1 -1
@@ -115,7 +115,7 @@
 			#address-cells = <1>;
 			#size-cells = <0>;
 			compatible = "fsl,imx53-ipu";
-			reg = <0x18000000 0x080000000>;
+			reg = <0x18000000 0x08000000>;
 

IMO this should be either 0x00800000 or 0x800000
while I prefer the first notation.

Lothar Wa?mann

Signature · 9 lines
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________
author maintainer
#2 lore raw

PATCH 1/1 ARM: dts: i.MX53: Fix ipu register space size

Quoted 10 lines · Lothar Wa?mann

Hi,

Quoted 7 lines · Sascha Hauer

The IPU register space is 128MB, not 2GB.

---
 arch/arm/boot/dts/imx53.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines

arch/arm/boot/dts/imx53.dtsi line 119

Quoted 11 lines
arch/arm/boot/dts/imx53.dtsi +1 -1
index 9c2bff2..6a1bf4f 100644
@@ -115,7 +115,7 @@
 			#address-cells = <1>;
 			#size-cells = <0>;
 			compatible = "fsl,imx53-ipu";
-			reg = <0x18000000 0x080000000>;
+			reg = <0x18000000 0x08000000>;
 

IMO this should be either 0x00800000 or 0x800000
while I prefer the first notation.

Look again, the original size is 9 digits wide: 0x0_8000_0000. I changed this to 0x_08000_0000 which is 8 digits wide.

Sascha

Signature · 4 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
author maintainer
#3 lore raw

PATCH 1/1 ARM: dts: i.MX53: Fix ipu register space size

Quoted 25 lines · Sascha Hauer
Quoted 10 lines · Lothar Wa?mann

Hi,

Quoted 7 lines · Sascha Hauer

The IPU register space is 128MB, not 2GB.

---
 arch/arm/boot/dts/imx53.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines

arch/arm/boot/dts/imx53.dtsi line 119

Quoted 11 lines
arch/arm/boot/dts/imx53.dtsi +1 -1
index 9c2bff2..6a1bf4f 100644
@@ -115,7 +115,7 @@
 			#address-cells = <1>;
 			#size-cells = <0>;
 			compatible = "fsl,imx53-ipu";
-			reg = <0x18000000 0x080000000>;
+			reg = <0x18000000 0x08000000>;
 

IMO this should be either 0x00800000 or 0x800000
while I prefer the first notation.

Quoted 2 lines

Look again, the original size is 9 digits wide: 0x0_8000_0000. I changed this to 0x_08000_0000 which is 8 digits wide.

Argh. I meant 0x_0800_0000

Sascha

Signature · 4 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#4 lore raw

PATCH 1/1 ARM: dts: i.MX53: Fix ipu register space size

In reply to Sascha Hauer
Quoted 3 lines · Sascha Hauer

The IPU register space is 128MB, not 2GB.

Arnd, Olof,

Please apply this fix for 3.15, and copy stable. Thanks.

Shawn

Quoted 20 lines
---
 arch/arm/boot/dts/imx53.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx53.dtsi +1 -1
index 9c2bff2..6a1bf4f 100644
@@ -115,7 +115,7 @@
 			#address-cells = <1>;
 			#size-cells = <0>;
 			compatible = "fsl,imx53-ipu";
-			reg = <0x18000000 0x080000000>;
+			reg = <0x18000000 0x08000000>;
 			interrupts = <11 10>;
 			clocks = <&clks IMX5_CLK_IPU_GATE>,
 			         <&clks IMX5_CLK_IPU_DI0_GATE>,
Signature · 1 line
2.0.0.rc0
#5 lore raw

PATCH 1/1 ARM: dts: i.MX53: Fix ipu register space size

Quoted 5 lines · Shawn Guo
Quoted 3 lines · Sascha Hauer

The IPU register space is 128MB, not 2GB.

Quoted 8 lines

Arnd, Olof,

Please apply this fix for 3.15, and copy stable. Thanks.

Applied, but in the future please resend the whole patch since we just get this acked-by email in the arm at kernel.org mailboxes and have to hunt around for the original patch.

Btw for the future, this is the case where a Fixes: <12-digit sha> '<patch subject>' would be useful, so that stable knows how far to backport. I added it this time as well, feel free to do it yourself next time :)

-Olof

#6 lore raw

PATCH 1/1 ARM: dts: i.MX53: Fix ipu register space size

Quoted 15 lines · Olof Johansson
Quoted 5 lines · Shawn Guo
Quoted 3 lines · Sascha Hauer

The IPU register space is 128MB, not 2GB.

Quoted 8 lines

Arnd, Olof,

Please apply this fix for 3.15, and copy stable. Thanks.

Quoted 7 lines

Applied, but in the future please resend the whole patch since we just get this acked-by email in the arm at kernel.org mailboxes and have to hunt around for the original patch.

Btw for the future, this is the case where a Fixes: <12-digit sha> '<patch subject>' would be useful, so that stable knows how far to backport. I added it this time as well, feel free to do it yourself next time :)

Noted. Thanks, Olof.

Shawn