ARM: DRA7: Add support for DRA72x devices

DRA722 is part of DRA72x family which are single core cortex A15 devices with most infrastructure IPs otherwise same as whats on the DRA74x family.

So move the cpu nodes into dra74x.dtsi and dra72x.dtsi respectively.

Also add a minimal dra72-evm dts file.

Signed-off-by Rajendra Nayak <[email protected]>

Cc linux-doc at vger.kernel.org

Cc devicetree at vger.kernel.org

The only difference from the dra74x devices is the missing .smp entry.

Signed-off-by Rajendra Nayak <[email protected]>

---
 arch/arm/mach-omap2/board-generic.c |   25 +++++++++++++++++++++----
 1 file changed, 21 insertions(+), 4 deletions(-)

arch/arm/mach-omap2/soc.h IS_OMAP_TYPE(3430, 0x3430) · line 403

Quoted 10 lines · On Tuesday 29 April 2014 16:35:13 Rajendra Nayak wrote:

arch/arm/mach-omap2/soc.h +5 -0

@@ -393,7 +395,12 @@ IS_OMAP_TYPE(3430, 0x3430)
 
 #if defined(CONFIG_SOC_DRA7XX)
 #undef soc_is_dra7xx
+#undef soc_is_dra74x
+#undef soc_is_dra72x
 #define soc_is_dra7xx()        (of_machine_is_compatible("ti,dra7"))
+#define soc_is_dra74x()        (of_machine_is_compatible("ti,dra74"))
+#define soc_is_dra72x()        (of_machine_is_compatible("ti,dra72"))
+

You shouldn't normally have to define these. Why are they needed?

Maybe it's better to wait for a user to show up, and then we can decide whether we actually want to have them this way, or if there is a better solution for the particular use case.

Normally, we'd want to make run-time decisions based on properties of the nodes a driver is working on, not the global machine compatible string.

Arnd

Quoted 18 lines · Arnd Bergmann

arch/arm/mach-omap2/soc.h IS_OMAP_TYPE(3430, 0x3430) · line 403

Quoted 10 lines · On Tuesday 29 April 2014 16:35:13 Rajendra Nayak wrote:

arch/arm/mach-omap2/soc.h +5 -0

@@ -393,7 +395,12 @@ IS_OMAP_TYPE(3430, 0x3430)
 
 #if defined(CONFIG_SOC_DRA7XX)
 #undef soc_is_dra7xx
+#undef soc_is_dra74x
+#undef soc_is_dra72x
 #define soc_is_dra7xx()        (of_machine_is_compatible("ti,dra7"))
+#define soc_is_dra74x()        (of_machine_is_compatible("ti,dra74"))
+#define soc_is_dra72x()        (of_machine_is_compatible("ti,dra72"))
+

You shouldn't normally have to define these. Why are they needed?

Maybe it's better to wait for a user to show up, and then we can decide whether we actually want to have them this way, or if there is a better solution for the particular use case.

Quoted 3 lines

Normally, we'd want to make run-time decisions based on properties of the nodes a driver is working on, not the global machine compatible string.

Yeah, actually this can be dropped. There is no user for it now.

Quoted 19 lines · Rajendra Nayak

Quoted 18 lines · Arnd Bergmann

arch/arm/mach-omap2/soc.h IS_OMAP_TYPE(3430, 0x3430) · line 403

Quoted 10 lines · On Tuesday 29 April 2014 16:35:13 Rajendra Nayak wrote:

arch/arm/mach-omap2/soc.h +5 -0

@@ -393,7 +395,12 @@ IS_OMAP_TYPE(3430, 0x3430)
 
 #if defined(CONFIG_SOC_DRA7XX)
 #undef soc_is_dra7xx
+#undef soc_is_dra74x
+#undef soc_is_dra72x
 #define soc_is_dra7xx()        (of_machine_is_compatible("ti,dra7"))
+#define soc_is_dra74x()        (of_machine_is_compatible("ti,dra74"))
+#define soc_is_dra72x()        (of_machine_is_compatible("ti,dra72"))
+

You shouldn't normally have to define these. Why are they needed?

Maybe it's better to wait for a user to show up, and then we can decide whether we actually want to have them this way, or if there is a better solution for the particular use case.

Quoted 5 lines

Quoted 3 lines

Normally, we'd want to make run-time decisions based on properties of the nodes a driver is working on, not the global machine compatible string.

Yeah, actually this can be dropped. There is no user for it now.

OK applying all but the last patch into omap-for-v3.16/dt branch, it seems there's no need to separate out the fixes in this case.

Regards,

Tony

changes in v4:
-1- used full SoC names in compatibles eg "ti,dra742" and "ti,dra722" -2- Created a seperate patch for replacing __initdata with __initconst

changes in v3:
Removed wildcards from compatible strings and duplicates from .dt_compat strings as suggested by Arnd

DRA72x devices are single core Cortex A15 devices belonging to the DRA7 family (Similar to the DRA74x devices which are dual core Cortex A15 based)

The patches (based off 3.15-rc3) add minimal DT/kernel modifications to add boot support on DRA722 device reusing all the kernel data for DRA742 device.

Rajendra Nayak (5):
ARM: dts: dra7-evm: Remove the wrong and undocumented compatible
ARM: dts: Add support for DRA72x family of devices
ARM: OMAP2+: Replace all __initdata with __initconst for const init
ARM: OMAP2+: Add machine entry for dra72x devices
ARM: DRA7: Add support for soc_is_dra74x() and soc_is_dra72x()
varients

 .../devicetree/bindings/arm/omap/omap.txt          |   12 ++++--
 arch/arm/boot/dts/Makefile                         |    3 +-
 arch/arm/boot/dts/dra7-evm.dts                     |    6 +--
 arch/arm/boot/dts/dra7.dtsi                        |   27 ------------
 arch/arm/boot/dts/dra72-evm.dts                    |   24 +++++++++++
 arch/arm/boot/dts/dra72x.dtsi                      |   25 +++++++++++
 arch/arm/boot/dts/dra74x.dtsi                      |   41 ++++++++++++++++++
 arch/arm/mach-omap2/board-generic.c                |   45 ++++++++++++++------
 arch/arm/mach-omap2/soc.h                          |    7 +++
 9 files changed, 142 insertions(+), 48 deletions(-)
 create mode 100644 arch/arm/boot/dts/dra72-evm.dts
 create mode 100644 arch/arm/boot/dts/dra72x.dtsi
 create mode 100644 arch/arm/boot/dts/dra74x.dtsi