Skip to contentSkip to conversation

staging: binder: fix usage of uninit scalar in binder_transaction()

PATCH New Christian Engelmayer 1 participant 1 message May 7, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: binder: fix usage of uninit scalar in binder_transaction()

Fix the error path when a cookie mismatch is detected. In that case the function jumps to the exit label without setting the uninitialized, local variable 'return_error'. Detected by Coverity - CID 201453.

---
v2: Resend after v1 failed to apply

* rebased against staging-next - commit 09c3fbba (staging: rtl8188eu:
Remove 'u8 *pbuf' from struct recv_buf)
* fixed mua: no multipart, 7bit text/plain us-ascii

Compile tested and applies against branch staging-next of tree git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git

---
 drivers/staging/android/binder.c | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/android/binder.c +1 -0
index 35c00ab..de8e2a3 100644
@@ -1546,6 +1546,7 @@ static void binder_transaction(struct binder_proc *proc,
 					proc->pid, thread->pid,
 					(u64)fp->binder, node->debug_id,
 					(u64)fp->cookie, (u64)node->cookie);
+				return_error = BR_FAILED_REPLY;
 				goto err_binder_get_ref_for_node_failed;
 			}
 			ref = binder_get_ref_for_node(target_proc, node);
Signature · 1 line
1.9.1