staging: comedi: ii_pci20kc: fix usage of uninit scalar in ii20k_attach()
PATCH v2 1/1 staging: comedi: ii_pci20kc: fix usage of uninit scalar in ii20k_attach()
This driver supports the PCI-20001C-1a and PCI-20001C-2a carrier boards. The -2a version has 32 on-board DIO channels. In case this variant is detected, local variable 'has_dio' is set accordingly. Otherwise it is left uninitialized and the following subdevice instantiation depends on the stack. Detected by Coverity - CID 1077830.
---
v2: Resend after v1 failed to apply
* rebased against staging-next - commit 09c3fbba (staging: rtl8188eu:
Remove 'u8 *pbuf' from struct recv_buf)
* fixed mua: no multipart, 7bit text/plain us-ascii
Compile tested and applies against branch staging-next of tree git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
--- drivers/staging/comedi/drivers/ii_pci20kc.c | 1 + 1 file changed, 1 insertion(+)
drivers/staging/comedi/drivers/ii_pci20kc.c +1 -0
@@ -461,6 +461,7 @@ static int ii20k_attach(struct comedi_device *dev, id =readb (devpriv->ioaddr +II20K_ID_REG );switch (id &II20K_ID_MASK ) {case II20K_ID_PCI20001C_1A : + has_dio = false;break ;case II20K_ID_PCI20001C_2A : has_dio = true;
Signature · 1 line
1.9.1
Quoted 14 lines · Christian Engelmayer
This driver supports the PCI-20001C-1a and PCI-20001C-2a carrier boards. The -2a version has 32 on-board DIO channels. In case this variant is detected, local variable '
has_dio' is set accordingly. Otherwise it is left uninitialized and the following subdevice instantiation depends on the stack. Detected by Coverity - CID 1077830.Signed-off-by Christian Engelmayer <[email protected]>---
v2: Resend after v1 failed to apply* rebased against staging-next - commit
09c3fbba(staging: rtl8188eu:
Remove 'u8 *pbuf' from structrecv_buf)
* fixed mua: no multipart, 7bit text/plain us-ascii
Quoted 5 lines
Compile tested and applies against branch staging-next of tree git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
--- drivers/staging/comedi/drivers/ii_pci20kc.c | 1 + 1 file changed, 1 insertion(+)
Thanks!
Signature · 2 lines
-=( Ian Abbott @ MEV Ltd. E-mail: <[email protected]> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-