Skip to contentSkip to conversation

ARM i.MX51: Add Efika MX Smartbook devicetree

PATCH New Alexander Shiyan 4 participants 8 messages Apr 16, 2014 – May 9, 2014

Subsystems (3)
Device tree bindings Arm i.MX and Layerscape Arm and arm64 SoC sub-architectures (common parts)
lore
Share & tools
lore

Alexander Shiyan

author
#0 lore raw

PATCH 1/1 ARM i.MX51: Add Efika MX Smartbook devicetree

This patch adds support for Efika MX Smartbook.

Signed-off-by Alexander Shiyan <[email protected]>
---
 arch/arm/boot/dts/Makefile                  |   1 +
 arch/arm/boot/dts/imx51-genesi-efika-sb.dts | 543 ++++++++++++++++++++++++++++
 2 files changed, 544 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx51-genesi-efika-sb.dts
arch/arm/boot/dts/Makefile +1 -0
index 470616f..e01d250 100644
@@ -167,6 +167,7 @@ dtb-$(CONFIG_ARCH_MXC) += \
 	imx51-babbage.dtb \
 	imx51-digi-connectcore-jsk.dtb \
 	imx51-eukrea-mbimxsd51-baseboard.dtb \
+	imx51-genesi-efika-sb.dtb \
 	imx53-ard.dtb \
 	imx53-m53evk.dtb \
 	imx53-mba53.dtb \
arch/arm/boot/dts/imx51-genesi-efika-sb.dts new file +543 -0

543 lines not on this page · raw message

Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 ARM i.MX51: Add Efika MX Smartbook devicetree

Quoted 1 line · Alexander Shiyan

This patch adds support for Efika MX Smartbook.

I'm curious, how did you test that ? From a very quick look, seems it has no chance to work with the uboot shipped with the devices.

What about the mtl017 ? do you have a driver ready to be submitted mainline ?

Arnaud

author
#2 lore raw

Wed, 16 Apr 2014 13:19:40 +0200 ?? Arnaud Patard (Rtp) <[email protected]>:

Quoted 6 lines
Quoted 1 line · Alexander Shiyan

This patch adds support for Efika MX Smartbook.

I'm curious, how did you test that ? From a very quick look, seems it has no chance to work with the uboot shipped with the devices.

Uboot it is not the only option for booting.
With any loader, this can be used with "appended DTB" option in the kernel.

This board support was be introduced by Sascha Hauer for the "barebox". So I think he was checking its workability.

---

#3 lore raw

PATCH 1/1 ARM i.MX51: Add Efika MX Smartbook devicetree

Quoted 5 lines · Alexander Shiyan

Wed, 16 Apr 2014 13:19:40 +0200 ?? Arnaud Patard (Rtp) <[email protected]>:

Quoted 4 lines
Quoted 1 line · Alexander Shiyan

This patch adds support for Efika MX Smartbook.

Quoted 8 lines
Quoted 2 lines

I'm curious, how did you test that ? From a very quick look, seems it has no chance to work with the uboot shipped with the devices.

Uboot it is not the only option for booting.
With any loader, this can be used with "appended DTB" option in the kernel.

This board support was be introduced by Sascha Hauer for the "barebox". So I think he was checking its workability.

As I said, I'm talking of the uboot shipped with the devices. I do know that barebox is doing things differently than this uboot. For instance, with this DTB and barebox, usb should(?) work but for sure, it won't work with this uboot.
If we merge something, it should work with all bootloaders otherwise it would mean that the dtb is bootloader specific...

Arnaud

author
#4 lore raw

Wed, 16 Apr 2014 14:23:23 +0200 ?? Arnaud Patard (Rtp) <[email protected]>:

Quoted 16 lines
Quoted 5 lines · Alexander Shiyan

Wed, 16 Apr 2014 13:19:40 +0200 ?? Arnaud Patard (Rtp) <[email protected]>:

Quoted 4 lines
Quoted 1 line · Alexander Shiyan

This patch adds support for Efika MX Smartbook.

Quoted 8 lines
Quoted 2 lines

I'm curious, how did you test that ? From a very quick look, seems it has no chance to work with the uboot shipped with the devices.

Uboot it is not the only option for booting.
With any loader, this can be used with "appended DTB" option in the kernel.

This board support was be introduced by Sascha Hauer for the "barebox". So I think he was checking its workability.

Quoted 6 lines

As I said, I'm talking of the uboot shipped with the devices. I do know that barebox is doing things differently than this uboot. For instance, with this DTB and barebox, usb should(?) work but for sure, it won't work with this uboot.
If we merge something, it should work with all bootloaders otherwise it would mean that the dtb is bootloader specific...

Why do you think that the USB will not work with this DTB and uboot? What makes you think so? Something incorrect in the DT representation?

---

maintainer
#5 lore raw

PATCH 1/1 ARM i.MX51: Add Efika MX Smartbook devicetree

In reply to Alexander Shiyan

arch/arm/boot/dts/imx51-genesi-efika-sb.dts line 21

Quoted 8 lines · Alexander Shiyan

This patch adds support for Efika MX Smartbook.

arch/arm/boot/dts/imx51-genesi-efika-sb.dts new file +6 -0
+/ {
+	model = "Genesi Efika MX Smartbook";
+	compatible = "genesi,imx51-sb", "fsl,imx51";
+
+	chosen {
+		linux,stdout-path = &uart1;

As a newly introduced board this should use the standard 'stdout-path' property rather than the Linux specific 'linux,stdout-path' property.

Quoted 5 lines
arch/arm/boot/dts/imx51-genesi-efika-sb.dts new file +5 -0
+	};
+
+	memory {
+		reg = <0x90000000 0x20000000>;
+	};

arch/arm/boot/dts/imx51-genesi-efika-sb.dts line 36

Quoted 10 lines
arch/arm/boot/dts/imx51-genesi-efika-sb.dts new file +10 -0
+
+	backlight {
+		compatible = "pwm-backlight";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_backlight>;
+		pwms = <&pwm1 0 78770>;
+		brightness-levels = <0 4 8 16 32 64 128 255>;
+		enable-gpios = <&gpio4 12 GPIO_ACTIVE_HIGH>;
+		default-brightness-level = <6>;
+        };

Whitespace damage here.

Quoted 22 lines

+&usbh1 {

arch/arm/boot/dts/imx51-genesi-efika-sb.dts new file +20 -0
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_usbh1>;
+	phy_type = "ulpi";
+	status = "okay";
+};
+
+&usbh2 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_usbh2>;
+	phy_type = "ulpi";
+	vbus-supply = <&reg_usbh2_vbus>;
+	status = "okay";
+};
+
+&usbotg {
+	dr_mode = "host";
+	phy_type = "ulpi";
+	vbus-supply = <&reg_usbotg_vbus>;
+	status = "okay";
+};
Quoted 1 line

From what I can see ulpi mode is not supported currently in the chipidea

driver. I think that shouldn't block adding these device nodes, but maybe a comment could clarify this so we get patches instead of bug reports for USB?

Sascha

Signature · 4 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
reviewer
#6 lore raw

PATCH 1/1 ARM i.MX51: Add Efika MX Smartbook devicetree

Quoted 2 lines · Sascha Hauer

From what I can see ulpi mode is not supported currently in the chipidea driver. I think that shouldn't block adding these device nodes, but

It works with usb nop transceiver. We got it running on mx27pdk, mx51evk and other boards.

maintainer
#7 lore raw

PATCH 1/1 ARM i.MX51: Add Efika MX Smartbook devicetree

Quoted 7 lines · Fabio Estevam
Quoted 2 lines · Sascha Hauer

From what I can see ulpi mode is not supported currently in the chipidea driver. I think that shouldn't block adding these device nodes, but

It works with usb nop transceiver. We got it running on mx27pdk, mx51evk and other boards.

The ULPI phys need to be configured. I don't think that it works on the Efika without additional code. But now that the chipidea patches are flowing into the kernel again I may find some motivation to have a look into this issue.

Sascha

Signature · 4 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |