Skip to contentSkip to conversation

Documentation/email-clients.txt: add a section about git

PATCH Superseded Dan Carpenter 6 participants 10 messages May 7, 2014 – May 11, 2014 Documentation

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Documentation/email-clients.txt: add a section about git

These days most people don't use git to send patches so I have added a section about that.

Documentation/email-clients.txt +11 -0
index 4e30eba..9004a5fd 100644
@@ -1,6 +1,17 @@
 Email clients info for Linux
 ======================================================================
 
+Git
+----------------------------------------------------------------------
+These days most developers use `git send-email` instead of regular
+email clients.  On the receiving end, maintainers use `git am` to
+apply the patches.
+
+If you are new to git then send your first patch to yourself.  Save it
+as raw text including all the headers.  Run `cat raw_email.txt | git am`
+and then review the changelog with `git log -p`.  When that works then
+send the patch to list.
+
 General Preferences
 ----------------------------------------------------------------------
 Patches for the Linux kernel are submitted via email, preferably as
#1 lore raw
Quoted 3 lines · Dan Carpenter

These days most people don't use git to send patches so I have added a section about that.

Do you mean most people *do* use git to send patches? Or most people don't use e-mail clients?

Laura

Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
#2 lore raw
Quoted 7 lines · Laura Abbott
Quoted 3 lines · Dan Carpenter

These days most people don't use git to send patches so I have added a section about that.

Do you mean most people *do* use git to send patches? Or most people don't use e-mail clients?

Gar... Of course. I'll resend.

regards,
dan carpenter

#3 lore raw

PATCH v2 1/1 Documentation/email-clients.txt: add a section about git

In reply to Laura Abbott

These days most people use git to send patches so I have added a section about that.

---
v2: Fixed changelog

Documentation/email-clients.txt +11 -0
index 4e30eba..9004a5fd 100644
@@ -1,6 +1,17 @@
 Email clients info for Linux
 ======================================================================
 
+Git
+----------------------------------------------------------------------
+These days most developers use `git send-email` instead of regular
+email clients.  On the receiving end, maintainers use `git am` to
+apply the patches.
+
+If you are new to git then send your first patch to yourself.  Save it
+as raw text including all the headers.  Run `cat raw_email.txt | git am`
+and then review the changelog with `git log -p`.  When that works then
+send the patch to list.
+
 General Preferences
 ----------------------------------------------------------------------
 Patches for the Linux kernel are submitted via email, preferably as

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

#4 lore raw
Quoted 1 line · Dan Carpenter

+as raw text including all the headers. Run cat raw_email.txt | git am

cat raw_email.txt | git am seems a bit pointless. Why not simply git am raw_email.txt? git am < raw_email.txt does the same too and avoids the useless cat as well.

No point in running two processes when the same can be done in a simpler way in one process, IMO.

Signature · 5 lines
Julian Andres Klode  - Debian Developer, Ubuntu Member

See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/.

Please do not top-post if possible.
#5 lore raw
Quoted 10 lines · Julian Andres Klode
Quoted 1 line · Dan Carpenter

+as raw text including all the headers. Run cat raw_email.txt | git am

cat raw_email.txt | git am seems a bit pointless. Why not simply git am raw_email.txt? git am < raw_email.txt does the same too and avoids the useless cat as well.

No point in running two processes when the same can be done in a simpler way in one process, IMO.

And this helps most developers little, but is more valuable for those who dont use 'git send-mail' everyday if the detail of cmdline is provided, say send a patch file with 'git send-mail' through gmail.

We will say double thanks to you, Dan, if you really help us tame gmail.

And a howto to tame gmail is doule apprecaited.

thanks
Hillf

#6 lore raw
Quoted 1 line · Hillf Danton

And a howto to tame gmail is doule apprecaited.

There is actually a gmail section in the man page. man git send-email It's a the bottom.

EXAMPLE
Use gmail as the smtp server
To use git send-email to send your patches through the GMail SMTP server, edit ~/.gitconfig to specify your account settings:

[sendemail]
smtpencryption = tls
smtpserver = smtp.gmail.com
smtpuser = [email protected]
smtpserverport = 587

Once your commits are ready to be sent to the mailing list, run the following commands:

$ git format-patch --cover-letter -M origin/master -o outgoing/ $ edit outgoing/0000-*
$ git send-email outgoing/*

Note: the following perl modules are required Net::SMTP::SSL, MIME::Base64 and Authen::SASL

regards,
dan carpenter

#7 lore raw
In reply to Dan Carpenter

Hi Dan,

Quoted 14 lines · Dan Carpenter

These days most people use git to send patches so I have added a section about that.

---
v2: Fixed changelog

Documentation/email-clients.txt +0 -0
index 4e30eba..9004a5fd 100644
@@ -1,6 +1,17 @@
 Email clients info for Linux
 ======================================================================

Documentation/email-clients.txt line 12

Quoted 10 lines
Documentation/email-clients.txt +9 -0
 
+Git
+----------------------------------------------------------------------
+These days most developers use `git send-email` instead of regular
+email clients.  On the receiving end, maintainers use `git am` to
+apply the patches.
+
+If you are new to git then send your first patch to yourself.  Save it
+as raw text including all the headers.  Run `cat raw_email.txt | git am`
+and then review the changelog with `git log -p`.  When that works then

Also the -p option is not needed for just checking the changelog IMHO. If one needs to check the patch itself too, I think git show is slightly better since it only shows the single commit applied.

Thanks,
Namhyung

#8 lore raw
Quoted 5 lines · Namhyung Kim
Quoted 5 lines
Documentation/email-clients.txt +5 -0
+Git
+----------------------------------------------------------------------
+These days most developers use `git send-email` instead of regular
+email clients.  On the receiving end, maintainers use `git am` to
+apply the patches.
Quoted 9 lines

Documentation/email-clients.txt line 12

Quoted 4 lines
Documentation/email-clients.txt +4 -0
+
+If you are new to git then send your first patch to yourself.  Save it
+as raw text including all the headers.  Run `cat raw_email.txt | git am`
+and then review the changelog with `git log -p`.  When that works then

Also the -p option is not needed for just checking the changelog IMHO. If one needs to check the patch itself too, I think git show is slightly better since it only shows the single commit applied.

I know you can leave the -p off but I wanted it on and I wanted the log so they could see their patch and how the format compared to other commits.

You guys are over thinking this. It's not commands for all ages. If you type cat patch.txt | git am or if you type git am < patch.txt, those are things I don't care about.

regards,
dan carpenter

reviewer
#9 lore raw
In reply to Dan Carpenter
Quoted 12 lines · Dan Carpenter

These days most people use git to send patches so I have added a section about that.

---
v2: Fixed changelog

Documentation/email-clients.txt +0 -0
index 4e30eba..9004a5fd 100644

Documentation/email-clients.txt line 9

Quoted 9 lines
Documentation/email-clients.txt +6 -0
@@ -1,6 +1,17 @@
 Email clients info for Linux
 ======================================================================
 
+Git
+----------------------------------------------------------------------
+These days most developers use `git send-email` instead of regular
+email clients.  On the receiving end, maintainers use `git am` to
+apply the patches.
+

Why is there nothing here about how to use 'git send-email' to send patches?

Quoted 8 lines
Documentation/email-clients.txt +5 -0
+If you are new to git then send your first patch to yourself.  Save it
+as raw text including all the headers.  Run `cat raw_email.txt | git am`
+and then review the changelog with `git log -p`.  When that works then
+send the patch to list.
+
 General Preferences
 ----------------------------------------------------------------------
 Patches for the Linux kernel are submitted via email, preferably as
Signature · 1 line
~Randy