Skip to contentSkip to conversation

Remove xfs_check for 3.2.0?

DISCUSSION Eric Sandeen 3 participants 5 messages May 8, 2014

lore
Share & tools
lore
#1 lore raw
Quoted 3 lines · Eric Sandeen

I think we had stated removal in June 2014, but it seems close enough.

Should xfs_check be removed prior to 3.2.0's release?

I'd prefer to do it slightly later than earlier.

As it is, 3.2.0 is really in the "critical fixes only" stage - like that repair prefetch bug. So apart from fixes like that, I don't want to be changing things right now.

Cheers,

Dave.

Signature · 7 lines
Dave Chinner
[email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
#2 lore raw
Quoted 7 lines · Dave Chinner
Quoted 3 lines · Eric Sandeen

I think we had stated removal in June 2014, but it seems close enough.

Should xfs_check be removed prior to 3.2.0's release?

I'd prefer to do it slightly later than earlier.

Quoted 8 lines

As it is, 3.2.0 is really in the "critical fixes only" stage - like that repair prefetch bug. So apart from fixes like that, I don't want to be changing things right now.

Cheers,

Dave.

*shrug* ok. Let a thousand "hey my xfs_check OOM'd" emails blossom! :)

FWIW, I did not have time to work on that prefetch bug yet today. :(

-Eric

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#3 lore raw

Le Thu, 08 May 2014 15:40:57 -0500 vous écriviez:

Quoted 5 lines

*shrug* ok. Let a thousand "hey my xfs_check OOM'd" emails blossom! :)

FWIW, I did not have time to work on that prefetch bug yet today. :(

Why not replace it by a script that simply states that it's useless and to run xfs_repair -n instead? It has been completely useless for the best part of the past ten years... This way you don't remove it but you'll sort of fix it :)

Signature · 11 lines
------------------------------------------------------------------------
Emmanuel Florac     |   Direction technique
                    |   Intellique
                    |	<[email protected]>
                    |   +33 1 78 94 84 02
------------------------------------------------------------------------

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
#4 lore raw
Quoted 5 lines · Emmanuel Florac

Le Thu, 08 May 2014 15:40:57 -0500 vous écriviez:

Quoted 3 lines

*shrug* ok. Let a thousand "hey my xfs_check OOM'd" emails blossom! :)

Quoted 7 lines
Quoted 2 lines

FWIW, I did not have time to work on that prefetch bug yet today. :(

Why not replace it by a script that simply states that it's useless and to run xfs_repair -n instead? It has been completely useless for the best part of the past ten years... This way you don't remove it but you'll sort of fix it :)

xfs_check is already just a script that wraps xfs_db.

However, there's all the man page updates, all the external documentation needs to be updated, etc. IOWs, it's not just a case of a simply patching out the xfs_check script....

Cheers,

Dave.

Signature · 7 lines
Dave Chinner
[email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs