zeromq: disable test_fork when fork() is no available
PATCH 1/1 zeromq: disable test_fork when fork() is no available
From: Samuel Martin <[email protected]>
zeromp's configure script correctly detects the fork availability, but unconditionally build test_fork program whatever the fork() availability.
This patch fixes the build-system by disabling test_fork when fork is not available (e.g. when !BR2_USEMMU).
Fixes:
http://autobuild.buildroot.org/results/359/3599cc3b7bf2bb22a78961cd84d21cb03cbd7015/
[yann.morin.1998 at free.fr: tested against the failed bfin config, as well as
a i686 target]
--- ...isable-test_fork-if-fork-is-not-available.patch | 52 ++++++++++++++++++++++ package/zeromq/zeromq.mk | 1 + 2 files changed, 53 insertions(+) create mode 100644 package/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patch
package/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patch new file +52 -0
@@ -0,0 +1,52 @@ +From b50912f2eecec1ea7accc155f8132116f8702075 Mon Sep 17 00:00:00 2001 +From: Samuel Martin <[email protected]> +Date: Sat, 3 May 2014 12:22:38 +0200 +Subject: [PATCH] tests: disable test_fork if fork() is not available + +Signed-off-by: Samuel Martin <[email protected]> +--- + configure.ac | 1 + + tests/Makefile.am | 8 ++++++-- + tests/Makefile.in | 8 ++++---- + 3 files changed, 11 insertions(+), 6 deletions(-) + +diff --git a/configure.ac b/configure.ac +index 0c41604..8f8521c 100644 +--- a/configure.ac ++++ b/configure.ac +@@ -431,6 +431,7 @@ AM_CONDITIONAL(BUILD_PGM, test "x$libzmq_pgm_ext" = "xyes") + AM_CONDITIONAL(ON_MINGW, test "x$libzmq_on_mingw32" = "xyes") + AM_CONDITIONAL(ON_ANDROID, test "x$libzmq_on_android" = "xyes") + AM_CONDITIONAL(ON_LINUX, test "x$libzmq_on_linux" = "xyes") ++AM_CONDITIONAL(HAVE_FORK, test "x$ac_cv_func_fork" = "xyes") + + # Checks for library functions. + AC_TYPE_SIGNAL +diff --git a/tests/Makefile.am b/tests/Makefile.am +index 0cfe4e8..2a1e257 100644 +--- a/tests/Makefile.am ++++ b/tests/Makefile.am +@@ -46,8 +46,10 @@ if !ON_MINGW + noinst_PROGRAMS += test_shutdown_stress \ + test_pair_ipc \ + test_reqrep_ipc \ +- test_timeo \ +- test_fork ++ test_timeo ++if HAVE_FORK ++noinst_PROGRAMS += test_fork ++endif + endif + + test_system_SOURCES = test_system.cpp +@@ -93,8 +95,10 @@ test_shutdown_stress_SOURCES = test_shutdown_stress.cpp + test_pair_ipc_SOURCES = test_pair_ipc.cpp testutil.hpp + test_reqrep_ipc_SOURCES = test_reqrep_ipc.cpp testutil.hpp + test_timeo_SOURCES = test_timeo.cpp ++if HAVE_FORK + test_fork_SOURCES = test_fork.cpp + endif ++endif + + # Run the test cases + TESTS = $(noinst_PROGRAMS)
package/zeromq/zeromq.mk +1 -0
@@ -10,6 +10,7 @@ ZEROMQ_INSTALL_STAGING = YES ZEROMQ_DEPENDENCIES = util-linux ZEROMQ_LICENSE = LGPLv3+ with exceptions ZEROMQ_LICENSE_FILES = COPYING COPYING.LESSER +ZEROMQ_AUTORECONF = YES ifeq ($(BR2_PACKAGE_ZEROMQ_PGM),y) ZEROMQ_DEPENDENCIES += host-pkgconf openpgm
Signature · 1 line
1.8.3.2
PATCH 1/1 zeromq: disable test_fork when fork() is no available
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Yann" == Yann E MORIN <[email protected]> writes:
From: Samuel Martin <[email protected]>
zeromp's configure script correctly detects the fork availability, but unconditionally buildtest_forkprogram whatever thefork()availability.This patch fixes the build-system by disabling
test_forkwhen fork is not available (e.g. when !BR2_USEMMU).
The symbol is called BR2_USE_MMU.
Committed, thanks. Please don't forget to send the patch upstream.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 zeromq: disable test_fork when fork() is no available
Peter, all,
Quoted 6 lines · Peter Korsgaard
Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Yann" == Yann E MORIN <[email protected]> writes:
From: Samuel Martin <[email protected]>
zeromp's configure script correctly detects the fork availability, but unconditionally buildtest_forkprogram whatever thefork()availability.
Quoted 6 lines
Quoted 2 lines
This patch fixes the build-system by disabling
test_forkwhen fork is not available (e.g. when !BR2_USEMMU).The symbol is called
BR2_USE_MMU.Committed, thanks. Please don't forget to send the patch upstream.
Already on it! :)
Quoted 7 lines
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 1 line
Samuel
PATCH 1/1 zeromq: disable test_fork when fork() is no available
In reply to Yann E. MORINHi Yann,
Quoted 29 lines
From: Samuel Martin <[email protected]>
zeromp's configure script correctly detects the fork availability, but unconditionally build
test_forkprogram whatever thefork()availability.This patch fixes the build-system by disabling
test_forkwhen fork is not available (e.g. when !BR2_USEMMU).Fixes:
http://autobuild.buildroot.org/results/359/3599cc3b7bf2bb22a78961cd84d21cb03cbd7015/Signed-off-by Samuel Martin <[email protected]>[yann.morin.1998 at free.fr: remove Makefile.in hunks]Signed-off-by "Yann E. MORIN" <[email protected]>[yann.morin.1998 at free.fr: tested against the failed bfin config, as well as
a i686 target]Tested-by "Yann E. MORIN" <[email protected]>--- ...isable-test_fork-if-fork-is-not-available.patch | 52 ++++++++++++++++++++++ package/zeromq/zeromq.mk | 1 + 2 files changed, 53 insertions(+)create mode 100644
package/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patchpackage/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patch new file +0
-0
package/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patch line 10
Quoted 10 lines
package/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patch new file +10
-0@@ -0,0 +1,52 @@ +From b50912f2eecec1ea7accc155f8132116f8702075 Mon Sep 17 00:00:00 2001 +From: Samuel Martin <[email protected]> +Date: Sat, 3 May 2014 12:22:38 +0200 +Subject: [PATCH] tests: disable test_fork if fork() is not available + +Signed-off-by: Samuel Martin <[email protected]> +--- + configure.ac | 1 + + tests/Makefile.am | 8 ++++++-- + tests/Makefile.in | 8 ++++----
What about the changes in Makefile.in file?
I don't see them here.
Regards,
Jerzy
Quoted 54 lines
package/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patch new file +42
-0+ 3 files changed, 11 insertions(+), 6 deletions(-) + +diff --git a/configure.ac b/configure.ac +index 0c41604..8f8521c 100644 +--- a/configure.ac ++++ b/configure.ac +@@ -431,6 +431,7 @@ AM_CONDITIONAL(BUILD_PGM, test "x$libzmq_pgm_ext" = "xyes") + AM_CONDITIONAL(ON_MINGW, test "x$libzmq_on_mingw32" = "xyes") + AM_CONDITIONAL(ON_ANDROID, test "x$libzmq_on_android" = "xyes") + AM_CONDITIONAL(ON_LINUX, test "x$libzmq_on_linux" = "xyes") ++AM_CONDITIONAL(HAVE_FORK, test "x$ac_cv_func_fork" = "xyes") + + # Checks for library functions. + AC_TYPE_SIGNAL +diff --git a/tests/Makefile.am b/tests/Makefile.am +index 0cfe4e8..2a1e257 100644 +--- a/tests/Makefile.am ++++ b/tests/Makefile.am +@@ -46,8 +46,10 @@ if !ON_MINGW + noinst_PROGRAMS += test_shutdown_stress \ + test_pair_ipc \ + test_reqrep_ipc \ +- test_timeo \ +- test_fork ++ test_timeo ++if HAVE_FORK ++noinst_PROGRAMS += test_fork ++endif + endif + + test_system_SOURCES = test_system.cpp +@@ -93,8 +95,10 @@ test_shutdown_stress_SOURCES = test_shutdown_stress.cpp + test_pair_ipc_SOURCES = test_pair_ipc.cpp testutil.hpp + test_reqrep_ipc_SOURCES = test_reqrep_ipc.cpp testutil.hpp + test_timeo_SOURCES = test_timeo.cpp ++if HAVE_FORK + test_fork_SOURCES = test_fork.cpp + endif ++endif + + # Run the test cases + TESTS = $(noinst_PROGRAMS)package/zeromq/zeromq.mk +1
-0@@ -10,6 +10,7 @@ ZEROMQ_INSTALL_STAGING = YES ZEROMQ_DEPENDENCIES = util-linux ZEROMQ_LICENSE = LGPLv3+ with exceptions ZEROMQ_LICENSE_FILES = COPYING COPYING.LESSER +ZEROMQ_AUTORECONF = YES ifeq ($(BR2_PACKAGE_ZEROMQ_PGM),y) ZEROMQ_DEPENDENCIES += host-pkgconf openpgm
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 zeromq: disable test_fork when fork() is no available
Jerzy, All,
[forgot to cc the Buildroot list on previous mail, sorry]
On 2014-05-09 11:44 +0200, Jerzy Grzegorek spake thusly:
Quoted 34 lines
Quoted 34 lines
From: Samuel Martin <[email protected]>
zeromp's configure script correctly detects the fork availability, but unconditionally build
test_forkprogram whatever thefork()availability.This patch fixes the build-system by disabling
test_forkwhen fork is not available (e.g. when !BR2_USEMMU).Fixes:
http://autobuild.buildroot.org/results/359/3599cc3b7bf2bb22a78961cd84d21cb03cbd7015/Signed-off-by Samuel Martin <[email protected]>[yann.morin.1998 at free.fr: remove Makefile.in hunks]Signed-off-by "Yann E. MORIN" <[email protected]>[yann.morin.1998 at free.fr: tested against the failed bfin config, as well as
a i686 target]Tested-by "Yann E. MORIN" <[email protected]>--- ...isable-test_fork-if-fork-is-not-available.patch | 52 ++++++++++++++++++++++ package/zeromq/zeromq.mk | 1 + 2 files changed, 53 insertions(+) create mode 100644 package/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patchpackage/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patch new file +5
-0@@ -0,0 +1,52 @@ +From b50912f2eecec1ea7accc155f8132116f8702075 Mon Sep 17 00:00:00 2001 +From: Samuel Martin <[email protected]> +Date: Sat, 3 May 2014 12:22:38 +0200 +Subject: [PATCH] tests: disable test_fork if fork() is not available +
Quoted 8 lines
package/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patch line 10
Quoted 5 lines
package/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patch new file +5
-0+Signed-off-by: Samuel Martin <[email protected]> +--- + configure.ac | 1 + + tests/Makefile.am | 8 ++++++-- + tests/Makefile.in | 8 ++++----What about the changes in Makefile.in file?
I don't see them here.
Ah, right. When I edited the patch to remove them, I forgot to remove Makefile.in from the diffstat. We do not need the changes to Makefile.in in this patch, since we do autoreconf the beast, so Makefile.in gets re-generated.
See the commit log that states;
[yann.morin.1998 at free.fr: remove Makefile.in hunks]
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 zeromq: disable test_fork when fork() is no available
Hi Yann,
Quoted 44 lines
Jerzy, All,
On 2014-05-09 11:44 +0200, Jerzy Grzegorek spake thusly:
Quoted 33 lines
Quoted 33 lines
From: Samuel Martin <[email protected]>
zeromp's configure script correctly detects the fork availability, but unconditionally build
test_forkprogram whatever thefork()availability.This patch fixes the build-system by disabling
test_forkwhen fork is not available (e.g. when !BR2_USEMMU).Fixes:
http://autobuild.buildroot.org/results/359/3599cc3b7bf2bb22a78961cd84d21cb03cbd7015/Signed-off-by Samuel Martin <[email protected]>[yann.morin.1998 at free.fr: remove Makefile.in hunks]Signed-off-by "Yann E. MORIN" <[email protected]>[yann.morin.1998 at free.fr: tested against the failed bfin config, as well as
a i686 target]Tested-by "Yann E. MORIN" <[email protected]>--- ...isable-test_fork-if-fork-is-not-available.patch | 52 ++++++++++++++++++++++ package/zeromq/zeromq.mk | 1 + 2 files changed, 53 insertions(+)create mode 100644
package/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patchpackage/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patch new file +4
-0@@ -0,0 +1,52 @@ +From b50912f2eecec1ea7accc155f8132116f8702075 Mon Sep 17 00:00:00 2001 +From: Samuel Martin <[email protected]> +Date: Sat, 3 May 2014 12:22:38 +0200 +Subject: [PATCH] tests: disable test_fork if fork() is not availableQuoted 8 lines
package/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patch line 10
Quoted 6 lines
package/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patch new file +6
-0+ +Signed-off-by: Samuel Martin <[email protected]> +--- + configure.ac | 1 + + tests/Makefile.am | 8 ++++++-- + tests/Makefile.in | 8 ++++----What about the changes in Makefile.in file?
I don't see them here.
Quoted 4 lines
Ah, right. When I edited the patch to remove them, I forgot to remove Makefile.in from the diffstat. We do not need the changes to Makefile.in in this patch, since we do autoreconf the beast, so Makefile.in gets re-generated.
Thanks for the clarification.
Regards,
Jerzy
Quoted 7 lines
See the commit log that states;
[yann.morin.1998 at free.fr: remove Makefile.in hunks]Regards,
Yann E. MORIN.