Skip to contentSkip to conversation

iptraf-ng: new package

PATCH New Ezequiel Garcia 2 participants 4 messages May 7, 2014 – May 9, 2014

lore
Share & tools
lore

Ezequiel Garcia

author
#0 lore raw

PATCH 1/1 iptraf-ng: new package

Signed-off-by Ezequiel Garcia <[email protected]>

---
I'm not sure how robust is this usage of MAKE_ENV to force a proper LDFLAGS for ncurses. Without this, the link is attempted against the host /usr/lib/ path.

If someone can give a hint on how to call ncurses-config to set the LDFLAG, it would be much nicer.

 package/Config.in              |  1 +
 package/iptraf-ng/Config.in    | 16 ++++++++++++++++
 package/iptraf-ng/iptraf-ng.mk | 15 +++++++++++++++
 3 files changed, 32 insertions(+)
 create mode 100644 package/iptraf-ng/Config.in
 create mode 100644 package/iptraf-ng/iptraf-ng.mk
package/Config.in +1 -0
index 7800f23..d7fe94c 100644
@@ -932,6 +932,7 @@ source "package/iproute2/Config.in"
 source "package/ipsec-tools/Config.in"
 source "package/ipset/Config.in"
 source "package/iptables/Config.in"
+source "package/iptraf-ng/Config.in"
 source "package/iputils/Config.in"
 source "package/iw/Config.in"
 source "package/kismet/Config.in"
package/iptraf-ng/Config.in new file +16 -0
new file mode 100644
index 0000000..4302b95
@@ -0,0 +1,16 @@
+config BR2_PACKAGE_IPTRAF_NG
+	bool "iptraf-ng"
+	select BR2_PACKAGE_NCURSES
+	select BR2_PACKAGE_NCURSES_TARGET_PANEL
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	help
+	  IPTraf-ng is a ncurses-based network monitoring utility. It gathers
+	  data like TCP connection packet and byte counts, interface statistics
+	  and activity indicators.
+
+	  https://fedorahosted.org/iptraf-ng/
+
+	  IPTraf-ng is a fork of original IPTraf v3.0.0 (http://iptraf.seul.org).
+
+comment "iptraf-ng needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
package/iptraf-ng/iptraf-ng.mk new file +15 -0
new file mode 100644
index 0000000..5821971
@@ -0,0 +1,15 @@
+################################################################################
+#
+# iptraf-ng
+#
+################################################################################
+
+IPTRAF_NG_VERSION = 1.1.4
+IPTRAF_NG_SITE = https://fedorahosted.org/releases/i/p/iptraf-ng/
+IPTRAF_NG_LICENSE = GPLv2+
+IPTRAF_NG_LICENSE_FILES = LICENSE
+IPTRAF_NG_DEPENDENCIES = ncurses
+
+IPTRAF_NG_MAKE_ENV = NCURSES_LDFLAGS="-L$(TARGET_DIR)/usr/lib -lncurses -lpanel"
+
+$(eval $(autotools-package))
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 iptraf-ng: new package

Quoted 36 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Ezequiel" == Ezequiel Garcia <[email protected]> writes:

Signed-off-by Ezequiel Garcia <[email protected]>

---
I'm not sure how robust is this usage of MAKE_ENV to force a proper LDFLAGS for ncurses. Without this, the link is attempted against the host /usr/lib/ path.

If someone can give a hint on how to call ncurses-config to set the LDFLAG, it would be much nicer.

 package/Config.in              |  1 +
 package/iptraf-ng/Config.in    | 16 ++++++++++++++++
 package/iptraf-ng/iptraf-ng.mk | 15 +++++++++++++++
 3 files changed, 32 insertions(+)
 create mode 100644 package/iptraf-ng/Config.in
 create mode 100644 package/iptraf-ng/iptraf-ng.mk
package/Config.in +1 -0
index 7800f23..d7fe94c 100644
@@ -932,6 +932,7 @@ source "package/iproute2/Config.in"
 source "package/ipsec-tools/Config.in"
 source "package/ipset/Config.in"
 source "package/iptables/Config.in"
+source "package/iptraf-ng/Config.in"
 source "package/iputils/Config.in"
 source "package/iw/Config.in"
 source "package/kismet/Config.in"
package/iptraf-ng/Config.in new file +0 -0
new file mode 100644
index 0000000..4302b95

package/iptraf-ng/Config.in line 5

Quoted 5 lines
package/iptraf-ng/Config.in new file +5 -0
@@ -0,0 +1,16 @@
+config BR2_PACKAGE_IPTRAF_NG
+	bool "iptraf-ng"
+	select BR2_PACKAGE_NCURSES
+	select BR2_PACKAGE_NCURSES_TARGET_PANEL
+	depends on BR2_TOOLCHAIN_HAS_THREADS

I don't see any pthread references anywwhere, but it does include netinet/ip6.h so it needs to depend on BR2_INET_IPV6.

Quoted 20 lines
package/iptraf-ng/Config.in new file +11 -0
+	help
+	  IPTraf-ng is a ncurses-based network monitoring utility. It gathers
+	  data like TCP connection packet and byte counts, interface statistics
+	  and activity indicators.
+
+	  https://fedorahosted.org/iptraf-ng/
+
+	  IPTraf-ng is a fork of original IPTraf v3.0.0 (http://iptraf.seul.org).
+
+comment "iptraf-ng needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
package/iptraf-ng/iptraf-ng.mk new file +3 -0
new file mode 100644
index 0000000..5821971
@@ -0,0 +1,15 @@
+################################################################################
+#
+# iptraf-ng

package/iptraf-ng/iptraf-ng.mk line 13

Quoted 10 lines
package/iptraf-ng/iptraf-ng.mk new file +10 -0
+#
+################################################################################
+
+IPTRAF_NG_VERSION = 1.1.4
+IPTRAF_NG_SITE = https://fedorahosted.org/releases/i/p/iptraf-ng/
+IPTRAF_NG_LICENSE = GPLv2+
+IPTRAF_NG_LICENSE_FILES = LICENSE
+IPTRAF_NG_DEPENDENCIES = ncurses
+
+IPTRAF_NG_MAKE_ENV = NCURSES_LDFLAGS="-L$(TARGET_DIR)/usr/lib -lncurses -lpanel"

The target directory will normally have the needed .a / .la files stripped, so it should use STAGING_DIR instead. None of them are needed though as the compiler is already configured to look there.

Finally -lpanel should go before -lncurses for static linking as it uses functions from there.

Committed with these fixes, thanks.

Signature · 1 line
Bye, Peter Korsgaard
author
#2 lore raw

PATCH 1/1 iptraf-ng: new package

Quoted 36 lines · Peter Korsgaard
Quoted 36 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Ezequiel" == Ezequiel Garcia <[email protected]> writes:

Signed-off-by Ezequiel Garcia <[email protected]>

---
I'm not sure how robust is this usage of MAKE_ENV to force a proper LDFLAGS for ncurses. Without this, the link is attempted against the host /usr/lib/ path.

If someone can give a hint on how to call ncurses-config to set the LDFLAG, it would be much nicer.

 package/Config.in              |  1 +
 package/iptraf-ng/Config.in    | 16 ++++++++++++++++
 package/iptraf-ng/iptraf-ng.mk | 15 +++++++++++++++
 3 files changed, 32 insertions(+)
 create mode 100644 package/iptraf-ng/Config.in
 create mode 100644 package/iptraf-ng/iptraf-ng.mk
package/Config.in +1 -0
index 7800f23..d7fe94c 100644
@@ -932,6 +932,7 @@ source "package/iproute2/Config.in"
 source "package/ipsec-tools/Config.in"
 source "package/ipset/Config.in"
 source "package/iptables/Config.in"
+source "package/iptraf-ng/Config.in"
 source "package/iputils/Config.in"
 source "package/iw/Config.in"
 source "package/kismet/Config.in"
package/iptraf-ng/Config.in new file +0 -0
new file mode 100644
index 0000000..4302b95
@@ -0,0 +1,16 @@
Quoted 9 lines

package/iptraf-ng/Config.in line 5

Quoted 5 lines
package/iptraf-ng/Config.in new file +5 -0
+config BR2_PACKAGE_IPTRAF_NG
+	bool "iptraf-ng"
+	select BR2_PACKAGE_NCURSES
+	select BR2_PACKAGE_NCURSES_TARGET_PANEL
+	depends on BR2_TOOLCHAIN_HAS_THREADS

I don't see any pthread references anywwhere, but it does include netinet/ip6.h so it needs to depend on BR2_INET_IPV6.

Arg! Searched for 'fork' instead of 'threads' and it seems I missed the ip6...

Quoted 35 lines
Quoted 20 lines
package/iptraf-ng/Config.in new file +11 -0
+	help
+	  IPTraf-ng is a ncurses-based network monitoring utility. It gathers
+	  data like TCP connection packet and byte counts, interface statistics
+	  and activity indicators.
+
+	  https://fedorahosted.org/iptraf-ng/
+
+	  IPTraf-ng is a fork of original IPTraf v3.0.0 (http://iptraf.seul.org).
+
+comment "iptraf-ng needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
package/iptraf-ng/iptraf-ng.mk new file +3 -0
new file mode 100644
index 0000000..5821971
@@ -0,0 +1,15 @@
+################################################################################
+#
+# iptraf-ng

package/iptraf-ng/iptraf-ng.mk line 13

Quoted 10 lines
package/iptraf-ng/iptraf-ng.mk new file +10 -0
+#
+################################################################################
+
+IPTRAF_NG_VERSION = 1.1.4
+IPTRAF_NG_SITE = https://fedorahosted.org/releases/i/p/iptraf-ng/
+IPTRAF_NG_LICENSE = GPLv2+
+IPTRAF_NG_LICENSE_FILES = LICENSE
+IPTRAF_NG_DEPENDENCIES = ncurses
+
+IPTRAF_NG_MAKE_ENV = NCURSES_LDFLAGS="-L$(TARGET_DIR)/usr/lib -lncurses -lpanel"

The target directory will normally have the needed .a / .la files stripped, so it should use STAGING_DIR instead. None of them are needed though as the compiler is already configured to look there.

Quoted 5 lines

Finally -lpanel should go before -lncurses for static linking as it uses functions from there.

Committed with these fixes, thanks.

OK, good. Just tested it builds fine.

Thanks,

Signature · 3 lines
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 iptraf-ng: new package

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Ezequiel" == Ezequiel Garcia <[email protected]> writes:

Hi,

Quoted 5 lines
Quoted 3 lines

I don't see any pthread references anywwhere, but it does include netinet/ip6.h so it needs to depend on BR2_INET_IPV6.

Arg! Searched for 'fork' instead of 'threads' and it seems I missed the ip6...

Ohh, so it needs to depend on BR2_USE_MMU. I'll fix that.

Quoted 5 lines
Quoted 1 line

Committed with these fixes, thanks.

OK, good. Just tested it builds fine.

Thanks,

Great, and you're welcome.

Signature · 1 line
Bye, Peter Korsgaard