Skip to contentSkip to conversation

ARM: shmobile: henninger: add QSPI DT support

PATCH New Sergei Shtylyov 2 participants 7 messages May 5, 2014 – May 13, 2014

Subsystems (2)
Device tree bindings SuperH
lore
Share & tools
lore

Sergei Shtylyov

author
#0 lore raw

PATCH 1/1 ARM: shmobile: henninger: add QSPI DT support

Define the Henninger board dependent part of the QSPI device node. Add device nodes for Spansion S25FL512S SPI flash and MTD partitions on it.

Signed-off-by Sergei Shtylyov <[email protected]>

---
This patch is against 'renesas-devel-v3.15-rc3-20140502' tag of Simon Horman's 'renesas.git' repo and SDHI0/2 DT support patch posted last weekend.

 arch/arm/boot/dts/r8a7791-henninger.dts |   38 ++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)
arch/arm/boot/dts/r8a7791-henninger.dts +38 -0
Index: renesas/arch/arm/boot/dts/r8a7791-henninger.dts
===================================================================
@@ -109,6 +109,11 @@
 		renesas,groups = "sdhi2_data4", "sdhi2_ctrl";
 		renesas,function = "sdhi2";
 	};
+
+	qspi_pins: spi0 {
+		renesas,groups = "qspi_ctrl", "qspi_data4";
+		renesas,function = "qspi";
+	};
 };
 
 &scif0 {

@@ -158,3 +163,36 @@
 	cd-gpios = <&gpio6 22 GPIO_ACTIVE_LOW>;
 	status = "okay";
 };
+
+&qspi {
+	pinctrl-0 = <&qspi_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+
+	flash at 0 {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		compatible = "spansion,s25fl512s";
+		reg = <0>;
+		spi-max-frequency = <30000000>;
+		spi-tx-bus-width = <4>;
+		spi-rx-bus-width = <4>;
+		m25p,fast-read;
+
+		partition at 0 {
+			label = "loader_prg";
+			reg = <0x00000000 0x00040000>;
+			read-only;
+		};
+		partition at 40000 {
+			label = "user_prg";
+			reg = <0x00040000 0x00400000>;
+			read-only;
+		};
+		partition at 440000 {
+			label = "flash_fs";
+			reg = <0x00440000 0x03bc0000>;
+		};
+	};
+};
#1 lore raw

PATCH 1/1 ARM: shmobile: henninger: add QSPI DT support

Quoted 11 lines · Sergei Shtylyov

Define the Henninger board dependent part of the QSPI device node. Add device nodes for Spansion S25FL512S SPI flash and MTD partitions on it.

Signed-off-by Sergei Shtylyov <[email protected]>

---
This patch is against 'renesas-devel-v3.15-rc3-20140502' tag of Simon Horman's 'renesas.git' repo and SDHI0/2 DT support patch posted last weekend.

 arch/arm/boot/dts/r8a7791-henninger.dts |   38 ++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

Thanks, I have queued this up.

author
#2 lore raw

PATCH 1/1 ARM: shmobile: henninger: add QSPI DT support

In reply to Sergei Shtylyov

Hello.

Quoted 16 lines · Sergei Shtylyov

Define the Henninger board dependent part of the QSPI device node. Add device nodes for Spansion S25FL512S SPI flash and MTD partitions on it.

Signed-off-by Sergei Shtylyov <[email protected]>

---
This patch is against 'renesas-devel-v3.15-rc3-20140502' tag of Simon Horman's 'renesas.git' repo and SDHI0/2 DT support patch posted last weekend.

  arch/arm/boot/dts/r8a7791-henninger.dts |   38 ++++++++++++++++++++++++++++++++
  1 file changed, 38 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7791-henninger.dts
===================================================================

arch/arm/boot/dts/r8a7791-henninger.dts +0 -0

[...]

Quoted 20 lines
arch/arm/boot/dts/r8a7791-henninger.dts +16 -0
@@ -158,3 +163,36 @@
  	cd-gpios = <&gpio6 22 GPIO_ACTIVE_LOW>;
  	status = "okay";
  };
+
+&qspi {
+	pinctrl-0 = <&qspi_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+
+	flash at 0 {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		compatible = "spansion,s25fl512s";
+		reg = <0>;
+		spi-max-frequency = <30000000>;
+		spi-tx-bus-width = <4>;
+		spi-rx-bus-width = <4>;
+		m25p,fast-read;

arch/arm/boot/dts/r8a7791-henninger.dts line 191

Quoted 10 lines
arch/arm/boot/dts/r8a7791-henninger.dts +10 -0
+
+		partition at 0 {
+			label = "loader_prg";
+			reg = <0x00000000 0x00040000>;
+			read-only;
+		};
+		partition at 40000 {
+			label = "user_prg";
+			reg = <0x00040000 0x00400000>;
+			read-only;

Oops, there shouldn't be "read-only" here, I forgot to refresh the patch
as I'm now seeing... too bad it's too late to resend now. :-(

WBR, Sergei

#3 lore raw

PATCH 1/1 ARM: shmobile: henninger: add QSPI DT support

Quoted 47 lines · Sergei Shtylyov

Hello.

Quoted 16 lines · Sergei Shtylyov

Define the Henninger board dependent part of the QSPI device node. Add device nodes for Spansion S25FL512S SPI flash and MTD partitions on it.

Signed-off-by Sergei Shtylyov <[email protected]>

---
This patch is against 'renesas-devel-v3.15-rc3-20140502' tag of Simon Horman's 'renesas.git' repo and SDHI0/2 DT support patch posted last weekend.

 arch/arm/boot/dts/r8a7791-henninger.dts |   38 ++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7791-henninger.dts
===================================================================

arch/arm/boot/dts/r8a7791-henninger.dts +0 -0

[...]

Quoted 26 lines
arch/arm/boot/dts/r8a7791-henninger.dts +22 -0
@@ -158,3 +163,36 @@
 	cd-gpios = <&gpio6 22 GPIO_ACTIVE_LOW>;
 	status = "okay";
 };
+
+&qspi {
+	pinctrl-0 = <&qspi_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+
+	flash at 0 {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		compatible = "spansion,s25fl512s";
+		reg = <0>;
+		spi-max-frequency = <30000000>;
+		spi-tx-bus-width = <4>;
+		spi-rx-bus-width = <4>;
+		m25p,fast-read;
+
+		partition at 0 {
+			label = "loader_prg";
+			reg = <0x00000000 0x00040000>;
+			read-only;
+		};
Quoted 8 lines

arch/arm/boot/dts/r8a7791-henninger.dts line 191

Quoted 4 lines
arch/arm/boot/dts/r8a7791-henninger.dts +4 -0
+		partition at 40000 {
+			label = "user_prg";
+			reg = <0x00040000 0x00400000>;
+			read-only;

Oops, there shouldn't be "read-only" here, I forgot to refresh
the patch as I'm now seeing... too bad it's too late to resend now. :-(

Could you send an incremental fix for me to queue up?

author
#4 lore raw

PATCH 1/1 ARM: shmobile: henninger: add QSPI DT support

Hello.

Quoted 52 lines · Simon Horman
Quoted 43 lines
Quoted 16 lines

Define the Henninger board dependent part of the QSPI device node. Add device nodes for Spansion S25FL512S SPI flash and MTD partitions on it.

Signed-off-by Sergei Shtylyov <[email protected]>

---
This patch is against 'renesas-devel-v3.15-rc3-20140502' tag of Simon Horman's 'renesas.git' repo and SDHI0/2 DT support patch posted last weekend.

  arch/arm/boot/dts/r8a7791-henninger.dts |   38 ++++++++++++++++++++++++++++++++
  1 file changed, 38 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7791-henninger.dts
===================================================================

arch/arm/boot/dts/r8a7791-henninger.dts +0 -0

[...]

Quoted 26 lines
arch/arm/boot/dts/r8a7791-henninger.dts +22 -0
@@ -158,3 +163,36 @@
  	cd-gpios = <&gpio6 22 GPIO_ACTIVE_LOW>;
  	status = "okay";
  };
+
+&qspi {
+	pinctrl-0 = <&qspi_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+
+	flash at 0 {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		compatible = "spansion,s25fl512s";
+		reg = <0>;
+		spi-max-frequency = <30000000>;
+		spi-tx-bus-width = <4>;
+		spi-rx-bus-width = <4>;
+		m25p,fast-read;
+
+		partition at 0 {
+			label = "loader_prg";
+			reg = <0x00000000 0x00040000>;
+			read-only;
+		};
Quoted 8 lines

arch/arm/boot/dts/r8a7791-henninger.dts line 191

Quoted 4 lines
arch/arm/boot/dts/r8a7791-henninger.dts +4 -0
+		partition at 40000 {
+			label = "user_prg";
+			reg = <0x00040000 0x00400000>;
+			read-only;

Oops, there shouldn't be "read-only" here, I forgot to refresh
the patch as I'm now seeing... too bad it's too late to resend now. :-(

Quoted 1 line

Could you send an incremental fix for me to queue up?

Yes, I will.

WBR, Sergei

author
#5 lore raw

PATCH 1/1 ARM: shmobile: henninger: add QSPI DT support

In reply to Simon Horman

Hello.

Quoted 52 lines · Simon Horman
Quoted 43 lines
Quoted 16 lines

Define the Henninger board dependent part of the QSPI device node. Add device nodes for Spansion S25FL512S SPI flash and MTD partitions on it.

Signed-off-by Sergei Shtylyov <[email protected]>

---
This patch is against 'renesas-devel-v3.15-rc3-20140502' tag of Simon Horman's 'renesas.git' repo and SDHI0/2 DT support patch posted last weekend.

  arch/arm/boot/dts/r8a7791-henninger.dts |   38 ++++++++++++++++++++++++++++++++
  1 file changed, 38 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7791-henninger.dts
===================================================================

arch/arm/boot/dts/r8a7791-henninger.dts +0 -0

[...]

Quoted 26 lines
arch/arm/boot/dts/r8a7791-henninger.dts +22 -0
@@ -158,3 +163,36 @@
  	cd-gpios = <&gpio6 22 GPIO_ACTIVE_LOW>;
  	status = "okay";
  };
+
+&qspi {
+	pinctrl-0 = <&qspi_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+
+	flash at 0 {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		compatible = "spansion,s25fl512s";
+		reg = <0>;
+		spi-max-frequency = <30000000>;
+		spi-tx-bus-width = <4>;
+		spi-rx-bus-width = <4>;
+		m25p,fast-read;
+
+		partition at 0 {
+			label = "loader_prg";
+			reg = <0x00000000 0x00040000>;
+			read-only;
+		};
Quoted 8 lines

arch/arm/boot/dts/r8a7791-henninger.dts line 191

Quoted 4 lines
arch/arm/boot/dts/r8a7791-henninger.dts +4 -0
+		partition at 40000 {
+			label = "user_prg";
+			reg = <0x00040000 0x00400000>;
+			read-only;

Oops, there shouldn't be "read-only" here, I forgot to refresh
the patch as I'm now seeing... too bad it's too late to resend now. :-(

Quoted 1 line

Could you send an incremental fix for me to queue up?

Oops, I've rechecked and it should indeed be read-only, so the patch was
correct. Sorry. :-)

WBR, Sergei

#6 lore raw

PATCH 1/1 ARM: shmobile: henninger: add QSPI DT support

Quoted 56 lines · Sergei Shtylyov

Hello.

Quoted 51 lines · Simon Horman
Quoted 51 lines
Quoted 16 lines

Define the Henninger board dependent part of the QSPI device node. Add device nodes for Spansion S25FL512S SPI flash and MTD partitions on it.

Signed-off-by Sergei Shtylyov <[email protected]>

---
This patch is against 'renesas-devel-v3.15-rc3-20140502' tag of Simon Horman's 'renesas.git' repo and SDHI0/2 DT support patch posted last weekend.

 arch/arm/boot/dts/r8a7791-henninger.dts |   38 ++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7791-henninger.dts
===================================================================

arch/arm/boot/dts/r8a7791-henninger.dts +0 -0

[...]

Quoted 20 lines
arch/arm/boot/dts/r8a7791-henninger.dts +16 -0
@@ -158,3 +163,36 @@
 	cd-gpios = <&gpio6 22 GPIO_ACTIVE_LOW>;
 	status = "okay";
 };
+
+&qspi {
+	pinctrl-0 = <&qspi_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+
+	flash at 0 {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		compatible = "spansion,s25fl512s";
+		reg = <0>;
+		spi-max-frequency = <30000000>;
+		spi-tx-bus-width = <4>;
+		spi-rx-bus-width = <4>;
+		m25p,fast-read;

arch/arm/boot/dts/r8a7791-henninger.dts line 191

Quoted 10 lines
arch/arm/boot/dts/r8a7791-henninger.dts +10 -0
+
+		partition at 0 {
+			label = "loader_prg";
+			reg = <0x00000000 0x00040000>;
+			read-only;
+		};
+		partition at 40000 {
+			label = "user_prg";
+			reg = <0x00040000 0x00400000>;
+			read-only;

Oops, there shouldn't be "read-only" here, I forgot to refresh
the patch as I'm now seeing... too bad it's too late to resend now. :-(

Quoted 4 lines
Quoted 1 line

Could you send an incremental fix for me to queue up?

Oops, I've rechecked and it should indeed be read-only, so the
patch was correct. Sorry. :-)

Thanks for double checking.
I think we can safely do nothing for now :-)