Skip to contentSkip to conversation

drivers/hwmon/emc1403.c: add new revision numbers to emc1403_detect()

PATCH In review Josef Gajdusek 2 participants 2 messages May 12, 2014 Hardware monitoring

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/hwmon/emc1403.c: add new revision numbers to emc1403_detect()

Adds new chip revision numbers to emc1403.c. Altough the datasheet (for emc1412) does not say so directly, it seems to suggest, that chips with revision ID 0x03 exist.

---

drivers/hwmon/emc1403.c +1 -1
index 61d89d6..b2b6a52 100644
@@ -330,7 +330,7 @@ static int emc1403_detect(struct i2c_client *client,
 	}
 
 	id = i2c_smbus_read_byte_data(client, THERMAL_REVISION_REG);
-	if (id != 0x01)
+	if (id < 0x01 || id > 0x04)
 		return -ENODEV;
 
 	return 0;

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

maintainer
#1 lore raw
Quoted 2 lines · Josef Gajdusek

Adds new chip revision numbers to emc1403.c. Altough the datasheet (for emc1412) does not say so directly, it seems to suggest, that chips with revision ID 0x03 exist.

In Table 10.1:

Rev. 1.37 (12-23-09) Section 7.17, "Revision Register"

Changed default from 01h to 03h to match the actual value.

Rev. 1.38 changed it to 0x04.

Quoted 1 line

Thanks, will apply.

Guenter

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors