Skip to contentSkip to conversation

drm/i915: Ringbuffer signal func for the second BSD ring

PATCH Applied [email protected] 3 participants 3 messages May 9, 2014 – May 13, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: Ringbuffer signal func for the second BSD ring

From: Oscar Mateo <[email protected]>

This is missing in:

commit 78325f2d270897c9ee0887125b7abb963eb8efea

Author: Ben Widawsky <[email protected]>
Date:   Tue Apr 29 14:52:29 2014 -0700

drm/i915: Virtualize the ringbuffer signal func

Looks to me like a rebase side-effect...

---
 drivers/gpu/drm/i915/intel_ringbuffer.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/intel_ringbuffer.c +1 -0
index 9907d66..203fa2b 100644
@@ -2182,6 +2182,7 @@ int intel_init_bsd2_ring_buffer(struct drm_device *dev)
 	ring->dispatch_execbuffer =
 			gen8_ring_dispatch_execbuffer;
 	ring->semaphore.sync_to = gen6_ring_sync;
+	ring->semaphore.signal = gen6_signal;
 	/*
 	 * The current semaphore is only applied on the pre-gen8. And there
 	 * is no bsd2 ring on the pre-gen8. So now the semaphore_register
Signature · 1 line
1.9.0
#1 lore raw
Quoted 5 lines · On Fri, May 09, 2014 at 01:44:59PM +0100, [email protected] wrote:

From: Oscar Mateo <[email protected]>

This is missing in:

commit 78325f2d270897c9ee0887125b7abb963eb8efea

Quoted 8 lines
Author: Ben Widawsky <[email protected]>
Date:   Tue Apr 29 14:52:29 2014 -0700

drm/i915: Virtualize the ringbuffer signal func

Looks to me like a rebase side-effect...

Queued for -next, thanks for the patch. Iirc there's been a regression report too. Anyone know the bugzilla?
-Daniel

Quoted 23 lines
---
 drivers/gpu/drm/i915/intel_ringbuffer.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/intel_ringbuffer.c +1 -0
index 9907d66..203fa2b 100644
@@ -2182,6 +2182,7 @@ int intel_init_bsd2_ring_buffer(struct drm_device *dev)
 	ring->dispatch_execbuffer =
 			gen8_ring_dispatch_execbuffer;
 	ring->semaphore.sync_to = gen6_ring_sync;
+	ring->semaphore.signal = gen6_signal;
 	/*
 	 * The current semaphore is only applied on the pre-gen8. And there
 	 * is no bsd2 ring on the pre-gen8. So now the semaphore_register
Signature · 6 lines
1.9.0

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
#2 lore raw
Quoted 9 lines · Daniel Vetter
Quoted 8 lines · On Fri, May 09, 2014 at 01:44:59PM +0100, [email protected] wrote:

From: Oscar Mateo <[email protected]>

This is missing in:

commit 78325f2d270897c9ee0887125b7abb963eb8efea

Author: Ben Widawsky <[email protected]>
Date:   Tue Apr 29 14:52:29 2014 -0700
Quoted 8 lines
Quoted 5 lines

drm/i915: Virtualize the ringbuffer signal func

Looks to me like a rebase side-effect...

Queued for -next, thanks for the patch. Iirc there's been a regression report too. Anyone know the bugzilla?

It seems that this patch can fix the issue in:

https://bugs.freedesktop.org/show_bug.cgi?id=78274

Thanks.
Yakui

Quoted 26 lines

-Daniel

Quoted 23 lines
---
 drivers/gpu/drm/i915/intel_ringbuffer.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/intel_ringbuffer.c +1 -0
index 9907d66..203fa2b 100644
@@ -2182,6 +2182,7 @@ int intel_init_bsd2_ring_buffer(struct drm_device *dev)
 	ring->dispatch_execbuffer =
 			gen8_ring_dispatch_execbuffer;
 	ring->semaphore.sync_to = gen6_ring_sync;
+	ring->semaphore.signal = gen6_signal;
 	/*
 	 * The current semaphore is only applied on the pre-gen8. And there
 	 * is no bsd2 ring on the pre-gen8. So now the semaphore_register
Signature · 6 lines
1.9.0

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx