protobuf: host-protobuf can only be built on certain architectures

PATCH New Thomas Petazzoni 3 participants 3 messages May 12, 2014

Share & tools

Thomas Petazzoni

author

2014-05-12 17:45 UTC #0 lore raw

PATCH v2 1/1 protobuf: host-protobuf can only be built on certain architectures

The host-protobuf package can only build on certain architectures. For example, host-protobuf does not build on PowerPC platforms, causing build failures on the autobuilders. Since we don't really care about build platforms other than x86 and x86-64, this commit restricts the build of host-protobuf to these architectures only, even though if technically it could build on ARM and MIPS.

Fixes:

http://autobuild.buildroot.org/results/9b9/9b9b20b0e4694b11425cdc2382650cdc2774e400/

Signed-off-by Thomas Petazzoni <[email protected]>

---
Changes since v1:
- Propagate the dependency to ola and collectd, as noticed by Baruch Siach

Signed-off-by Thomas Petazzoni <[email protected]>

---
 package/collectd/Config.in        | 2 ++
 package/ola/Config.in             | 2 ++
 package/protobuf-c/Config.in      | 3 +++
 package/protobuf/Config.in        | 3 +++
 package/python-protobuf/Config.in | 2 ++
 5 files changed, 12 insertions(+)

package/collectd/Config.in +2 -0

index daa9603..f693f31 100644
@@ -419,6 +419,8 @@ comment "rrdtool support needs a toolchain w/ wchar"
 config BR2_PACKAGE_COLLECTD_RIEMANN
 	bool "riemann"
 	depends on BR2_INSTALL_LIBSTDCPP # protobuf
+	# protobuf-c -> host-protobuf
+	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
 	select BR2_PACKAGE_PROTOBUF_C
 	help
 	  Sends data to Riemann, a stream processing and monitoring system.

package/ola/Config.in +2 -0

index 8d202a5..713102c 100644
@@ -12,6 +12,8 @@ config BR2_PACKAGE_OLA
 	depends on BR2_USE_WCHAR # util-linux
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64 # protobuf
+	# protobuf -> host-protobuf
+	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
 	help
 	  Open Lighting Architecture provides applications
 	  with a mechanism to send and receive DMX512 & RDM

package/protobuf-c/Config.in +3 -0

index 732befc..f9fab37 100644
@@ -2,6 +2,8 @@ config BR2_PACKAGE_PROTOBUF_C
 	bool "protobuf-c"
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_THREADS # protobuf
+	# host-protobuf only builds on certain architectures
+	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
 	help
 	  Code generator and runtime libraries to use Protocol Buffers
 	  from pure C (not C++).

@@ -10,3 +12,4 @@ config BR2_PACKAGE_PROTOBUF_C
 
 comment "protobuf-c needs a toolchain w/ C++, threads"
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"

package/protobuf/Config.in +3 -0

index 293a9b9..6015b13 100644
@@ -5,6 +5,8 @@ config BR2_PACKAGE_PROTOBUF
 	# See src/google/protobuf/stubs/platform_macros.h for supported archs.
 	# PowerPC doesn't actually work.
 	depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64
+	# host-protobuf only builds on certain architectures
+	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
 	help
 	  Protocol buffers are Google's language-neutral, platform-neutral,
 	  extensible mechanism for serializing structured data.

@@ -14,3 +16,4 @@ config BR2_PACKAGE_PROTOBUF
 comment "protobuf needs a toolchain w/ C++, threads"
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64
+	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"

package/python-protobuf/Config.in +2 -0

index ec22057..6649dfc 100644
@@ -1,6 +1,8 @@
 config BR2_PACKAGE_PYTHON_PROTOBUF
 	bool "python-protobuf"
 	depends on BR2_PACKAGE_PYTHON
+	# host-protobuf only builds on certain architectures
+	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
 	help
 	  Python implementation of the Google Protocol Buffers.

Signature · 1 line

1.9.2

Baruch Siach

2014-05-12 19:05 UTC #1 lore raw

PATCH v2 1/1 protobuf: host-protobuf can only be built on certain architectures

Hi Thomas,

Quoted 7 lines · Thomas Petazzoni

The host-protobuf package can only build on certain architectures. For example, host-protobuf does not build on PowerPC platforms, causing build failures on the autobuilders. Since we don't really care about build platforms other than x86 and x86-64, this commit restricts the build of host-protobuf to these architectures only, even though if technically it could build on ARM and MIPS.

Quoted 5 lines

Fixes:
http://autobuild.buildroot.org/results/9b9/9b9b20b0e4694b11425cdc2382650cdc2774e400/
Signed-off-by Thomas Petazzoni <[email protected]>

Reviewed-by Baruch Siach <[email protected]>

baruch

Quoted 90 lines

---
Changes since v1:
- Propagate the dependency to ola and collectd, as noticed by Baruch Siach

Signed-off-by Thomas Petazzoni <[email protected]>

---
 package/collectd/Config.in        | 2 ++
 package/ola/Config.in             | 2 ++
 package/protobuf-c/Config.in      | 3 +++
 package/protobuf/Config.in        | 3 +++
 package/python-protobuf/Config.in | 2 ++
 5 files changed, 12 insertions(+)

package/collectd/Config.in +2 -0

index daa9603..f693f31 100644
@@ -419,6 +419,8 @@ comment "rrdtool support needs a toolchain w/ wchar"
 config BR2_PACKAGE_COLLECTD_RIEMANN
 	bool "riemann"
 	depends on BR2_INSTALL_LIBSTDCPP # protobuf
+	# protobuf-c -> host-protobuf
+	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
 	select BR2_PACKAGE_PROTOBUF_C
 	help
 	  Sends data to Riemann, a stream processing and monitoring system.

package/ola/Config.in +2 -0

index 8d202a5..713102c 100644
@@ -12,6 +12,8 @@ config BR2_PACKAGE_OLA
 	depends on BR2_USE_WCHAR # util-linux
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64 # protobuf
+	# protobuf -> host-protobuf
+	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
 	help
 	  Open Lighting Architecture provides applications
 	  with a mechanism to send and receive DMX512 & RDM

package/protobuf-c/Config.in +3 -0

index 732befc..f9fab37 100644
@@ -2,6 +2,8 @@ config BR2_PACKAGE_PROTOBUF_C
 	bool "protobuf-c"
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_THREADS # protobuf
+	# host-protobuf only builds on certain architectures
+	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
 	help
 	  Code generator and runtime libraries to use Protocol Buffers
 	  from pure C (not C++).

@@ -10,3 +12,4 @@ config BR2_PACKAGE_PROTOBUF_C
 
 comment "protobuf-c needs a toolchain w/ C++, threads"
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"

package/protobuf/Config.in +3 -0

index 293a9b9..6015b13 100644
@@ -5,6 +5,8 @@ config BR2_PACKAGE_PROTOBUF
 	# See src/google/protobuf/stubs/platform_macros.h for supported archs.
 	# PowerPC doesn't actually work.
 	depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64
+	# host-protobuf only builds on certain architectures
+	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
 	help
 	  Protocol buffers are Google's language-neutral, platform-neutral,
 	  extensible mechanism for serializing structured data.

@@ -14,3 +16,4 @@ config BR2_PACKAGE_PROTOBUF
 comment "protobuf needs a toolchain w/ C++, threads"
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64
+	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"

package/python-protobuf/Config.in +2 -0

index ec22057..6649dfc 100644
@@ -1,6 +1,8 @@
 config BR2_PACKAGE_PYTHON_PROTOBUF
 	bool "python-protobuf"
 	depends on BR2_PACKAGE_PYTHON
+	# host-protobuf only builds on certain architectures
+	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
 	help
 	  Python implementation of the Google Protocol Buffers.

Signature · 3 lines

     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

Peter Korsgaard

2014-05-12 20:21 UTC #2 lore raw

PATCH v2 1/1 protobuf: host-protobuf can only be built on certain architectures

In reply to Thomas Petazzoni

Quoted 11 lines

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas Petazzoni <[email protected]> writes:
The host-protobuf package can only build on certain architectures. For example, host-protobuf does not build on PowerPC platforms, causing build failures on the autobuilders. Since we don't really care about build platforms other than x86 and x86-64, this commit restricts the build of host-protobuf to these architectures only, even though if technically it could build on ARM and MIPS.
Fixes:

Quoted 7 lines

http://autobuild.buildroot.org/results/9b9/9b9b20b0e4694b11425cdc2382650cdc2774e400/
Signed-off-by Thomas Petazzoni <[email protected]>
---
Changes since v1:
- Propagate the dependency to ola and collectd, as noticed by Baruch Siach

Committed, thanks.

Signature · 1 line

Bye, Peter Korsgaard