Skip to contentSkip to conversation

tps6586x: staticize funtions

U-Boot Manish Badarkhe 2 participants 3 messages Apr 24, 2014 – May 13, 2014

lore
Share & tools
lore
#0 lore raw

Make funtions static which are locally used in file.

---
:100644 100644 704c243... d29d969... M drivers/power/tps6586x.c

 drivers/power/tps6586x.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/power/tps6586x.c +2 -2
index 704c243..d29d969 100644
@@ -32,7 +32,7 @@ enum {
 };
 
 #define MAX_I2C_RETRY	3
-int tps6586x_read(int reg)
+static int tps6586x_read(int reg)
 {
 	int	i;
 	uchar	data;
@@ -61,7 +61,7 @@ exit:
 	return retval;
 }
 
-int tps6586x_write(int reg, uchar *data, uint len)
+static int tps6586x_write(int reg, uchar *data, uint len)
 {
 	int	i;
 	int	retval = -1;
Signature · 1 line
1.7.10.4
#1 lore raw

Hi Tom,

Quoted 31 lines · Manish Badarkhe

Make funtions static which are locally used in file.

---
:100644 100644 704c243... d29d969... M drivers/power/tps6586x.c

 drivers/power/tps6586x.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/power/tps6586x.c +2 -3
index 704c243..d29d969 100644
@@ -32,7 +32,7 @@ enum {
 };
 
 #define MAX_I2C_RETRY  3
-int tps6586x_read(int reg)
+static int tps6586x_read(int reg)
 {
        int     i;
        uchar   data;
@@ -61,7 +61,7 @@ exit:
        return retval;
 }
 
-int tps6586x_write(int reg, uchar *data, uint len)
+static int tps6586x_write(int reg, uchar *data, uint len)
 {
        int     i;
        int     retval = -1;
--
Quoted 2 lines

1.7.10.4

Please provide your comments on this patch.

Thanks
Manish Badarkhe

#2 lore raw
In reply to Manish Badarkhe
Quoted 3 lines · Manish Badarkhe

Make funtions static which are locally used in file.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140512/860cda42/attachment.pgp>