qtquick1: removed OpenGL dependencies
PATCH 1/1 qtquick1: removed OpenGL dependencies
QtQuick1 module doesn't need OpenGl libs and declarative module.
This module can be used to port qt4 qml apps to qt5. Patch has been tested with linuxfb output plugin.
--- package/qt5/qt5quick1/Config.in | 8 ++------ package/qt5/qt5quick1/qt5quick1.mk | 2 +- 2 files changed, 3 insertions(+), 7 deletions(-)
package/qt5/qt5quick1/Config.in +2 -6
@@ -5,11 +5,8 @@ config BR2_PACKAGE_QT5QUICK1 select BR2_PACKAGE_QT5BASE_WIDGETS select BR2_PACKAGE_QT5SCRIPT select BR2_PACKAGE_QT5XMLPATTERNS - select BR2_PACKAGE_QT5DECLARATIVE # This module does not support static linking depends on !BR2_PREFER_STATIC_LIB - depends on BR2_PACKAGE_HAS_LIBEGL - depends on BR2_PACKAGE_HAS_LIBGLES depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE help Qt is a cross-platform application and UI framework for
@@ -19,7 +16,6 @@ config BR2_PACKAGE_QT5QUICK1 http://qt-project.org -comment "qt5quick1 needs a toolchain w/ dynamic library and an OpenGL-capable backend" +comment "qt5quick1 needs a toolchain w/ dynamic library" depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE - depends on !BR2_PACKAGE_HAS_LIBEGL || !BR2_PACKAGE_HAS_LIBGLES || \ - BR2_PREFER_STATIC_LIB + depends on BR2_PREFER_STATIC_LIB
package/qt5/qt5quick1/qt5quick1.mk +1 -1
@@ -7,7 +7,7 @@ QT5QUICK1_VERSION = $(QT5_VERSION) QT5QUICK1_SITE = $(QT5_SITE) QT5QUICK1_SOURCE = qtquick1-opensource-src-$(QT5QUICK1_VERSION).tar.xz -QT5QUICK1_DEPENDENCIES = qt5base qt5xmlpatterns qt5script qt5declarative \ +QT5QUICK1_DEPENDENCIES = qt5base qt5xmlpatterns qt5script \ $(if $(BR2_PACKAGE_QT5WEBKIT),qt5webkit) QT5QUICK1_INSTALL_STAGING = YES
Signature · 1 line
1.7.10.4
PATCH 1/1 qtquick1: removed OpenGL dependencies
Dear Wojciech Slenska,
Quoted 4 lines · Wojciech Slenska
QtQuick1 module doesn't need OpenGl libs and declarative module.
This module can be used to port qt4 qml apps to qt5. Patch has been tested with linuxfb output plugin.Signed-off-by Wojciech Slenska <[email protected]>
Thanks for this patch. Can qt5quick1 optionally depend on qt5declarative? If it's the case, then the .mk file should have something like:
ifeq ($(select BR2_PACKAGE_QT5DECLARATIVE),y)QT5QUICK1_DEPENDENCIES += qt5declarative
endif
Fatih, could you review this patch?
Thanks!
Thomas
Quoted 44 lines
--- package/qt5/qt5quick1/Config.in | 8 ++------ package/qt5/qt5quick1/qt5quick1.mk | 2 +- 2 files changed, 3 insertions(+), 7 deletions(-)package/qt5/qt5quick1/Config.in +2
-6@@ -5,11 +5,8 @@ config BR2_PACKAGE_QT5QUICK1 select BR2_PACKAGE_QT5BASE_WIDGETS select BR2_PACKAGE_QT5SCRIPT select BR2_PACKAGE_QT5XMLPATTERNS - select BR2_PACKAGE_QT5DECLARATIVE # This module does not support static linking depends on !BR2_PREFER_STATIC_LIB - depends on BR2_PACKAGE_HAS_LIBEGL - depends on BR2_PACKAGE_HAS_LIBGLES depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE help Qt is a cross-platform application and UI framework for@@ -19,7 +16,6 @@ config BR2_PACKAGE_QT5QUICK1 http://qt-project.org -comment "qt5quick1 needs a toolchain w/ dynamic library and an OpenGL-capable backend" +comment "qt5quick1 needs a toolchain w/ dynamic library" depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE - depends on !BR2_PACKAGE_HAS_LIBEGL || !BR2_PACKAGE_HAS_LIBGLES || \ - BR2_PREFER_STATIC_LIB + depends on BR2_PREFER_STATIC_LIBpackage/qt5/qt5quick1/qt5quick1.mk +1
-1@@ -7,7 +7,7 @@ QT5QUICK1_VERSION = $(QT5_VERSION) QT5QUICK1_SITE = $(QT5_SITE) QT5QUICK1_SOURCE = qtquick1-opensource-src-$(QT5QUICK1_VERSION).tar.xz -QT5QUICK1_DEPENDENCIES = qt5base qt5xmlpatterns qt5script qt5declarative \ +QT5QUICK1_DEPENDENCIES = qt5base qt5xmlpatterns qt5script \ $(if $(BR2_PACKAGE_QT5WEBKIT),qt5webkit) QT5QUICK1_INSTALL_STAGING = YES
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 qtquick1: removed OpenGL dependencies
2014-05-06 21:21 GMT+02:00 Thomas Petazzoni
<[email protected]>:
Quoted 8 lines
Dear Wojciech Slenska,
Quoted 4 lines · Wojciech Slenska
QtQuick1 module doesn't need OpenGl libs and declarative module.
This module can be used to port qt4 qml apps to qt5. Patch has been tested with linuxfb output plugin.Signed-off-by Wojciech Slenska <[email protected]>
Quoted 8 lines
Thanks for this patch. Can qt5quick1 optionally depend on qt5declarative? If it's the case, then the .mk file should have something like:
ifeq ($(select BR2_PACKAGE_QT5DECLARATIVE),y)
QT5QUICK1_DEPENDENCIES+= qt5declarative
endif
Hello Thomas,
Thanks for your comment.
I'm using qtquick1 library on following HW configurations: TI AM3517 with EGL support and Freescale imx28 with linuxfb plugin. I neither of these configurations QtQuick2 (qt5declarative) is needed. Only different thing is that when we build qt with EGL support, qtquick1 also need EGL libs to work.
In qt5 we can use two versions of QML:
qtquick1 (libQt5Declarative.so) -> Can be used to port old apps to qt5 or for processors which doesn't have OpenGl. For those version opengl isn't needed, but can be used. I'm using it on ARM9 without opengl (imx28)
qtquick2 (libQt5Quick.so) -> New version which needs OpenGL to work. I'm using it on TI AM proccessor.
I never saw any dependency between those two libs.
Best Regards,
Wojciech Slenska
Quoted 57 lines
Fatih, could you review this patch?
Thanks!
Thomas
Quoted 36 lines
--- package/qt5/qt5quick1/Config.in | 8 ++------ package/qt5/qt5quick1/qt5quick1.mk | 2 +- 2 files changed, 3 insertions(+), 7 deletions(-)package/qt5/qt5quick1/Config.in +2
-6@@ -5,11 +5,8 @@ config BR2_PACKAGE_QT5QUICK1 select BR2_PACKAGE_QT5BASE_WIDGETS select BR2_PACKAGE_QT5SCRIPT select BR2_PACKAGE_QT5XMLPATTERNS - select BR2_PACKAGE_QT5DECLARATIVE # This module does not support static linking depends on !BR2_PREFER_STATIC_LIB - depends on BR2_PACKAGE_HAS_LIBEGL - depends on BR2_PACKAGE_HAS_LIBGLES depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE help Qt is a cross-platform application and UI framework for@@ -19,7 +16,6 @@ config BR2_PACKAGE_QT5QUICK1 http://qt-project.org -comment "qt5quick1 needs a toolchain w/ dynamic library and an OpenGL-capable backend" +comment "qt5quick1 needs a toolchain w/ dynamic library" depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE - depends on !BR2_PACKAGE_HAS_LIBEGL || !BR2_PACKAGE_HAS_LIBGLES || \ - BR2_PREFER_STATIC_LIB + depends on BR2_PREFER_STATIC_LIBpackage/qt5/qt5quick1/qt5quick1.mk +0
-0package/qt5/qt5quick1/qt5quick1.mk line 13
Quoted 8 lines
package/qt5/qt5quick1/qt5quick1.mk +1
-1@@ -7,7 +7,7 @@ QT5QUICK1_VERSION = $(QT5_VERSION) QT5QUICK1_SITE = $(QT5_SITE) QT5QUICK1_SOURCE = qtquick1-opensource-src-$(QT5QUICK1_VERSION).tar.xz -QT5QUICK1_DEPENDENCIES = qt5base qt5xmlpatterns qt5script qt5declarative \ +QT5QUICK1_DEPENDENCIES = qt5base qt5xmlpatterns qt5script \ $(if $(BR2_PACKAGE_QT5WEBKIT),qt5webkit) QT5QUICK1_INSTALL_STAGING = YES--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
PATCH 1/1 qtquick1: removed OpenGL dependencies
In reply to Thomas PetazzoniQuoted 11 lines · On Tuesday 06 May 2014 22:21:21 Thomas Petazzoni wrote:
Dear Wojciech Slenska,
Quoted 5 lines · Wojciech Slenska
QtQuick1 module doesn't need OpenGl libs and declarative module. This module can be used to port qt4 qml apps to qt5. Patch has been tested with linuxfb output plugin.
Signed-off-by Wojciech Slenska <[email protected]>Thanks for this patch. Can qt5quick1 optionally depend on qt5declarative?
No. Probably, the library and package names confused me in the past.
BTW, I have noticed a missing dependency of this package (BR2_PACKAGE_QT5BASE_NETWORK). I will send a patch for this.
Quoted 1 line
Fatih, could you review this patch?
Regards,
Fatih
PATCH 1/1 qtquick1: removed OpenGL dependencies
In reply to Wojciech SlenskaQuoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Wojciech" == Wojciech Slenska <[email protected]> writes:
QtQuick1 module doesn't need OpenGl libs and declarative module.
This module can be used to port qt4 qml apps to qt5. Patch has been tested with linuxfb output plugin.Signed-off-by Wojciech Slenska <[email protected]>
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard