mtip32xx: blk_mq_init_queue() returns an ERR_PTR

PATCH In review Dan Carpenter 2 participants 2 messages May 14, 2014

Subsystems (2)

Block layer Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2014-05-14 12:54 UTC #0 lore raw

PATCH 1/1 mtip32xx: blk_mq_init_queue() returns an ERR_PTR

We changed this from blk_alloc_queue_node() to blk_mq_init_queue() so the check needs to be updated as well.

Fixes ee5036035df1 ('mtip32xx: convert to use blk-mq')

Signed-off-by Dan Carpenter <[email protected]>

drivers/block/mtip32xx/mtip32xx.c +1 -1

index 3a0882e..5979ab3 100644
@@ -3890,7 +3890,7 @@ skip_create_disk:
 
 	/* Allocate the request queue. */
 	dd->queue = blk_mq_init_queue(&dd->tags);
-	if (dd->queue = NULL) {
+	if (IS_ERR(dd->queue)) {
 		dev_err(&dd->pdev->dev,
 			"Unable to allocate request queue\n");
 		rv = -ENOMEM;

Jens Axboe

2014-05-14 14:07 UTC #1 lore raw

Quoted 5 lines · Dan Carpenter

We changed this from blk_alloc_queue_node() to blk_mq_init_queue() so the check needs to be updated as well.
Fixes ee5036035df1 ('mtip32xx: convert to use blk-mq')
Signed-off-by Dan Carpenter <[email protected]>

Thanks Dan, applied.

Signature · 1 line

Jens Axboe