Skip to contentSkip to conversation

package/rsyslog: Add missing optional dependency libcrypt

PATCH New Bernd Kuhls 5 participants 7 messages May 14, 2014 – May 15, 2014

lore
Share & tools
lore

Bernd Kuhls

author
#0 lore raw

PATCH 1/2 package/rsyslog: Add missing optional dependency libcrypt

Signed-off-by Bernd Kuhls <[email protected]>
---
 package/rsyslog/rsyslog.mk |    1 +
 1 file changed, 1 insertion(+)
package/rsyslog/rsyslog.mk +1 -0
index c124c02..88747b7 100644
@@ -24,6 +24,7 @@ ifeq ($(BR2_PACKAGE_LIBEE),y)
 endif
 
 ifeq ($(BR2_PACKAGE_LIBGCRYPT),y)
+	RSYSLOG_DEPENDENCIES += libgcrypt
 	RSYSLOG_CONF_ENV += LIBGCRYPT_CONFIG=$(STAGING_DIR)/usr/bin/libgcrypt-config
 	RSYSLOG_CONF_OPT += --enable-libgcrypt=yes
 else
Signature · 1 line
1.7.10.4
author
#1 lore raw

PATCH 2/2 package/rsyslog: needs MMU (fork)

fixes http://autobuild.buildroot.net/results/5c0/5c03bf3a1e4e922a18b40f854ff59d905a93a89f/

Signed-off-by Bernd Kuhls <[email protected]>
---
 package/rsyslog/Config.in |    1 +
 1 file changed, 1 insertion(+)
package/rsyslog/Config.in +1 -0
index 8a84fea..82a6922 100644
@@ -8,6 +8,7 @@ config BR2_PACKAGE_RSYSLOG
 	select BR2_PACKAGE_UTIL_LINUX_LIBUUID
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_LARGEFILE # util-linux
+	depends on BR2_USE_MMU # fork()
 	depends on BR2_USE_WCHAR # util-linux
 	help
 	  Rsyslog is a powerful and flexible syslog implementation
Signature · 1 line
1.7.10.4
#2 lore raw

PATCH 2/2 package/rsyslog: needs MMU (fork)

Hi Bernd,

Quoted 12 lines · Bernd Kuhls

fixes http://autobuild.buildroot.net/results/5c0/5c03bf3a1e4e922a18b40f854ff59d905a93a89f/

Signed-off-by Bernd Kuhls <[email protected]>
---
 package/rsyslog/Config.in |    1 +
 1 file changed, 1 insertion(+)
package/rsyslog/Config.in +0 -0
index 8a84fea..82a6922 100644

package/rsyslog/Config.in config BR2_PACKAGE_RSYSLOG · line 11

Quoted 4 lines
package/rsyslog/Config.in +1 -0
@@ -8,6 +8,7 @@ config BR2_PACKAGE_RSYSLOG
 	select BR2_PACKAGE_UTIL_LINUX_LIBUUID
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_LARGEFILE # util-linux
+	depends on BR2_USE_MMU # fork()

Please also update the dependencies comment.

baruch

Quoted 4 lines
package/rsyslog/Config.in +0 -0
 	depends on BR2_USE_WCHAR # util-linux
 	help
 	  Rsyslog is a powerful and flexible syslog implementation
Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#3 lore raw

PATCH 2/2 package/rsyslog: needs MMU (fork)

Baruch Siach <[email protected]> wrote in
news:20140514183816.GI4096 at tarshish:

Quoted 3 lines
Quoted 1 line

+ depends on BR2_USE_MMU # fork()

Please also update the dependencies comment.

Hi,

afaics nowhere in buildroot exists a comment for the !BR2_USE_MMU case.

Regards, Bernd

#4 lore raw

PATCH 2/2 package/rsyslog: needs MMU (fork)

Bernd, All,

On 2014-05-14 20:57 +0200, Bernd Kuhls spake thusly:

Quoted 8 lines

Baruch Siach <[email protected]> wrote in
news:20140514183816.GI4096 at tarshish:

Quoted 3 lines
Quoted 1 line

+ depends on BR2_USE_MMU # fork()

Please also update the dependencies comment.

afaics nowhere in buildroot exists a comment for the !BR2_USE_MMU case.

Partially wrong. See:
http://buildroot.net/downloads/manual/manual.html#_literal_config_in_literal_file

* MMU support
- Dependency symbol: BR2_USE_MMU
- Comment string: no comment to be added

So, indeed, we do not add 'MMU' in the comment, but still the depndency should be propagated to the comment, so we'd want:

comment "rsyslog needs a toolchain w/ largefile, wchar, threads"
depends on BR2_USE_MMU
depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_LARGEFILE || !BR2_USE_WCHAR

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#5 lore raw

PATCH 2/2 package/rsyslog: needs MMU (fork)

"Yann E. MORIN" <[email protected]> wrote in news:20140514191104.GB3495 at free.fr:

Quoted 2 lines

So, indeed, we do not add 'MMU' in the comment, but still the depndency should be propagated to the comment, so we'd want:

Hi,

thanks for the hint, patch updated: http://patchwork.ozlabs.org/patch/348947/

Regards, Bernd