Skip to contentSkip to conversation

ARM: shmobile: Use shmobile_init_late() on r8a7740

PATCH In review Magnus Damm 3 participants 11 messages May 11, 2014 – Jul 31, 2014

Subsystems (4)
Arm (32-bit) Arm sub-architectures SuperH Arm/RISC-V/Renesas architecture
lore
Share & tools
lore

Magnus Damm

author maintainer
#0 lore raw

PATCH 1/1 ARM: shmobile: Use shmobile_init_late() on r8a7740

From: Magnus Damm <[email protected]>

Hook up ->init_late for r8a7740 to initialize Suspend-to-RAM and CPUIdle in case of C-code less board support for r8a7740.

Signed-off-by Magnus Damm <[email protected]>

---

Applies on top of renesas-devel-v3.15-rc5-20140511

 arch/arm/mach-shmobile/setup-r8a7740.c |    1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-shmobile/setup-r8a7740.c +1 -0
@@ -927,6 +927,7 @@ DT_MACHINE_START(R8A7740_DT, "Generic R8
 	.init_early	= shmobile_init_delay,
 	.init_irq	= r8a7740_init_irq_of,
 	.init_machine	= r8a7740_generic_init,
+	.init_late	= shmobile_init_late,
 	.dt_compat	= r8a7740_boards_compat_dt,
 MACHINE_END
#1 lore raw

PATCH 1/1 ARM: shmobile: Use shmobile_init_late() on r8a7740

Quoted 6 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Hook up ->init_late for r8a7740 to initialize Suspend-to-RAM and CPUIdle in case of C-code less board support for r8a7740.

Signed-off-by Magnus Damm <[email protected]>
Acked-by Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#3 lore raw

PATCH 1/1 ARM: shmobile: Use shmobile_init_late() on r8a7740

Quoted 4 lines · Simon Horman
Quoted 3 lines · Geert Uytterhoeven
Quoted 2 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

Hook up ->init_late for r8a7740 to initialize Suspend-to-RAM and CPUIdle in case of C-code less board support for r8a7740.

Signed-off-by Magnus Damm <[email protected]>
Acked-by Geert Uytterhoeven <[email protected]>

Thanks, I will queue this up.

Hi Magnus, Hi Geert,

As I am currently doing some work for the r8a7779
I am wondering if a change like this one is appropriate for that SoC. If so I'll cook one up.

author maintainer
#4 lore raw

PATCH 1/1 ARM: shmobile: Use shmobile_init_late() on r8a7740

Hi Simon,

Quoted 12 lines · Simon Horman
Quoted 11 lines · Simon Horman
Quoted 9 lines · Geert Uytterhoeven
Quoted 6 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Hook up ->init_late for r8a7740 to initialize Suspend-to-RAM and CPUIdle in case of C-code less board support for r8a7740.

Signed-off-by Magnus Damm <[email protected]>
Acked-by Geert Uytterhoeven <[email protected]>
Quoted 7 lines
Quoted 1 line

Thanks, I will queue this up.

Hi Magnus, Hi Geert,

As I am currently doing some work for the r8a7779
I am wondering if a change like this one is appropriate for that SoC. If so I'll cook one up.

Yes, we want all SoCs to be converted over. Please take care that some DTS change may be needed to specify maximum frequency, so this may require a DTB update for the user. Which makes it less nice user experience for legacy code - if we care about that at this point. But legacy code also often tends to use early devices and other stuff, so this probably affects DT SoC code and DT reference board code mostly.

Cheers,

/ magnus

#5 lore raw

PATCH 1/1 ARM: shmobile: Use shmobile_init_late() on r8a7740

Quoted 23 lines · Magnus Damm

Hi Simon,

Quoted 12 lines · Simon Horman
Quoted 11 lines · Simon Horman
Quoted 9 lines · Geert Uytterhoeven
Quoted 6 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Hook up ->init_late for r8a7740 to initialize Suspend-to-RAM and CPUIdle in case of C-code less board support for r8a7740.

Signed-off-by Magnus Damm <[email protected]>
Acked-by Geert Uytterhoeven <[email protected]>
Quoted 7 lines
Quoted 1 line

Thanks, I will queue this up.

Hi Magnus, Hi Geert,

As I am currently doing some work for the r8a7779
I am wondering if a change like this one is appropriate for that SoC. If so I'll cook one up.

Quoted 6 lines

Yes, we want all SoCs to be converted over. Please take care that some DTS change may be needed to specify maximum frequency, so this may require a DTB update for the user. Which makes it less nice user experience for legacy code - if we care about that at this point. But legacy code also often tends to use early devices and other stuff, so this probably affects DT SoC code and DT reference board code mostly.

Does CPU frequency affect this patch (shmobile_init_late) as well as the ones to use shmobile_init_delay?

author maintainer
#6 lore raw

PATCH 1/1 ARM: shmobile: Use shmobile_init_late() on r8a7740

Hi Simon,

Quoted 31 lines · Simon Horman
Quoted 23 lines · Magnus Damm

Hi Simon,

Quoted 12 lines · Simon Horman
Quoted 11 lines · Simon Horman
Quoted 9 lines · Geert Uytterhoeven
Quoted 6 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Hook up ->init_late for r8a7740 to initialize Suspend-to-RAM and CPUIdle in case of C-code less board support for r8a7740.

Signed-off-by Magnus Damm <[email protected]>
Acked-by Geert Uytterhoeven <[email protected]>
Quoted 7 lines
Quoted 1 line

Thanks, I will queue this up.

Hi Magnus, Hi Geert,

As I am currently doing some work for the r8a7779
I am wondering if a change like this one is appropriate for that SoC. If so I'll cook one up.

Quoted 6 lines

Yes, we want all SoCs to be converted over. Please take care that some DTS change may be needed to specify maximum frequency, so this may require a DTB update for the user. Which makes it less nice user experience for legacy code - if we care about that at this point. But legacy code also often tends to use early devices and other stuff, so this probably affects DT SoC code and DT reference board code mostly.

Quoted 2 lines

Does CPU frequency affect this patch (shmobile_init_late) as well as the ones to use shmobile_init_delay?

Oops, wrong patch from my side. =) Please ignore my comment.

But we still want the SoCs to be converted over.

/ magnus

#7 lore raw

PATCH 1/1 ARM: shmobile: Use shmobile_init_late() on r8a7740

Quoted 34 lines · Magnus Damm

Hi Simon,

Quoted 31 lines · Simon Horman
Quoted 29 lines · Magnus Damm

Hi Simon,

Quoted 12 lines · Simon Horman
Quoted 11 lines · Simon Horman
Quoted 9 lines · Geert Uytterhoeven
Quoted 6 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Hook up ->init_late for r8a7740 to initialize Suspend-to-RAM and CPUIdle in case of C-code less board support for r8a7740.

Signed-off-by Magnus Damm <[email protected]>
Acked-by Geert Uytterhoeven <[email protected]>
Quoted 7 lines
Quoted 1 line

Thanks, I will queue this up.

Hi Magnus, Hi Geert,

As I am currently doing some work for the r8a7779
I am wondering if a change like this one is appropriate for that SoC. If so I'll cook one up.

Yes, we want all SoCs to be converted over. Please take care that some DTS change may be needed to specify maximum frequency, so this may require a DTB update for the user. Which makes it less nice user experience for legacy code - if we care about that at this point. But legacy code also often tends to use early devices and other stuff, so this probably affects DT SoC code and DT reference board code mostly.

Quoted 6 lines
Quoted 2 lines

Does CPU frequency affect this patch (shmobile_init_late) as well as the ones to use shmobile_init_delay?

Oops, wrong patch from my side. =) Please ignore my comment.

But we still want the SoCs to be converted over.

Thanks. I'll start with a patch for the r8a7779.

author maintainer
#8 lore raw

PATCH 1/1 ARM: shmobile: Use shmobile_init_late() on r8a7791 DT-only

In reply to Magnus Damm

From: Magnus Damm <[email protected]>

Tie in shmobile_init_late for the DT-only r8a7791 SoC Multiplatform support code. This will make sure that Suspend-to-RAM, CPUIdle and CPUFreq get initialized.

Signed-off-by Magnus Damm <[email protected]>

---

 arch/arm/mach-shmobile/setup-r8a7791.c |    1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-shmobile/setup-r8a7791.c +1 -0
@@ -217,6 +217,7 @@ DT_MACHINE_START(R8A7791_DT, "Generic R8
 	.smp		= smp_ops(r8a7791_smp_ops),
 	.init_early	= shmobile_init_delay,
 	.init_time	= rcar_gen2_timer_init,
+	.init_late	= shmobile_init_late,
 	.dt_compat	= r8a7791_boards_compat_dt,
 MACHINE_END
 #endif /* CONFIG_USE_OF */
author maintainer
#9 lore raw

PATCH 1/1 ARM: shmobile: Use shmobile_init_delay() on APE6EVM

In reply to Magnus Damm

From: Magnus Damm <[email protected]>

The r8a73a4 DTS includes CPU Frequency information so adjust the APE6EVM board code to use shmobile_init_delay() instead of relying on CPU Frequency information included in r8a73a4_init_delay() that is specified in C.

Signed-off-by Magnus Damm <[email protected]>

---

Written on top of renesas-devel-v3.16-rc7-20140729 and [PATCH 00/09] ARM: shmobile: Consistent use of shmobile_init_late()

 arch/arm/mach-shmobile/board-ape6evm-reference.c |    2 +-
 arch/arm/mach-shmobile/board-ape6evm.c           |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-shmobile/board-ape6evm-reference.c +1 -1
@@ -59,7 +59,7 @@ static const char *ape6evm_boards_compat
 };
 
 DT_MACHINE_START(APE6EVM_DT, "ape6evm")
-	.init_early	= r8a73a4_init_early,
+	.init_early	= shmobile_init_delay,
 	.init_machine	= ape6evm_add_standard_devices,
 	.init_late	= shmobile_init_late,
 	.dt_compat	= ape6evm_boards_compat_dt,
arch/arm/mach-shmobile/board-ape6evm.c +1 -1
@@ -283,7 +283,7 @@ static const char *ape6evm_boards_compat
 };
 
 DT_MACHINE_START(APE6EVM_DT, "ape6evm")
-	.init_early	= r8a73a4_init_early,
+	.init_early	= shmobile_init_delay,
 	.init_machine	= ape6evm_add_standard_devices,
 	.init_late	= shmobile_init_late,
 	.dt_compat	= ape6evm_boards_compat_dt,
#10 lore raw

Re: [PATCH] ARM: shmobile: Use shmobile_init_delay() on APE6EVM

In reply to Magnus Damm
Quoted 7 lines · Magnus Damm

From: Magnus Damm <[email protected]>

The r8a73a4 DTS includes CPU Frequency information so adjust the APE6EVM board code to use shmobile_init_delay() instead of relying on CPU Frequency information included in r8a73a4_init_delay() that is specified in C.

Quoted 5 lines
Signed-off-by Magnus Damm <[email protected]>

---

Written on top of renesas-devel-v3.16-rc7-20140729 and [PATCH 00/09] ARM: shmobile: Consistent use of shmobile_init_late()

Hi Magnus,

As per my comment on "[PATCH 00/09] ARM: shmobile: Consistent use of shmobile_init_late()".

These patches seem fine for me but I wonder if you could follow the convention that has emerged as being dominant for subjects

* Using lowercase for SOC names
* Omitting hyphens from boards names (i.e. bockw)
* Putting the board or soc after "shmobile: " and followed by a ':'.

I have taken the liberty of updating the patch name to the following and queued up the result:

ARM: shmobile: ape6evm: Use shmobile_init_delay()