ieee802154: Introduce the use of the managed version of kzalloc
Subsystems (3)
PATCH 1/1 ieee802154: Introduce the use of the managed version of kzalloc
This patch moves data allocated using kzalloc to managed data allocated using devm_kzalloc and cleans now unnecessary kfrees in probe and remove functions.
The following Coccinelle semantic patch was used for making the change:
@platform@
identifier p, probefn, removefn;
@@
struct platform_driver p = {
.probe = probefn,
.remove = removefn,
};
@prb@
identifier platform.probefn, pdev;
expression e, e1, e2;
@@probefn(struct platform_device *pdev, ...) {
<+...
- e = kzalloc(e1, e2)
+ e = devm_kzalloc(&pdev->dev, e1, e2)
...
?-kfree(e);
...+>
}
@rem depends on prb@
identifier platform.removefn;
expression e;
@@
removefn(...) {
<...
- kfree(e);
...>
}
--- drivers/net/ieee802154/fakelb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/net/ieee802154/fakelb.c +2 -3
@@ -228,7 +228,8 @@ static int fakelb_probe(struct platform_device *pdev)int err = -ENOMEM ;int i; - priv =kzalloc (sizeof (struct fakelb_priv ),GFP_KERNEL ); + priv =devm_kzalloc (&pdev->dev,sizeof (struct fakelb_priv ), +GFP_KERNEL );if (!priv) goto err_alloc;
@@ -248,7 +249,6 @@ static int fakelb_probe(struct platform_device *pdev) err_slave:list_for_each_entry (dp, &priv->list, list)fakelb_del (dp); -kfree (priv); err_alloc:return err; }
@@ -260,7 +260,6 @@ static int fakelb_remove(struct platform_device *pdev)list_for_each_entry_safe (dp, temp, &priv->list, list)fakelb_del (dp); -kfree (priv);return 0 ; }
Signature · 1 line
1.9.1
David Miller
maintainerFrom: Himangi Saraogi <[email protected]>
Date: Fri, 16 May 2014 23:39:35 +0530
Quoted 3 lines
This patch moves data allocated using kzalloc to managed data allocated using
devm_kzallocand cleans now unnecessary kfrees in probe and remove functions.
Likewise please add an explicit linux/device.h include to make sure the devm_*() routine declarations are unambiguously available.