Skip to contentSkip to conversation

package/avahi: does not build with static-only

PATCH New Yann E. MORIN 3 participants 7 messages May 16, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/avahi: does not build with static-only

From: "Yann E. MORIN" <[email protected]>

---
 package/avahi/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/avahi/Config.in +1 -0
index fd4d229..483d976 100644
@@ -3,6 +3,7 @@ config BR2_PACKAGE_AVAHI
 	# libdaemon uses fork()
 	depends on BR2_USE_MMU
 	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_PREFER_STATIC_LIB
 	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
 	help
 	  Avahi is a system which facilitates service
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 package/avahi: does not build with static-only

Dear Yann E. MORIN,

Quoted 6 lines · Yann E. MORIN

From: "Yann E. MORIN" <[email protected]>

---
 package/avahi/Config.in | 1 +
 1 file changed, 1 insertion(+)

Autobuilder reference?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 package/avahi: does not build with static-only

Thomas, All,

On 2014-05-16 20:16 +0200, Thomas Petazzoni spake thusly:

Quoted 11 lines

Dear Yann E. MORIN,

Quoted 6 lines · Yann E. MORIN

From: "Yann E. MORIN" <[email protected]>

---
 package/avahi/Config.in | 1 +
 1 file changed, 1 insertion(+)

Autobuilder reference?

Gah, I forgot to add it...

Fixes (which I reproduced here):

    http://autobuild.buildroot.net/results/ea2/ea2c8f20c4032bf82876805ea787a55834091cec

Should fix (which I did not even try to reproduce):

    http://autobuild.buildroot.net/results/4ef/4ef5bfc17f50bddb00f7ef3d62fc1fe963b7da82
    http://autobuild.buildroot.net/results/76e/76e4854812b0ef3862c080eead4012b35ef27f0f
    http://autobuild.buildroot.net/results/5bf/5bfb3fd9fe61bef5f998dc5999ce2060c334662c
    http://autobuild.buildroot.net/results/dc6/dc607c35471ef6dda04e06ad05ae7794615af578
    [...]

I'll respin it later with those references added...

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 1/1 package/avahi: does not build with static-only

Quoted 9 lines
Quoted 3 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Autobuilder reference?

Gah, I forgot to add it...

Fixes (which I reproduced here):

    http://autobuild.buildroot.net/results/ea2/ea2c8f20c4032bf82876805ea787a55834091cec
Quoted 8 lines

Should fix (which I did not even try to reproduce):

    http://autobuild.buildroot.net/results/4ef/4ef5bfc17f50bddb00f7ef3d62fc1fe963b7da82
    http://autobuild.buildroot.net/results/76e/76e4854812b0ef3862c080eead4012b35ef27f0f
    http://autobuild.buildroot.net/results/5bf/5bfb3fd9fe61bef5f998dc5999ce2060c334662c
    http://autobuild.buildroot.net/results/dc6/dc607c35471ef6dda04e06ad05ae7794615af578
    [...]

I'll respin it later with those references added...

Thanks. Please also adjust the reverse dependencies (xbmc). Does this dependency apply to all of avahi, or just the daemon?

Signature · 1 line
Bye, Peter Korsgaard
#4 lore raw

PATCH 1/1 package/avahi: does not build with static-only

In reply to Yann E. MORIN

Dear Yann E. MORIN,

Quoted 13 lines · Yann E. MORIN

Thomas, All,

On 2014-05-16 20:16 +0200, Thomas Petazzoni spake thusly:

Quoted 10 lines

Dear Yann E. MORIN,

Quoted 6 lines · Yann E. MORIN

From: "Yann E. MORIN" <[email protected]>

---
 package/avahi/Config.in | 1 +
 1 file changed, 1 insertion(+)
Quoted 6 lines
Quoted 1 line

Autobuilder reference?

Gah, I forgot to add it...

Fixes (which I reproduced here):

    http://autobuild.buildroot.net/results/ea2/ea2c8f20c4032bf82876805ea787a55834091cec

To me, it doesn't really seem like an impossibility of building Avahi with static libraries. Shouldn't we look a little bit harder at fixing the configure problem?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#5 lore raw

PATCH 1/1 package/avahi: does not build with static-only

Thomas, All,

On 2014-05-16 22:42 +0200, Thomas Petazzoni spake thusly:

Quoted 16 lines · Yann E. MORIN
Quoted 15 lines

Thomas, All,

On 2014-05-16 20:16 +0200, Thomas Petazzoni spake thusly:

Quoted 11 lines

Dear Yann E. MORIN,

Quoted 6 lines · Yann E. MORIN

From: "Yann E. MORIN" <[email protected]>

---
 package/avahi/Config.in | 1 +
 1 file changed, 1 insertion(+)

Autobuilder reference?

Quoted 8 lines
Quoted 4 lines

Gah, I forgot to add it...

Fixes (which I reproduced here):

    http://autobuild.buildroot.net/results/ea2/ea2c8f20c4032bf82876805ea787a55834091cec

To me, it doesn't really seem like an impossibility of building Avahi with static libraries. Shouldn't we look a little bit harder at fixing the configure problem?

The ./configure of avahi explicitly checks that it can link dynamically with pthreads.

I'm not sure why they decided to do that, but since that's what the configure does, and does it on purpose, I haven't even tried to see if it was really needed. But if upstream decided (for whatever reasons) that they want to explicitly check for that, I don't think we should try to revert this check.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#6 lore raw

PATCH 1/1 package/avahi: does not build with static-only

Dear Yann E. MORIN,

Quoted 4 lines · Yann E. MORIN
Quoted 3 lines

To me, it doesn't really seem like an impossibility of building Avahi with static libraries. Shouldn't we look a little bit harder at fixing the configure problem?

Quoted 8 lines

The ./configure of avahi explicitly checks that it can link dynamically with pthreads.

I'm not sure why they decided to do that, but since that's what the configure does, and does it on purpose, I haven't even tried to see if it was really needed. But if upstream decided (for whatever reasons) that they want to explicitly check for that, I don't think we should try to revert this check.

Ok, fair enough :)

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com