Skip to contentSkip to conversation

b43: make B43_PCMCIA and B43_SDIO depend on B43_SSB

PATCH New Rafał Miłecki 2 participants 2 messages May 18, 2014 Networking drivers (wireless)

lore
Share & tools
lore

Rafał Miłecki

author
#0 lore raw

PATCH 1/1 b43: make B43_PCMCIA and B43_SDIO depend on B43_SSB

These are extra configs specific to the SSB. Lack of this dependency and CONFIG_B43=y
CONFIG_B43_BUSES_BCMA=y
CONFIG_SSB=m
would result in:

Quoted 4 lines

drivers/built-in.o: In function `b43_sdio_remove':
sdio.c:(.text+0x14657f): undefined reference to ssb_bus_unregister' drivers/built-in.o: In function b43_sdio_probe':
sdio.c:(.text+0x14672f): undefined reference to `ssb_bus_sdiobus_register'

Reported-by Fengguang Wu <[email protected]>
Signed-off-by Rafa? Mi?ecki <[email protected]>
---
 drivers/net/wireless/b43/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/b43/Kconfig +2 -2
index 1c7d27b..e3f67b8 100644
@@ -73,7 +73,7 @@ config B43_PCICORE_AUTOSELECT
 
 config B43_PCMCIA
 	bool "Broadcom 43xx PCMCIA device support"
-	depends on B43 && SSB_PCMCIAHOST_POSSIBLE
+	depends on B43 && B43_SSB && SSB_PCMCIAHOST_POSSIBLE
 	select SSB_PCMCIAHOST
 	---help---
 	  Broadcom 43xx PCMCIA device support.

@@ -93,7 +93,7 @@ config B43_PCMCIA
 
 config B43_SDIO
 	bool "Broadcom 43xx SDIO device support"
-	depends on B43 && SSB_SDIOHOST_POSSIBLE
+	depends on B43 && B43_SSB && SSB_SDIOHOST_POSSIBLE
 	select SSB_SDIOHOST
 	---help---
 	  Broadcom 43xx device support for Soft-MAC SDIO devices.
Signature · 1 line
1.8.4.5
#1 lore raw

PATCH 1/1 b43: make B43_PCMCIA and B43_SDIO depend on B43_SSB

Quoted 8 lines · On Sun, 18 May 2014 13:41:33 +0200 Rafa? Mi?ecki <[email protected]> wrote:

config B43_PCMCIA

drivers/net/wireless/b43/Kconfig +1 -1
 	bool "Broadcom 43xx PCMCIA device support"
-	depends on B43 && SSB_PCMCIAHOST_POSSIBLE
+	depends on B43 && B43_SSB && SSB_PCMCIAHOST_POSSIBLE
 	select SSB_PCMCIAHOST
 	---help---
 	  Broadcom 43xx PCMCIA device support.

drivers/net/wireless/b43/Kconfig config B43_PCMCIA · line 99

Quoted 8 lines
drivers/net/wireless/b43/Kconfig +1 -1
@@ -93,7 +93,7 @@ config B43_PCMCIA
 
 config B43_SDIO
 	bool "Broadcom 43xx SDIO device support"
-	depends on B43 && SSB_SDIOHOST_POSSIBLE
+	depends on B43 && B43_SSB && SSB_SDIOHOST_POSSIBLE
 	select SSB_SDIOHOST
 	---help---
 	  Broadcom 43xx device support for Soft-MAC SDIO devices.

This makes sense.
Ack by me.

Signature · 13 lines
Michael.

----
Please use PGP/GPG encryption.
Key-ID: F532BE1D908D8B0E
--------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/b43-dev/attachments/20140518/20367c12/attachment.sig>