Skip to contentSkip to conversation

ip_tunnel: Initialize the fallback device properly

PATCH In review Steffen Klassert 2 participants 2 messages May 19, 2014 – May 21, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ip_tunnel: Initialize the fallback device properly

We need to initialize the fallback device to have a correct mtu set on this device. Otherwise the mtu is set to null and the device is unusable.

Fixes fd58156e456d ("IPIP: Use ip-tunneling code.")
Cc Pravin B Shelar <[email protected]>

---

v2: Add a reference to the commit that added the bug.
No code changes since v1.

 net/ipv4/ip_tunnel.c |    1 +
 1 file changed, 1 insertion(+)
net/ipv4/ip_tunnel.c +1 -0
index 49721d7..2acc233 100644
@@ -883,6 +883,7 @@ int ip_tunnel_init_net(struct net *net, int ip_tnl_net_id,
 	 */
 	if (!IS_ERR(itn->fb_tunnel_dev)) {
 		itn->fb_tunnel_dev->features |= NETIF_F_NETNS_LOCAL;
+		itn->fb_tunnel_dev->mtu = ip_tunnel_bind_dev(itn->fb_tunnel_dev);
 		ip_tunnel_add(itn, netdev_priv(itn->fb_tunnel_dev));
 	}
 	rtnl_unlock();
Signature · 1 line
1.7.9.5
maintainer
#1 lore raw

From: Steffen Klassert <[email protected]>
Date: Mon, 19 May 2014 11:36:56 +0200

Quoted 11 lines

We need to initialize the fallback device to have a correct mtu set on this device. Otherwise the mtu is set to null and the device is unusable.

Fixes fd58156e456d ("IPIP: Use ip-tunneling code.")
Cc Pravin B Shelar <[email protected]>

---

v2: Add a reference to the commit that added the bug.
No code changes since v1.

Applied and queued up for -stable, thanks.