arm/omap4: add twd clock to DT

PATCH New Gilles Chanteperdrix 4 participants 11 messages Apr 7, 2014 – May 23, 2014 Device tree bindings

lore

Share & tools

lore

Gilles Chanteperdrix

author

2014-04-07 20:05 UTC #0 lore raw

PATCH 1/1 arm/omap4: add twd clock to DT

Booting Linux 3.14 on Pandaboard currently gets the following message displayed:

smp_twd: clock not found -2

Define "mpu_periphclk" as the twd clock in omap4 dts to avoid this.

Signed-off-by Gilles Chanteperdrix <[email protected]>

---
 arch/arm/boot/dts/omap4.dtsi |    1 +
 1 file changed, 1 insertion(+)

arch/arm/boot/dts/omap4.dtsi +1 -0

index d3f8a6e..a7f1d3a 100644
@@ -62,6 +62,7 @@
 
 	local-timer at 48240600 {
 		compatible = "arm,cortex-a9-twd-timer";
+		clocks = <&mpu_periphclk>;
 		reg = <0x48240600 0x20>;
 		interrupts = <GIC_PPI 13 (GIC_CPU_MASK_RAW(3) | IRQ_TYPE_LEVEL_HIGH)>;
 	};

Signature · 1 line

1.7.10.4

Tony Lindgren

2014-04-18 22:39 UTC #1 lore raw

PATCH 1/1 arm/omap4: add twd clock to DT

Quoted 6 lines · Gilles Chanteperdrix

Booting Linux 3.14 on Pandaboard currently gets the following message displayed:
smp_twd: clock not found -2
Define "mpu_periphclk" as the twd clock in omap4 dts to avoid this.

Tero, care to ack?

Tony

Quoted 20 lines

Signed-off-by Gilles Chanteperdrix <[email protected]>

---
 arch/arm/boot/dts/omap4.dtsi |    1 +
 1 file changed, 1 insertion(+)

arch/arm/boot/dts/omap4.dtsi +1 -0

index d3f8a6e..a7f1d3a 100644
@@ -62,6 +62,7 @@
 
 	local-timer at 48240600 {
 		compatible = "arm,cortex-a9-twd-timer";
+		clocks = <&mpu_periphclk>;
 		reg = <0x48240600 0x20>;
 		interrupts = <GIC_PPI 13 (GIC_CPU_MASK_RAW(3) | IRQ_TYPE_LEVEL_HIGH)>;
 	};

Signature · 1 line

1.7.10.4

Gilles Chanteperdrix

author

2014-04-20 16:22 UTC #2 lore raw

PATCH 1/1 arm/omap4: add twd clock to DT

Le 19/04/2014 00:39, Tony Lindgren a ?crit :

Quoted 9 lines · Gilles Chanteperdrix

Quoted 6 lines
Booting Linux 3.14 on Pandaboard currently gets the following message displayed:
smp_twd: clock not found -2
Define "mpu_periphclk" as the twd clock in omap4 dts to avoid this.
Tero, care to ack?

Sorry if I did not mail the right people, get_maintainer.pl gave me a long list, and I did not feel like spamming all these people for such a small patch. I do not believe Tero was in this list.

Regards.

Signature · 1 line

Gilles.

Tero Kristo

2014-04-22 12:39 UTC #3 lore raw

PATCH 1/1 arm/omap4: add twd clock to DT

Quoted 9 lines · Gilles Chanteperdrix

Le 19/04/2014 00:39, Tony Lindgren a ?crit :
Quoted 8 lines · Gilles Chanteperdrix
Quoted 6 lines
Booting Linux 3.14 on Pandaboard currently gets the following message displayed:
smp_twd: clock not found -2
Define "mpu_periphclk" as the twd clock in omap4 dts to avoid this.

Quoted 7 lines

Quoted 1 line
Tero, care to ack?
Sorry if I did not mail the right people, get_maintainer.pl gave me a long list, and I did not feel like spamming all these people for such a small patch. I do not believe Tero was in this list.
Regards.

Yea I don't think this is my expertise area, however the patch looks good to me, so if you really need it:

Acked-by Tero Kristo <[email protected]>

Joachim Eastwood

2014-05-18 12:08 UTC #4 lore raw

PATCH 1/1 arm/omap4: add twd clock to DT

Quoted 21 lines · Tero Kristo

Quoted 20 lines · Gilles Chanteperdrix
Le 19/04/2014 00:39, Tony Lindgren a ?crit :
Quoted 6 lines · Gilles Chanteperdrix
Quoted 4 lines
Booting Linux 3.14 on Pandaboard currently gets the following message displayed:
Quoted 6 lines
Quoted 3 lines
smp_twd: clock not found -2
Define "mpu_periphclk" as the twd clock in omap4 dts to avoid this.
Tero, care to ack?
Sorry if I did not mail the right people, get_maintainer.pl gave me a long list, and I did not feel like spamming all these people for such a small patch. I do not believe Tero was in this list.

Quoted 7 lines

Quoted 1 line
Regards.
Yea I don't think this is my expertise area, however the patch looks good to me, so if you really need it:
Acked-by Tero Kristo <[email protected]>

Tony, care to add this to your omap 3.16 dt branch?

I am still getting:

[ 0.000152] smp_twd: clock not found -2

So this fix from Gilles would be nice to have.

regards
Joachim Eastwood

Tony Lindgren

2014-05-19 16:13 UTC #5 lore raw

PATCH 1/1 arm/omap4: add twd clock to DT

Quoted 28 lines · Joachim Eastwood

Quoted 27 lines · Tero Kristo
Quoted 13 lines · Gilles Chanteperdrix
Le 19/04/2014 00:39, Tony Lindgren a ?crit :
Quoted 11 lines · Gilles Chanteperdrix
Quoted 7 lines
Booting Linux 3.14 on Pandaboard currently gets the following message displayed:
smp_twd: clock not found -2
Define "mpu_periphclk" as the twd clock in omap4 dts to avoid this.
Quoted 8 lines
Quoted 1 line
Tero, care to ack?
Sorry if I did not mail the right people, get_maintainer.pl gave me a long list, and I did not feel like spamming all these people for such a small patch. I do not believe Tero was in this list.
Regards.
Yea I don't think this is my expertise area, however the patch looks good to me, so if you really need it:

Quoted 8 lines

Quoted 1 line
Acked-by Tero Kristo <[email protected]>
Tony, care to add this to your omap 3.16 dt branch?
I am still getting:
[ 0.000152] smp_twd: clock not found -2
So this fix from Gilles would be nice to have.

Best that Tero picks this one up along with the other dt clock changes he's queueing.

Regards,

Tony

Joachim Eastwood

2014-05-19 16:23 UTC #6 lore raw

PATCH 1/1 arm/omap4: add twd clock to DT

Quoted 33 lines · Tony Lindgren

Quoted 32 lines · Joachim Eastwood
Quoted 21 lines · Tero Kristo
Quoted 20 lines · Gilles Chanteperdrix
Le 19/04/2014 00:39, Tony Lindgren a ?crit :
Quoted 6 lines · Gilles Chanteperdrix
Quoted 4 lines
Booting Linux 3.14 on Pandaboard currently gets the following message displayed:
Quoted 6 lines
Quoted 3 lines
smp_twd: clock not found -2
Define "mpu_periphclk" as the twd clock in omap4 dts to avoid this.
Tero, care to ack?
Sorry if I did not mail the right people, get_maintainer.pl gave me a long list, and I did not feel like spamming all these people for such a small patch. I do not believe Tero was in this list.
Quoted 7 lines
Quoted 1 line
Regards.
Yea I don't think this is my expertise area, however the patch looks good to me, so if you really need it:
Acked-by Tero Kristo <[email protected]>
Tony, care to add this to your omap 3.16 dt branch?

Quoted 7 lines

Quoted 4 lines
I am still getting:
[ 0.000152] smp_twd: clock not found -2
So this fix from Gilles would be nice to have.
Best that Tero picks this one up along with the other dt clock changes he's queueing.

I kinda assumed you would take it since you asked Tero to ack it. But either way is fine :)
Thanks.

regards
Joachim Eastwood

Tony Lindgren

2014-05-19 16:27 UTC #7 lore raw

PATCH 1/1 arm/omap4: add twd clock to DT

Quoted 37 lines · Joachim Eastwood

Quoted 36 lines · Tony Lindgren
Quoted 35 lines · Joachim Eastwood
Quoted 21 lines · Tero Kristo
Quoted 20 lines · Gilles Chanteperdrix
Le 19/04/2014 00:39, Tony Lindgren a ?crit :
Quoted 6 lines · Gilles Chanteperdrix
Quoted 4 lines
Booting Linux 3.14 on Pandaboard currently gets the following message displayed:
Quoted 6 lines
Quoted 3 lines
smp_twd: clock not found -2
Define "mpu_periphclk" as the twd clock in omap4 dts to avoid this.
Tero, care to ack?
Sorry if I did not mail the right people, get_maintainer.pl gave me a long list, and I did not feel like spamming all these people for such a small patch. I do not believe Tero was in this list.
Quoted 7 lines
Quoted 1 line
Regards.
Yea I don't think this is my expertise area, however the patch looks good to me, so if you really need it:
Acked-by Tero Kristo <[email protected]>
Tony, care to add this to your omap 3.16 dt branch?
I am still getting:
[ 0.000152] smp_twd: clock not found -2

Quoted 7 lines

Quoted 4 lines
Quoted 1 line
So this fix from Gilles would be nice to have.
Best that Tero picks this one up along with the other dt clock changes he's queueing.
I kinda assumed you would take it since you asked Tero to ack it. But either way is fine :)

Yes that was before Tero started collecting the dt clock patches :)

Regards,

Tony

Tero Kristo

2014-05-20 09:01 UTC #8 lore raw

PATCH 1/1 arm/omap4: add twd clock to DT

Quoted 40 lines · Tony Lindgren

Quoted 39 lines · Joachim Eastwood
Quoted 38 lines · Tony Lindgren
Quoted 36 lines · Joachim Eastwood
Quoted 21 lines · Tero Kristo
Quoted 20 lines · Gilles Chanteperdrix
Quoted 6 lines · Tony Lindgren
Quoted 4 lines · Gilles Chanteperdrix
Booting Linux 3.14 on Pandaboard currently gets the following message displayed:
Quoted 6 lines
Quoted 3 lines
smp_twd: clock not found -2
Define "mpu_periphclk" as the twd clock in omap4 dts to avoid this.
Tero, care to ack?
Sorry if I did not mail the right people, get_maintainer.pl gave me a long list, and I did not feel like spamming all these people for such a small patch. I do not believe Tero was in this list.
Quoted 7 lines
Quoted 1 line
Regards.
Yea I don't think this is my expertise area, however the patch looks good to me, so if you really need it:
Acked-by Tero Kristo <[email protected]>
Tony, care to add this to your omap 3.16 dt branch?
I am still getting:
[ 0.000152] smp_twd: clock not found -2
So this fix from Gilles would be nice to have.

Quoted 7 lines

Quoted 5 lines
Quoted 2 lines
Best that Tero picks this one up along with the other dt clock changes he's queueing.
I kinda assumed you would take it since you asked Tero to ack it. But either way is fine :)
Yes that was before Tero started collecting the dt clock patches :)

I wouldn't say this to be a clock patch as such, this touches the driver behavior, i.e. registers the correct clock for the driver. That being said, I can still queue this up with the clock patches if that is what you want.

-Tero

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Tony Lindgren

2014-05-20 14:49 UTC #9 lore raw

PATCH 1/1 arm/omap4: add twd clock to DT

Quoted 44 lines · Tero Kristo

Quoted 43 lines · Tony Lindgren
Quoted 42 lines · Joachim Eastwood
Quoted 40 lines · Tony Lindgren
Quoted 28 lines · Joachim Eastwood
Quoted 27 lines · Tero Kristo
Quoted 13 lines · Gilles Chanteperdrix
Le 19/04/2014 00:39, Tony Lindgren a ?crit :
Quoted 11 lines · Gilles Chanteperdrix
Quoted 7 lines
Booting Linux 3.14 on Pandaboard currently gets the following message displayed:
smp_twd: clock not found -2
Define "mpu_periphclk" as the twd clock in omap4 dts to avoid this.
Quoted 8 lines
Quoted 1 line
Tero, care to ack?
Sorry if I did not mail the right people, get_maintainer.pl gave me a long list, and I did not feel like spamming all these people for such a small patch. I do not believe Tero was in this list.
Regards.
Yea I don't think this is my expertise area, however the patch looks good to me, so if you really need it:
Quoted 8 lines
Quoted 1 line
Acked-by Tero Kristo <[email protected]>
Tony, care to add this to your omap 3.16 dt branch?
I am still getting:
[ 0.000152] smp_twd: clock not found -2
So this fix from Gilles would be nice to have.
Best that Tero picks this one up along with the other dt clock changes he's queueing.

Quoted 8 lines

Quoted 4 lines
Quoted 2 lines
I kinda assumed you would take it since you asked Tero to ack it. But either way is fine :)
Yes that was before Tero started collecting the dt clock patches :)
I wouldn't say this to be a clock patch as such, this touches the driver behavior, i.e. registers the correct clock for the driver. That being said, I can still queue this up with the clock patches if that is what you want.

Yes please go ahead and take this one.

Thanks,

Tony

Tero Kristo

2014-05-23 10:57 UTC #10 lore raw

PATCH 1/1 arm/omap4: add twd clock to DT

Quoted 54 lines · Tony Lindgren

Quoted 44 lines · Tero Kristo
Quoted 43 lines · Tony Lindgren
Quoted 42 lines · Joachim Eastwood
Quoted 40 lines · Tony Lindgren
Quoted 28 lines · Joachim Eastwood
Quoted 27 lines · Tero Kristo
Quoted 13 lines · Gilles Chanteperdrix
Quoted 11 lines · Tony Lindgren
Quoted 7 lines · Gilles Chanteperdrix
Booting Linux 3.14 on Pandaboard currently gets the following message displayed:
smp_twd: clock not found -2
Define "mpu_periphclk" as the twd clock in omap4 dts to avoid this.
Quoted 8 lines
Quoted 1 line
Tero, care to ack?
Sorry if I did not mail the right people, get_maintainer.pl gave me a long list, and I did not feel like spamming all these people for such a small patch. I do not believe Tero was in this list.
Regards.
Yea I don't think this is my expertise area, however the patch looks good to me, so if you really need it:
Quoted 8 lines
Quoted 1 line
Acked-by Tero Kristo <[email protected]>
Tony, care to add this to your omap 3.16 dt branch?
I am still getting:
[ 0.000152] smp_twd: clock not found -2
So this fix from Gilles would be nice to have.
Best that Tero picks this one up along with the other dt clock changes he's queueing.
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
I kinda assumed you would take it since you asked Tero to ack it. But either way is fine :)
Yes that was before Tero started collecting the dt clock patches :)
I wouldn't say this to be a clock patch as such, this touches the driver behavior, i.e. registers the correct clock for the driver. That being said, I can still queue this up with the clock patches if that is what you want.

Quoted 6 lines

Yes please go ahead and take this one.
Thanks,
Tony

Ok, thanks, queued for 3.16.

-Tero

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html