Skip to contentSkip to conversation

fio: disable on nios2 because of missing fallocate64()

PATCH New Frank Bergmann 3 participants 3 messages May 19, 2014

lore
Share & tools
lore

Frank Bergmann

author
#0 lore raw

PATCH v2 1/1 fio: disable on nios2 because of missing fallocate64()

The fallocate() function is replaced by fallocate64() while compiling with LARGE_FILE flags. Current nios2 toolchain is missing the fallocate64() function.

Signed-off-by Frank Bergmann <[email protected]>

---
Changes v1 -> v2:
- don't use an architecture-specific patch
- disable whole package for nios (suggested by Thomas Petazzoni)

Signed-off-by Frank Bergmann <[email protected]>
---
 package/fio/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/fio/Config.in +4 -0
index be99f25..5a20b85 100644
@@ -12,6 +12,9 @@ config BR2_PACKAGE_FIO
 	depends on !BR2_TOOLCHAIN_EXTERNAL_UCLIBC && \
 		!BR2_UCLIBC_VERSION_0_9_31 && \
 		!BR2_UCLIBC_VERSION_0_9_32
+	# fio uses fallocate() which gets fallocate64() while compiling
+	# with *LARGE_FILE* flags but fallocate64() is not available on nios2
+	depends on !BR2_nios2
 	help
 	  fio is an I/O tool meant to be used both for benchmark
 	  and stress/hardware verification.

@@ -20,3 +23,4 @@ config BR2_PACKAGE_FIO
 
 comment "fio needs a toolchain w/ largefile, threads"
 	depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_nios2
Signature · 1 line
1.9.1
#1 lore raw

PATCH v2 1/1 fio: disable on nios2 because of missing fallocate64()

Frank, All,

On 2014-05-19 21:23 +0200, Frank Bergmann spake thusly:

Quoted 3 lines

The fallocate() function is replaced by fallocate64() while compiling with LARGE_FILE flags. Current nios2 toolchain is missing the fallocate64() function.

It would have been nice to have autobuilders referneces:

Fixes:

    http://autobuild.buildroot.net/results/9cd/9cd30031a40f768f6090cfba44c880fb2406672b
    http://autobuild.buildroot.net/results/7da/7da32ca8178aa6bada06dfaea38e9e693fba0db2
    http://autobuild.buildroot.net/results/0ef/0ef7358289bff2a5f9efda27115eddb379c1a0b9
    [...]
Quoted 1 line
Signed-off-by Frank Bergmann <[email protected]>

With the aforementioned autobuilders references:

Acked-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 36 lines

---
Changes v1 -> v2:
- don't use an architecture-specific patch
- disable whole package for nios (suggested by Thomas Petazzoni)

Signed-off-by Frank Bergmann <[email protected]>
---
 package/fio/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/fio/Config.in +4 -0
index be99f25..5a20b85 100644
@@ -12,6 +12,9 @@ config BR2_PACKAGE_FIO
 	depends on !BR2_TOOLCHAIN_EXTERNAL_UCLIBC && \
 		!BR2_UCLIBC_VERSION_0_9_31 && \
 		!BR2_UCLIBC_VERSION_0_9_32
+	# fio uses fallocate() which gets fallocate64() while compiling
+	# with *LARGE_FILE* flags but fallocate64() is not available on nios2
+	depends on !BR2_nios2
 	help
 	  fio is an I/O tool meant to be used both for benchmark
 	  and stress/hardware verification.

@@ -20,3 +23,4 @@ config BR2_PACKAGE_FIO
 
 comment "fio needs a toolchain w/ largefile, threads"
 	depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_nios2
Signature · 6 lines
1.9.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH v2 1/1 fio: disable on nios2 because of missing fallocate64()

In reply to Frank Bergmann
Quoted 22 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Frank" == Frank Bergmann <[email protected]> writes:

The fallocate() function is replaced by fallocate64() while compiling with LARGE_FILE flags. Current nios2 toolchain is missing the fallocate64() function.

Signed-off-by Frank Bergmann <[email protected]>

---
Changes v1 -> v2:
- don't use an architecture-specific patch
- disable whole package for nios (suggested by Thomas Petazzoni)

Signed-off-by Frank Bergmann <[email protected]>
---
 package/fio/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/fio/Config.in +0 -0
index be99f25..5a20b85 100644

package/fio/Config.in config BR2_PACKAGE_FIO · line 17

Quoted 6 lines
package/fio/Config.in +3 -0
@@ -12,6 +12,9 @@ config BR2_PACKAGE_FIO
 	depends on !BR2_TOOLCHAIN_EXTERNAL_UCLIBC && \
 		!BR2_UCLIBC_VERSION_0_9_31 && \
 		!BR2_UCLIBC_VERSION_0_9_32
+	# fio uses fallocate() which gets fallocate64() while compiling
+	# with *LARGE_FILE* flags but fallocate64() is not available on nios2
+	depends on !BR2_nios2

Changed *LARGE_FILE* to the Buildroot symbol (BR2_LARGEFILE), added the autobuilder references as suggested by Yann and committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard