Skip to contentSkip to conversation

ARM: shmobile: Use shmobile_init_delay() on r8a7790

PATCH New Magnus Damm 3 participants 6 messages May 19, 2014 – May 20, 2014

Subsystems (4)
lore
Share & tools
lore

Magnus Damm

author maintainer
#0 lore raw

cover ARM: shmobile: Use shmobile_init_delay() on r8a7790

ARM: shmobile: Use shmobile_init_delay() on r8a7790

[PATCH 01/03] ARM: shmobile: Use r8a7790 DT CPU Frequency in common case [PATCH 02/03] ARM: shmobile: Use r8a7790 DT CPU Frequency for Lager [PATCH 03/03] ARM: shmobile: Remove unused r8a7790_init_early()

Convert r8a7790 to rely on shmobile_init_delay() instead of using a per-SoC delay setup function. Very similar to the r8a7791 implementation.

---

Written against renesas-devel-v3.15-rc5-20140517

 arch/arm/mach-shmobile/board-lager-reference.c |    2 +-
 arch/arm/mach-shmobile/board-lager.c           |    2 +-
 arch/arm/mach-shmobile/include/mach/r8a7790.h  |    1 -
 arch/arm/mach-shmobile/setup-r8a7790.c         |    9 +--------
 4 files changed, 3 insertions(+), 11 deletions(-)
author maintainer
#1 lore raw

PATCH 1/3 ARM: shmobile: Use r8a7790 DT CPU Frequency in common case

From: Magnus Damm <[email protected]>

Convert the common C-code-less r8a7790 DT board support to use shmobile_init_delay() to be able to migrate away from per-SoC delay setup functions.

---

 arch/arm/mach-shmobile/setup-r8a7790.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-shmobile/setup-r8a7790.c +1 -1
@@ -323,7 +323,7 @@ static const char * const r8a7790_boards
 
 DT_MACHINE_START(R8A7790_DT, "Generic R8A7790 (Flattened Device Tree)")
 	.smp		= smp_ops(r8a7790_smp_ops),
-	.init_early	= r8a7790_init_early,
+	.init_early	= shmobile_init_delay,
 	.init_time	= rcar_gen2_timer_init,
 	.dt_compat	= r8a7790_boards_compat_dt,
 MACHINE_END
author maintainer
#2 lore raw

PATCH 2/3 ARM: shmobile: Use r8a7790 DT CPU Frequency for Lager

In reply to Magnus Damm

From: Magnus Damm <[email protected]>

Convert the Lager board support to use shmobile_init_delay() to be able to migrate away from per-SoC delay setup functions.

---

 arch/arm/mach-shmobile/board-lager-reference.c |    2 +-
 arch/arm/mach-shmobile/board-lager.c           |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-shmobile/board-lager-reference.c +1 -1
@@ -115,7 +115,7 @@ static const char *lager_boards_compat_d
 
 DT_MACHINE_START(LAGER_DT, "lager")
 	.smp		= smp_ops(r8a7790_smp_ops),
-	.init_early	= r8a7790_init_early,
+	.init_early	= shmobile_init_delay,
 	.init_time	= rcar_gen2_timer_init,
 	.init_machine	= lager_add_standard_devices,
 	.init_late	= shmobile_init_late,
arch/arm/mach-shmobile/board-lager.c +1 -1
@@ -886,7 +886,7 @@ static const char * const lager_boards_c
 
 DT_MACHINE_START(LAGER_DT, "lager")
 	.smp		= smp_ops(r8a7790_smp_ops),
-	.init_early	= r8a7790_init_early,
+	.init_early	= shmobile_init_delay,
 	.init_time	= rcar_gen2_timer_init,
 	.init_machine	= lager_init,
 	.init_late	= shmobile_init_late,
author maintainer
#3 lore raw

PATCH 3/3 ARM: shmobile: Remove unused r8a7790_init_early()

In reply to Magnus Damm

From: Magnus Damm <[email protected]>

Remove the now unused r8a7790_init_early() function.

---

 arch/arm/mach-shmobile/include/mach/r8a7790.h |    1 -
 arch/arm/mach-shmobile/setup-r8a7790.c        |    7 -------
 2 files changed, 8 deletions(-)
arch/arm/mach-shmobile/include/mach/r8a7790.h +0 -1
@@ -33,7 +33,6 @@ void r8a7790_add_dt_devices(void);
 void r8a7790_clock_init(void);
 void r8a7790_pinmux_init(void);
 void r8a7790_pm_init(void);
-void r8a7790_init_early(void);
 extern struct smp_operations r8a7790_smp_ops;
 
 #endif /* __ASM_R8A7790_H__ */
arch/arm/mach-shmobile/setup-r8a7790.c +0 -7
@@ -307,13 +307,6 @@ void __init r8a7790_add_standard_devices
 	r8a7790_register_audio_dmac(1);
 }
 
-void __init r8a7790_init_early(void)
-{
-#ifndef CONFIG_ARM_ARCH_TIMER
-	shmobile_setup_delay(1300, 2, 4); /* Cortex-A15 @ 1300MHz */
-#endif
-}
-
 #ifdef CONFIG_USE_OF
 
 static const char * const r8a7790_boards_compat_dt[] __initconst = {
#4 lore raw

cover ARM: shmobile: Use shmobile_init_delay() on r8a7790

In reply to Magnus Damm
Quoted 8 lines · Magnus Damm

[PATCH 01/03] ARM: shmobile: Use r8a7790 DT CPU Frequency in common case [PATCH 02/03] ARM: shmobile: Use r8a7790 DT CPU Frequency for Lager [PATCH 03/03] ARM: shmobile: Remove unused r8a7790_init_early()

Convert r8a7790 to rely on shmobile_init_delay() instead of using a per-SoC delay setup function. Very similar to the r8a7791 implementation.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#5 lore raw

cover ARM: shmobile: Use shmobile_init_delay() on r8a7790

Quoted 11 lines · Geert Uytterhoeven
Quoted 8 lines · Magnus Damm

[PATCH 01/03] ARM: shmobile: Use r8a7790 DT CPU Frequency in common case [PATCH 02/03] ARM: shmobile: Use r8a7790 DT CPU Frequency for Lager [PATCH 03/03] ARM: shmobile: Remove unused r8a7790_init_early()

Convert r8a7790 to rely on shmobile_init_delay() instead of using a per-SoC delay setup function. Very similar to the r8a7791 implementation.

Thanks I will queue these up.