Skip to contentSkip to conversation

staging: dgap: remove unneeded kfree() in dgap_tty_register_ports()

PATCH In review Daeseok Youn 1 participant 1 message May 26, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 3/4 staging: dgap: remove unneeded kfree() in dgap_tty_register_ports()

When it failed to allocate for printer_ports, serial_ports can be freed in dgap_tty_uninit().

---
 drivers/staging/dgap/dgap.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
drivers/staging/dgap/dgap.c +2 -3
index db24f70..2f47bb7 100644
@@ -4158,10 +4158,9 @@ static int dgap_tty_register_ports(struct board_t *brd)
 
 	brd->printer_ports = kcalloc(brd->nasync, sizeof(*brd->printer_ports),
 					GFP_KERNEL);
-	if (brd->printer_ports == NULL) {
-		kfree(brd->serial_ports);
+	if (brd->printer_ports == NULL)
 		return -ENOMEM;
-	}
+
 	for (i = 0; i < brd->nasync; i++)
 		tty_port_init(&brd->printer_ports[i]);
 
Signature · 1 line
1.7.1