powerpc: Introduce the use of the managed version of kzalloc
Subsystems (2)
PATCH 1/1 powerpc: Introduce the use of the managed version of kzalloc
This patch moves data allocated using kzalloc to managed data allocated using devm_kzalloc and cleans now unnecessary kfree in probe function.
The following Coccinelle semantic patch was used for making the change:
@platform@
identifier p, probefn, removefn;
@@
struct platform_driver p = {
.probe = probefn,
.remove = removefn,
};
@prb@
identifier platform.probefn, pdev;
expression e, e1, e2;
@@probefn(struct platform_device *pdev, ...) {
<+...
- e = kzalloc(e1, e2)
+ e = devm_kzalloc(&pdev->dev, e1, e2)
...
?-kfree(e);
...+>
}
---
Not compile tested
arch/powerpc/platforms/52xx/mpc52xx_gpt.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
arch/powerpc/platforms/52xx/mpc52xx_gpt.c +2 -4
@@ -724,7 +724,7 @@ static int mpc52xx_gpt_probe(struct platform_device *ofdev) {struct mpc52xx_gpt_priv *gpt; - gpt =kzalloc (sizeof *gpt,GFP_KERNEL ); + gpt =devm_kzalloc (&ofdev->dev,sizeof *gpt,GFP_KERNEL );if (!gpt)return -ENOMEM ;
@@ -732,10 +732,8 @@ static int mpc52xx_gpt_probe(struct platform_device *ofdev) gpt->dev = &ofdev->dev; gpt->ipb_freq =mpc5xxx_get_bus_frequency (ofdev->dev.of_node); gpt->regs =of_iomap (ofdev->dev.of_node,0 ); -if (!gpt->regs) { -kfree (gpt); +if (!gpt->regs)return -ENOMEM ; - }dev_set_drvdata (&ofdev->dev, gpt);
Signature · 1 line
1.9.1
On Tue, 27 May 2014 01:51:31 +0530
Himangi Saraogi <[email protected]> wrote:
...
Quoted 7 lines
Signed-off-by Himangi Saraogi <[email protected]>Acked-by Julia Lawall <[email protected]>---
Not compile testedarch/powerpc/platforms/52xx/mpc52xx_gpt.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
applied to mpc5xxx/next.
Thanks,
Anatolij