Skip to contentSkip to conversation

ARM: mvebu: Staticize local variables

PATCH Superseded Sachin Kamat 2 participants 5 messages May 27, 2014

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm/Marvell Kirkwood and Armada 370, 375, 38x, 39x, XP, 3700, 7K/8K, CN9130 SoC support
lore
Share & tools
lore

Sachin Kamat

author
#0 lore raw

PATCH 1/1 ARM: mvebu: Staticize local variables

Symbols local to this file are made static.

Signed-off-by Sachin Kamat <[email protected]>
---
 arch/arm/mach-mvebu/pmsu.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-mvebu/pmsu.c +2 -2
index 53a55c8520bf..950105871480 100644
@@ -148,7 +148,7 @@ static void armada_370_xp_cpu_resume(void)
 }
 
 /* No locking is needed because we only access per-CPU registers */
-void armada_370_xp_pmsu_idle_prepare(bool deepidle)
+static void armada_370_xp_pmsu_idle_prepare(bool deepidle)
 {
 	unsigned int hw_cpu = cpu_logical_map(smp_processor_id());
 	u32 reg;

@@ -263,7 +263,7 @@ static struct notifier_block armada_370_xp_cpu_pm_notifier = {
 	.notifier_call = armada_370_xp_cpu_pm_notify,
 };
 
-int __init armada_370_xp_cpu_pm_init(void)
+static int __init armada_370_xp_cpu_pm_init(void)
 {
 	struct device_node *np;
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 ARM: mvebu: Staticize local variables

Dear Sachin Kamat,

Quoted 12 lines · Sachin Kamat

Symbols local to this file are made static.

Signed-off-by Sachin Kamat <[email protected]>
---
 arch/arm/mach-mvebu/pmsu.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-mvebu/pmsu.c +0 -0
index 53a55c8520bf..950105871480 100644

arch/arm/mach-mvebu/pmsu.c static void armada_370_xp_cpu_resume(void) · line 151

Quoted 5 lines
arch/arm/mach-mvebu/pmsu.c +1 -1
@@ -148,7 +148,7 @@ static void armada_370_xp_cpu_resume(void)
 }
 
 /* No locking is needed because we only access per-CPU registers */
-void armada_370_xp_pmsu_idle_prepare(bool deepidle)
+static void armada_370_xp_pmsu_idle_prepare(bool deepidle)

I already submitted a patch for this one yesterday:
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-May/259849.html.

arch/arm/mach-mvebu/pmsu.c static struct notifier_block armada_370_xp_cpu_pm_notifier = { · line 266

Quoted 9 lines
arch/arm/mach-mvebu/pmsu.c +0 -0
 {
 	unsigned int hw_cpu = cpu_logical_map(smp_processor_id());
 	u32 reg;

@@ -263,7 +263,7 @@ static struct notifier_block

armada_370_xp_cpu_pm_notifier = { .notifier_call = armada_370_xp_cpu_pm_notify, };

arch/arm/mach-mvebu/pmsu.c +1 -1
-int __init armada_370_xp_cpu_pm_init(void)
+static int __init armada_370_xp_cpu_pm_init(void)

Indeed, this one needs to be fixed.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 ARM: mvebu: Staticize local variables

Hi Thomas,

Quoted 17 lines · Thomas Petazzoni

Dear Sachin Kamat,

Quoted 14 lines · Sachin Kamat

Symbols local to this file are made static.

Signed-off-by Sachin Kamat <[email protected]>
---
 arch/arm/mach-mvebu/pmsu.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-mvebu/pmsu.c +0 -0
index 53a55c8520bf..950105871480 100644
@@ -148,7 +148,7 @@ static void armada_370_xp_cpu_resume(void)
 }
Quoted 6 lines

arch/arm/mach-mvebu/pmsu.c static void armada_370_xp_cpu_resume(void) · line 151

Quoted 3 lines
arch/arm/mach-mvebu/pmsu.c +1 -1
 /* No locking is needed because we only access per-CPU registers */
-void armada_370_xp_pmsu_idle_prepare(bool deepidle)
+static void armada_370_xp_pmsu_idle_prepare(bool deepidle)

I already submitted a patch for this one yesterday:
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-May/259849.html.

I missed this. Sorry.

Quoted 8 lines
Quoted 8 lines
arch/arm/mach-mvebu/pmsu.c +0 -0
 {
      unsigned int hw_cpu = cpu_logical_map(smp_processor_id());
      u32 reg;

@@ -263,7 +263,7 @@ static struct notifier_block

armada_370_xp_cpu_pm_notifier = { .notifier_call = armada_370_xp_cpu_pm_notify, };

Quoted 4 lines

arch/arm/mach-mvebu/pmsu.c static struct notifier_block armada_370_xp_cpu_pm_notifier = { · line 266

Quoted 2 lines
arch/arm/mach-mvebu/pmsu.c +1 -1
-int __init armada_370_xp_cpu_pm_init(void)
+static int __init armada_370_xp_cpu_pm_init(void)

Indeed, this one needs to be fixed.

How do you want me to handle this?

Signature · 2 lines
With warm regards,
Sachin
#3 lore raw

PATCH 1/1 ARM: mvebu: Staticize local variables

Dear Sachin Kamat,

Quoted 6 lines · Sachin Kamat
Quoted 6 lines
Quoted 6 lines
      unsigned int hw_cpu = cpu_logical_map(smp_processor_id());
      u32 reg;
(quoted diff) +0 -0
@@ -263,7 +263,7 @@ static struct notifier_block

armada_370_xp_cpu_pm_notifier = { .notifier_call = armada_370_xp_cpu_pm_notify, };

Quoted 6 lines
Quoted 4 lines

arch/arm/mach-mvebu/pmsu.c static struct notifier_block armada_370_xp_cpu_pm_notifier = { · line 266

Quoted 2 lines
arch/arm/mach-mvebu/pmsu.c +1 -1
-int __init armada_370_xp_cpu_pm_init(void)
+static int __init armada_370_xp_cpu_pm_init(void)

Indeed, this one needs to be fixed.

How do you want me to handle this?

Maybe send a new patch that fixes just that one?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#4 lore raw

PATCH 1/1 ARM: mvebu: Staticize local variables

Quoted 10 lines · Thomas Petazzoni

Dear Sachin Kamat,

Quoted 6 lines · Sachin Kamat
Quoted 6 lines
Quoted 6 lines
      unsigned int hw_cpu = cpu_logical_map(smp_processor_id());
      u32 reg;
(quoted diff) +0 -0
@@ -263,7 +263,7 @@ static struct notifier_block

armada_370_xp_cpu_pm_notifier = { .notifier_call = armada_370_xp_cpu_pm_notify, };

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

arch/arm/mach-mvebu/pmsu.c static struct notifier_block armada_370_xp_cpu_pm_notifier = { · line 266

Quoted 2 lines
arch/arm/mach-mvebu/pmsu.c +1 -1
-int __init armada_370_xp_cpu_pm_init(void)
+static int __init armada_370_xp_cpu_pm_init(void)

Indeed, this one needs to be fixed.

How do you want me to handle this?

Maybe send a new patch that fixes just that one?

Sounds good. Thanks.

Signature · 2 lines
With warm regards,
Sachin