Skip to contentSkip to conversation

ARM: ux500: Staticize ux500_soc_attr

PATCH New Sachin Kamat 3 participants 3 messages May 28, 2014

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm/nomadik/Ux500 architectures
lore
Share & tools
lore

Sachin Kamat

author
#0 lore raw

PATCH v2 1/1 ARM: ux500: Staticize ux500_soc_attr

'ux500_soc_attr' is local to this file. While at it also make it const to match the argument list of device_create_file.

Signed-off-by Sachin Kamat <[email protected]>

---
Made ux500_soc_attr const as suggested by Lee Jones.

---
 arch/arm/mach-ux500/cpu.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-ux500/cpu.c +1 -1
index db16b5a04ad5..dbb2970ee7da 100644
@@ -125,7 +125,7 @@ static void __init soc_info_populate(struct soc_device_attribute *soc_dev_attr,
 	soc_dev_attr->revision = ux500_get_revision();
 }
 
-struct device_attribute ux500_soc_attr =
+static const struct device_attribute ux500_soc_attr =
 	__ATTR(process,  S_IRUGO, ux500_get_process,  NULL);
 
 struct device * __init ux500_soc_device_init(const char *soc_id)
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH v2 1/1 ARM: ux500: Staticize ux500_soc_attr

Quoted 9 lines

'ux500_soc_attr' is local to this file. While at it also make it const to match the argument list of device_create_file.

Signed-off-by Sachin Kamat <[email protected]>

---
Made ux500_soc_attr const as suggested by Lee Jones.

---
 arch/arm/mach-ux500/cpu.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by Lee Jones <[email protected]>
Quoted 13 lines
arch/arm/mach-ux500/cpu.c +1 -1
index db16b5a04ad5..dbb2970ee7da 100644
@@ -125,7 +125,7 @@ static void __init soc_info_populate(struct soc_device_attribute *soc_dev_attr,
 	soc_dev_attr->revision = ux500_get_revision();
 }
 
-struct device_attribute ux500_soc_attr =
+static const struct device_attribute ux500_soc_attr =
 	__ATTR(process,  S_IRUGO, ux500_get_process,  NULL);
 
 struct device * __init ux500_soc_device_init(const char *soc_id)
Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#2 lore raw

PATCH v2 1/1 ARM: ux500: Staticize ux500_soc_attr

In reply to Sachin Kamat
Quoted 6 lines · Sachin Kamat

'ux500_soc_attr' is local to this file. While at it also make it const to match the argument list of device_create_file.

Signed-off-by Sachin Kamat <[email protected]>

---
Made ux500_soc_attr const as suggested by Lee Jones.

(...)

arch/arm/mach-ux500/cpu.c static void __init soc_info_populate(struct soc_device_attribute *soc_dev_attr, · line 129

Quoted 3 lines
arch/arm/mach-ux500/cpu.c +1 -1
-struct device_attribute ux500_soc_attr =
+static const struct device_attribute ux500_soc_attr =
        __ATTR(process,  S_IRUGO, ux500_get_process,  NULL);

I alrerady have queued a patch from Thierry Reding switching this to static.
http://marc.info/?l=linux-arm-kernel&m=139642578413650&w=2

However that patch does not switch it to const.

I'll just augment Thierry's patch to do that too, this is too much fuzz to have a separate patch for constifying.

Yours,
Linus Walleij