Skip to contentSkip to conversation

package/exim: fix static linking

PATCH New Yann E. MORIN 3 participants 3 messages May 28, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/exim: fix static linking

From: "Yann E. MORIN" <[email protected]>

When building static, we need to tell exim that it needs to link statically (obviously), and that it should link against pthreads.

Yet, exim is still not happy with that, as it still wants to build something (a version-related program) at install time, so we need to replicate the ld flags at install time.

---
 package/exim/exim.mk | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
package/exim/exim.mk +9 -2
index ca9c8a7..b780b85 100644
@@ -49,15 +49,22 @@ define EXIM_CONFIGURE_CMDS
 	$(call exim-config-add,HOSTCFLAGS,$(HOSTCFLAGS))
 endef
 
+# exim needs a bit of love to build statically
+ifeq ($(BR2_PREFER_STATIC_LIB),y)
+EXIM_STATIC_FLAGS = LFLAGS="-pthread --static"
+endif
+
 # "The -j (parallel) flag must not be used with make"
 # (http://www.exim.org/exim-html-current/doc/html/spec_html/ch04.html)
 define EXIM_BUILD_CMDS
-	build=br $(MAKE1) -C $(@D)
+	build=br $(MAKE1) -C $(@D) $(EXIM_STATIC_FLAGS)
 endef
 
+# Need to replicate the LFLAGS in install, as exim still wants to build
+# something when installing...
 define EXIM_INSTALL_TARGET_CMDS
 	DESTDIR=$(TARGET_DIR) INSTALL_ARG="-no_chown -no_symlink" build=br \
-	  $(MAKE1) -C $(@D) install
+	  $(MAKE1) -C $(@D) $(EXIM_STATIC_FLAGS) install
 	chmod u+s $(TARGET_DIR)/usr/sbin/exim
 endef
 
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 package/exim: fix static linking

Dear Yann E. MORIN,

Quoted 10 lines · Yann E. MORIN

From: "Yann E. MORIN" <[email protected]>

When building static, we need to tell exim that it needs to link statically (obviously), and that it should link against pthreads.

Yet, exim is still not happy with that, as it still wants to build something (a version-related program) at install time, so we need to replicate the ld flags at install time.

Reference to autobuilder failure, maybe? :-)

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 package/exim: fix static linking

In reply to Yann E. MORIN
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

From: "Yann E. MORIN" <[email protected]>
When building static, we need to tell exim that it needs to link statically (obviously), and that it should link against pthreads.

Yet, exim is still not happy with that, as it still wants to build something (a version-related program) at install time, so we need to replicate the ld flags at install time.

Committed with the autobuilder link added, thanks.

Signature · 1 line
Bye, Peter Korsgaard