Skip to contentSkip to conversation

ASoC: rsnd: fixup SSI interrupts style of DeviceTree

PATCH In review Kuninori Morimoto 4 participants 7 messages May 30, 2014 – Jun 2, 2014

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: rsnd: fixup SSI interrupts style of DeviceTree

From: Kuninori Morimoto <[email protected]>

Current SSI interrupts has been set to each port.
But it is too ugly style.
SSI interrupts will be listed under
rcar_sound,ssi node by this patch

---

Quoted 1 line
Quoted 1 line

Mark

There is still no DT user for this driver at this point. No conflict happens on platform.

 .../devicetree/bindings/sound/renesas,rsnd.txt     |   50 ++++++++------------
 sound/soc/sh/rcar/ssi.c                            |    2 +-
 2 files changed, 21 insertions(+), 31 deletions(-)
Documentation/devicetree/bindings/sound/renesas,rsnd.txt +20 -30
index 8346cab..1fba56b 100644
@@ -53,36 +53,26 @@ rcar_sound: rcar_sound@0xffd90000 {
 	};
 
 	rcar_sound,ssi {
-		ssi0: ssi@0 {
-			interrupts = <0 370 IRQ_TYPE_LEVEL_HIGH>;
-		};
-		ssi1: ssi@1 {
-			interrupts = <0 371 IRQ_TYPE_LEVEL_HIGH>;
-		};
-		ssi2: ssi@2 {
-			interrupts = <0 372 IRQ_TYPE_LEVEL_HIGH>;
-		};
-		ssi3: ssi@3 {
-			interrupts = <0 373 IRQ_TYPE_LEVEL_HIGH>;
-		};
-		ssi4: ssi@4 {
-			interrupts = <0 374 IRQ_TYPE_LEVEL_HIGH>;
-		};
-		ssi5: ssi@5 {
-			interrupts = <0 375 IRQ_TYPE_LEVEL_HIGH>;
-		};
-		ssi6: ssi@6 {
-			interrupts = <0 376 IRQ_TYPE_LEVEL_HIGH>;
-		};
-		ssi7: ssi@7 {
-			interrupts = <0 377 IRQ_TYPE_LEVEL_HIGH>;
-		};
-		ssi8: ssi@8 {
-			interrupts = <0 378 IRQ_TYPE_LEVEL_HIGH>;
-		};
-		ssi9: ssi@9 {
-			interrupts = <0 379 IRQ_TYPE_LEVEL_HIGH>;
-		};
+		interrupts =	<0 370 IRQ_TYPE_LEVEL_HIGH>,
+				<0 371 IRQ_TYPE_LEVEL_HIGH>,
+				<0 372 IRQ_TYPE_LEVEL_HIGH>,
+				<0 373 IRQ_TYPE_LEVEL_HIGH>,
+				<0 374 IRQ_TYPE_LEVEL_HIGH>,
+				<0 375 IRQ_TYPE_LEVEL_HIGH>,
+				<0 376 IRQ_TYPE_LEVEL_HIGH>,
+				<0 377 IRQ_TYPE_LEVEL_HIGH>,
+				<0 378 IRQ_TYPE_LEVEL_HIGH>,
+				<0 379 IRQ_TYPE_LEVEL_HIGH>;
+		ssi0: ssi@0 { };
+		ssi1: ssi@1 { };
+		ssi2: ssi@2 { };
+		ssi3: ssi@3 { };
+		ssi4: ssi@4 { };
+		ssi5: ssi@5 { };
+		ssi6: ssi@6 { };
+		ssi7: ssi@7 { };
+		ssi8: ssi@8 { };
+		ssi9: ssi@9 { };
 	};
 
 	rcar_sound,dai {
sound/soc/sh/rcar/ssi.c +1 -1
index 2df723d..b311bc6 100644
@@ -588,7 +588,7 @@ static void rsnd_of_parse_ssi(struct platform_device *pdev,
 		/*
 		 * irq
 		 */
-		ssi_info->pio_irq = irq_of_parse_and_map(np, 0);
+		ssi_info->pio_irq = irq_of_parse_and_map(node, i);
 
 		/*
 		 * DMA
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 46 lines · Kuninori Morimoto

From: Kuninori Morimoto <[email protected]>

Current SSI interrupts has been set to each port.
But it is too ugly style.
SSI interrupts will be listed under
rcar_sound,ssi node by this patch

---

Quoted 1 line
Quoted 1 line

Mark

There is still no DT user for this driver at this point. No conflict happens on platform.

 .../devicetree/bindings/sound/renesas,rsnd.txt     |   50 ++++++++------------
 sound/soc/sh/rcar/ssi.c                            |    2 +-
 2 files changed, 21 insertions(+), 31 deletions(-)
Documentation/devicetree/bindings/sound/renesas,rsnd.txt +0 -20
index 8346cab..1fba56b 100644
@@ -53,36 +53,26 @@ rcar_sound: rcar_sound@0xffd90000 {
 	};
 
 	rcar_sound,ssi {
-		ssi0: ssi@0 {
-			interrupts = <0 370 IRQ_TYPE_LEVEL_HIGH>;
-		};
-		ssi1: ssi@1 {
-			interrupts = <0 371 IRQ_TYPE_LEVEL_HIGH>;
-		};
-		ssi2: ssi@2 {
-			interrupts = <0 372 IRQ_TYPE_LEVEL_HIGH>;
-		};
-		ssi3: ssi@3 {
-			interrupts = <0 373 IRQ_TYPE_LEVEL_HIGH>;
-		};
-		ssi4: ssi@4 {
-			interrupts = <0 374 IRQ_TYPE_LEVEL_HIGH>;
-		};
-		ssi5: ssi@5 {
-			interrupts = <0 375 IRQ_TYPE_LEVEL_HIGH>;
-		};
-		ssi6: ssi@6 {
-			interrupts = <0 376 IRQ_TYPE_LEVEL_HIGH>;

Documentation/devicetree/bindings/sound/renesas,rsnd.txt rcar_sound: rcar_sound@0xffd90000 { · line 85

Quoted 10 lines
Documentation/devicetree/bindings/sound/renesas,rsnd.txt +0 -10
-		};
-		ssi7: ssi@7 {
-			interrupts = <0 377 IRQ_TYPE_LEVEL_HIGH>;
-		};
-		ssi8: ssi@8 {
-			interrupts = <0 378 IRQ_TYPE_LEVEL_HIGH>;
-		};
-		ssi9: ssi@9 {
-			interrupts = <0 379 IRQ_TYPE_LEVEL_HIGH>;
-		};

This looks like a backward step, especially as we use the ssiX blocks for DMA too.

Also, please just stop playing around with this stuff, other people are trying to use this code and changing it without a good technical reason is causing difficulty.

Signature · 3 lines
Ben Dooks, [email protected], http://www.fluff.org/ben/

Large Hadron Colada: A large Pina Colada that makes the universe disappear.
#2 lore raw

Hi Ben

Thank you for your feedback

Quoted 9 lines
Quoted 9 lines

From: Kuninori Morimoto <[email protected]>

Current SSI interrupts has been set to each port.
But it is too ugly style.
SSI interrupts will be listed under
rcar_sound,ssi node by this patch

---

(snip)

Quoted 6 lines

This looks like a backward step, especially as we use the ssiX blocks for DMA too.

Also, please just stop playing around with this stuff, other people are trying to use this code and changing it without a good technical reason is causing difficulty.

Hmm...
This driver is still under developing.
And it is very difficult for me to care about out-of-tree Linux.

#3 lore raw
Quoted 17 lines · Kuninori Morimoto

Hi Ben

Thank you for your feedback

Quoted 9 lines
Quoted 9 lines

From: Kuninori Morimoto <[email protected]>

Current SSI interrupts has been set to each port.
But it is too ugly style.
SSI interrupts will be listed under
rcar_sound,ssi node by this patch

---

(snip)

Quoted 3 lines

This looks like a backward step, especially as we use the ssiX blocks for DMA too.

Quoted 7 lines
Quoted 3 lines

Also, please just stop playing around with this stuff, other people are trying to use this code and changing it without a good technical reason is causing difficulty.

Hmm...
This driver is still under developing.
And it is very difficult for me to care about out-of-tree Linux.

Ok, but we really need to keep in mind that the DT should be kept as stable as possible. We may be out of tree at the moment, but we are trying our best to keep track and feed back our work. This is not helped if we have to do these changes when re-basing.

In my view this change does not help the readability, as we now have a large block of interrupts, where before we could easily work out which interrupt was mapped to which SSI.

Signature · 3 lines
Ben Dooks, [email protected], http://www.fluff.org/ben/

Large Hadron Colada: A large Pina Colada that makes the universe disappear.
#4 lore raw

Hi Ben

Quoted 4 lines
Quoted 3 lines

Hmm...
This driver is still under developing.
And it is very difficult for me to care about out-of-tree Linux.

Quoted 8 lines

Ok, but we really need to keep in mind that the DT should be kept as stable as possible. We may be out of tree at the moment, but we are trying our best to keep track and feed back our work. This is not helped if we have to do these changes when re-basing.

In my view this change does not help the readability, as we now have a large block of interrupts, where before we could easily work out which interrupt was mapped to which SSI.

OK.
I thought that 1) current style was not good DT style
2) there is a chance to exchange it because upstream doesn't have user at this point.
Can you accept if it can keep compatibility ?

#5 lore raw
Quoted 16 lines · Kuninori Morimoto

Hi Ben

Quoted 4 lines
Quoted 3 lines

Hmm...
This driver is still under developing.
And it is very difficult for me to care about out-of-tree Linux.

Quoted 8 lines

Ok, but we really need to keep in mind that the DT should be kept as stable as possible. We may be out of tree at the moment, but we are trying our best to keep track and feed back our work. This is not helped if we have to do these changes when re-basing.

In my view this change does not help the readability, as we now have a large block of interrupts, where before we could easily work out which interrupt was mapped to which SSI.

Quoted 5 lines

OK.
I thought that 1) current style was not good DT style
2) there is a chance to exchange it because upstream doesn't have user at this point.
Can you accept if it can keep compatibility ?

I think the current method is the nicer, it keeps the descriptions each ssi as close as possible to the ssi. So, in answer to #1 I think it is the best.

In answer to #2, it would be nicer not to unless you have a good reason to do this.

Signature · 2 lines
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius
#6 lore raw

Hi Ben

Quoted 11 lines
Quoted 4 lines

I thought that 1) current style was not good DT style
2) there is a chance to exchange it because upstream doesn't have user at this point.
Can you accept if it can keep compatibility ?

I think the current method is the nicer, it keeps the descriptions each ssi as close as possible to the ssi. So, in answer to #1 I think it is the best.

In answer to #2, it would be nicer not to unless you have a good reason to do this.

I re-considered about this patch. And I can agree with your opinion. I will skip this patch.
Thank you for your help