Skip to contentSkip to conversation

ti-gfx: use only -I${includedir} as pkg-config Cflags

PATCH New Peter Kümmel 2 participants 5 messages Jun 1, 2014 Arm/Allwinner sunXi SoC support

lore
Share & tools
lore

Peter Kümmel

author
#0 lore raw

PATCH 1/2 ti-gfx: use only -I${includedir} as pkg-config Cflags

Using only -I${includedir} in common practice.

Settings only -I${includedir}/GLES2 breaks Qt5's CMake files, because at configure time CMake only searchs the paths reported by pkg-config, and not even /usr/include is used as default.

Signed-off-by Peter K?mmel <[email protected]>
---
 package/ti-gfx/egl.pc    |    2 +-
 package/ti-gfx/glesv2.pc |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/ti-gfx/egl.pc +1 -1
index 223fb04..36ea413 100644
@@ -8,4 +8,4 @@ Description: TI Graphics SDK implementation of EGL
 Version: 1.9.2188537
 Requires:
 Libs: -L${libdir} -lEGL -lGLESv2 -lIMGegl
-Cflags: -I${includedir}/EGL/ -I${includedir}
+Cflags: -I${includedir}
package/ti-gfx/glesv2.pc +1 -1
index 4c70aec..b458133 100644
@@ -8,4 +8,4 @@ Description: TI Graphics SDK implementation of OpenGL ESv2
 Version: 1.9.2188537
 Requires:
 Libs: -L${libdir} -lGLESv2 -lGLES_CM -lsrv_um -lusc -lEGL -lIMGegl
-Cflags: -I${includedir}/GLES2
+Cflags: -I${includedir}
Signature · 1 line
1.7.10.4
author
#1 lore raw

PATCH 2/2 sunxi-mali: use only -I${includedir} as pkg-config Cflags

Using only -I${includedir} in common practice.

Settings only -I${includedir}/GLES2 breaks Qt5's CMake files, because at configure time CMake only searchs the paths reported by pkg-config, and not even /usr/include is used as default.

Signed-off-by Peter K?mmel <[email protected]>
---
 package/sunxi-mali/egl.pc    |    2 +-
 package/sunxi-mali/glesv2.pc |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/sunxi-mali/egl.pc +1 -1
index b062ad1..2823209 100644
@@ -8,5 +8,5 @@ Description: ARM Mali implementation of EGL
 Version: 1.4
 Requires:
 Libs: -L${libdir} -lEGL -lGLESv2 -lUMP
-Cflags: -I${includedir}/EGL/ -I${includedir}
+Cflags: -I${includedir}
package/sunxi-mali/glesv2.pc +1 -1
index 9273678..4702d13 100644
@@ -8,5 +8,5 @@ Description: ARM Mali implementation of OpenGL ESv2
 Version: 2.0
 Requires:
 Libs: -L${libdir} -lGLESv2 -lGLESv1_CM -lUMP
-Cflags: -I${includedir}/GLES2
+Cflags: -I${includedir}
Signature · 1 line
1.7.10.4
#2 lore raw

PATCH 2/2 sunxi-mali: use only -I${includedir} as pkg-config Cflags

Peter, All,

On 2014-06-01 11:50 +0200, Peter K?mmel spake thusly:

Quoted 5 lines

Using only -I${includedir} in common practice.

Settings only -I${includedir}/GLES2 breaks Qt5's CMake files, because at configure time CMake only searchs the paths reported by pkg-config, and not even /usr/include is used as default.

Do not indent the commit log, please.

Also, I'd add the same blurb as for ti-gfx. BTW, adding this blurb would clarify Peter's cncern about the change.

Quoted 1 line
Signed-off-by Peter K?mmel <[email protected]>

With the blurb added:

Reviewed-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 30 lines
---
 package/sunxi-mali/egl.pc    |    2 +-
 package/sunxi-mali/glesv2.pc |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/sunxi-mali/egl.pc +1 -1
index b062ad1..2823209 100644
@@ -8,5 +8,5 @@ Description: ARM Mali implementation of EGL
 Version: 1.4
 Requires:
 Libs: -L${libdir} -lEGL -lGLESv2 -lUMP
-Cflags: -I${includedir}/EGL/ -I${includedir}
+Cflags: -I${includedir}
package/sunxi-mali/glesv2.pc +1 -1
index 9273678..4702d13 100644
@@ -8,5 +8,5 @@ Description: ARM Mali implementation of OpenGL ESv2
 Version: 2.0
 Requires:
 Libs: -L${libdir} -lGLESv2 -lGLESv1_CM -lUMP
-Cflags: -I${includedir}/GLES2
+Cflags: -I${includedir}
Signature · 1 line
1.7.10.4
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 1/2 ti-gfx: use only -I${includedir} as pkg-config Cflags

In reply to Peter Kümmel

Peter, All,

On 2014-06-01 11:50 +0200, Peter K?mmel spake thusly:

Quoted 5 lines

Using only -I${includedir} in common practice.

Settings only -I${includedir}/GLES2 breaks Qt5's CMake files, because at configure time CMake only searchs the paths reported by pkg-config, and not even /usr/include is used as default.

I would add something like:

Even though pkg-config strips out standard include path, that's not the case with pkgconf (which we are using) in cross-compilation, which correctly reports the /usr/include dir prefixed with the sysroot.

Quoted 1 line
Signed-off-by Peter K?mmel <[email protected]>

With the above blurb added in the commit log:

Reviewed-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 28 lines
---
 package/ti-gfx/egl.pc    |    2 +-
 package/ti-gfx/glesv2.pc |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/ti-gfx/egl.pc +1 -1
index 223fb04..36ea413 100644
@@ -8,4 +8,4 @@ Description: TI Graphics SDK implementation of EGL
 Version: 1.9.2188537
 Requires:
 Libs: -L${libdir} -lEGL -lGLESv2 -lIMGegl
-Cflags: -I${includedir}/EGL/ -I${includedir}
+Cflags: -I${includedir}
package/ti-gfx/glesv2.pc +1 -1
index 4c70aec..b458133 100644
@@ -8,4 +8,4 @@ Description: TI Graphics SDK implementation of OpenGL ESv2
 Version: 1.9.2188537
 Requires:
 Libs: -L${libdir} -lGLESv2 -lGLES_CM -lsrv_um -lusc -lEGL -lIMGegl
-Cflags: -I${includedir}/GLES2
+Cflags: -I${includedir}
Signature · 1 line
1.7.10.4
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
author
#4 lore raw

PATCH 1/2 ti-gfx: use only -I${includedir} as pkg-config Cflags

Quoted 16 lines · Yann E. MORIN

Peter, All,

On 2014-06-01 11:50 +0200, Peter K?mmel spake thusly:

Quoted 5 lines

Using only -I${includedir} in common practice.

Settings only -I${includedir}/GLES2 breaks Qt5's CMake files, because at configure time CMake only searchs the paths reported by pkg-config, and not even /usr/include is used as default.

I would add something like:

Even though pkg-config strips out standard include path, that's not the case with pkgconf (which we are using) in cross-compilation, which correctly reports the /usr/include dir prefixed with the sysroot.

Quoted 4 lines
Quoted 1 line
Signed-off-by Peter K?mmel <[email protected]>

With the above blurb added in the commit log:

Reviewed-by "Yann E. MORIN" <[email protected]>

Also noticed it, but I though it will be added by git send-email (at least a Cc:)

Quoted 33 lines

Regards,
Yann E. MORIN.

Quoted 28 lines
---
  package/ti-gfx/egl.pc    |    2 +-
  package/ti-gfx/glesv2.pc |    2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
package/ti-gfx/egl.pc +1 -1
index 223fb04..36ea413 100644
@@ -8,4 +8,4 @@ Description: TI Graphics SDK implementation of EGL
  Version: 1.9.2188537
  Requires:
  Libs: -L${libdir} -lEGL -lGLESv2 -lIMGegl
-Cflags: -I${includedir}/EGL/ -I${includedir}
+Cflags: -I${includedir}
package/ti-gfx/glesv2.pc +1 -2
index 4c70aec..b458133 100644
@@ -8,4 +8,4 @@ Description: TI Graphics SDK implementation of OpenGL ESv2
  Version: 1.9.2188537
  Requires:
  Libs: -L${libdir} -lGLESv2 -lGLES_CM -lsrv_um -lusc -lEGL -lIMGegl
-Cflags: -I${includedir}/GLES2
+Cflags: -I${includedir}
--

1.7.10.4