Skip to contentSkip to conversation

mpg123: bump to 1.20.0, providing better optimizations for ARM and AArch64

PATCH New Thomas Petazzoni 3 participants 3 messages Jun 1, 2014

lore
Share & tools
lore

Thomas Petazzoni

author
#0 lore raw

PATCH 1/1 mpg123: bump to 1.20.0, providing better optimizations for ARM and AArch64

As suggested by Gustavo, this patch bumps mpg123 to 1.20.0, and therefore superseds the patch initially provided by Sven Neumann. In 1.20.0, there is a new CPU type arm_fpu, which will compile code for both VFP and NEON, and choose at runtime which one to use.

Similarly for AArch64, the option --with-cpu=aarch64 will compile both the NEON and generic decoders, and select at runtime which one to use.

Signed-off-by Thomas Petazzoni <[email protected]>
---
 package/mpg123/mpg123.mk | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
package/mpg123/mpg123.mk +9 -1
index d66592c..ac64132 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-MPG123_VERSION = 1.18.0
+MPG123_VERSION = 1.20.0
 MPG123_SOURCE = mpg123-$(MPG123_VERSION).tar.bz2
 MPG123_SITE = http://downloads.sourceforge.net/project/mpg123/mpg123/$(MPG123_VERSION)
 MPG123_CONF_OPT = --disable-lfs-alias

@@ -14,9 +14,17 @@ MPG123_LICENSE_FILES = COPYING
 
 MPG123_CPU = $(if $(BR2_SOFT_FLOAT),generic_nofpu,generic_fpu)
 
+ifeq ($(BR2_aarch64),y)
+MPG123_CPU = aarch64
+endif
+
 ifeq ($(BR2_arm),y)
+ifeq ($(or $(BR2_ARM_CPU_HAS_NEON),$(BR2_ARM_CPU_HAS_VFPV2)),y)
+MPG123_CPU = arm_fpu
+else
 MPG123_CPU = arm_nofpu
 endif
+endif
 
 ifeq ($(BR2_i386),y)
 MPG123_CPU = x86
Signature · 1 line
1.9.3
#1 lore raw

PATCH 1/1 mpg123: bump to 1.20.0, providing better optimizations for ARM and AArch64

Thomas, All,

On 2014-06-01 15:11 +0200, Thomas Petazzoni spake thusly:

Quoted 9 lines

As suggested by Gustavo, this patch bumps mpg123 to 1.20.0, and therefore superseds the patch initially provided by Sven Neumann. In 1.20.0, there is a new CPU type arm_fpu, which will compile code for both VFP and NEON, and choose at runtime which one to use.

Similarly for AArch64, the option --with-cpu=aarch64 will compile both the NEON and generic decoders, and select at runtime which one to use.

Signed-off-by Thomas Petazzoni <[email protected]>
Reviewed-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 42 lines
---
 package/mpg123/mpg123.mk | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
package/mpg123/mpg123.mk +9 -1
index d66592c..ac64132 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-MPG123_VERSION = 1.18.0
+MPG123_VERSION = 1.20.0
 MPG123_SOURCE = mpg123-$(MPG123_VERSION).tar.bz2
 MPG123_SITE = http://downloads.sourceforge.net/project/mpg123/mpg123/$(MPG123_VERSION)
 MPG123_CONF_OPT = --disable-lfs-alias

@@ -14,9 +14,17 @@ MPG123_LICENSE_FILES = COPYING
 
 MPG123_CPU = $(if $(BR2_SOFT_FLOAT),generic_nofpu,generic_fpu)
 
+ifeq ($(BR2_aarch64),y)
+MPG123_CPU = aarch64
+endif
+
 ifeq ($(BR2_arm),y)
+ifeq ($(or $(BR2_ARM_CPU_HAS_NEON),$(BR2_ARM_CPU_HAS_VFPV2)),y)
+MPG123_CPU = arm_fpu
+else
 MPG123_CPU = arm_nofpu
 endif
+endif
 
 ifeq ($(BR2_i386),y)
 MPG123_CPU = x86
Signature · 6 lines
1.9.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 mpg123: bump to 1.20.0, providing better optimizations for ARM and AArch64

In reply to Thomas Petazzoni
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

As suggested by Gustavo, this patch bumps mpg123 to 1.20.0, and therefore superseds the patch initially provided by Sven Neumann. In 1.20.0, there is a new CPU type arm_fpu, which will compile code for both VFP and NEON, and choose at runtime which one to use.

Similarly for AArch64, the option --with-cpu=aarch64 will compile both the NEON and generic decoders, and select at runtime which one to use.

Signed-off-by Thomas Petazzoni <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard