arm64: uid16: fix __kernel_old_{gid,uid}_t definitions
PATCH 1/1 arm64: uid16: fix __kernel_old_{gid,uid}_t definitions
Whilst native arm64 applications don't have the 16-bit UID/GID syscalls wired up, compat tasks can still access them. The 16-bit wrappers for these syscalls use __kernel_old_uid_t and __kernel_old_gid_t, which must be 16-bit data types to maintain compatibility with the 16-bit UIDs used by compat applications.
This patch defines 16-bit __kernel_old_{gid,uid}_t types for arm64 instead of using the 32-bit types provided by asm-generic.
--- arch/arm64/include/asm/Kbuild | 1 - arch/arm64/include/uapi/asm/posix_types.h | 10 ++++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) create mode 100644 arch/arm64/include/uapi/asm/posix_types.h
arch/arm64/include/asm/Kbuild +0 -1
@@ -30,7 +30,6 @@ generic-y += msgbuf.h generic-y += mutex.h generic-y += pci.h generic-y += poll.h -generic-y += posix_types.h generic-y += preempt.h generic-y += resource.h generic-y += rwsem.h
arch/arm64/include/uapi/asm/posix_types.h new file +10 -0
@@ -0,0 +1,10 @@ +#ifndef __ASM_POSIX_TYPES_H +#define __ASM_POSIX_TYPES_H + +typedef unsigned short __kernel_old_uid_t ; +typedef unsigned short __kernel_old_gid_t ; +#define __kernel_old_uid_t __kernel_old_uid_t + +#include <asm-generic/posix_types.h> + +#endif /* __ASM_POSIX_TYPES_H */
Signature · 1 line
1.9.2
PATCH 1/1 arm64: uid16: fix __kernel_old_{gid,uid}_t definitions
Quoted 10 lines · On Monday 02 June 2014 11:47:29 Will Deacon wrote:
Whilst native arm64 applications don't have the 16-bit UID/GID syscalls wired up, compat tasks can still access them. The 16-bit wrappers for these syscalls use
__kernel_old_uid_tand__kernel_old_gid_t, which must be 16-bit data types to maintain compatibility with the 16-bit UIDs used by compat applications.This patch defines 16-bit __kernel_old_{gid,uid}_t types for arm64 instead of using the 32-bit types provided by asm-generic.
Signed-off-by Will Deacon <[email protected]>
Is this a theoretical problem, or did you actually encounter binaries with old uid syscalls?
Arnd
PATCH 1/1 arm64: uid16: fix __kernel_old_{gid,uid}_t definitions
Hi Arnd,
Quoted 7 lines · Arnd Bergmann
Quoted 6 lines · On Monday 02 June 2014 11:47:29 Will Deacon wrote:
Whilst native arm64 applications don't have the 16-bit UID/GID syscalls wired up, compat tasks can still access them. The 16-bit wrappers for these syscalls use
__kernel_old_uid_tand__kernel_old_gid_t, which must be 16-bit data types to maintain compatibility with the 16-bit UIDs used by compat applications.
Quoted 6 lines
Quoted 4 lines
This patch defines 16-bit __kernel_old_{gid,uid}_t types for arm64 instead of using the 32-bit types provided by asm-generic.
Signed-off-by Will Deacon <[email protected]>Acked-by Arnd Bergmann <[email protected]>
Cheers!
Quoted 2 lines
Is this a theoretical problem, or did you actually encounter binaries with old uid syscalls?
I hit it during an AArch32 LTP run which passes '-1' for some parameters to the 16-bit flavours of setreuid etc. So I suppose it's theoretical in the sense that I've only observed the issue within a testsuite as opposed to a real application.
Will