mx6: Fix definition of IOMUXC_GPR12_DEVICE_TYPE_RC
PATCH 1/1 mx6: Fix definition of IOMUXC_GPR12_DEVICE_TYPE_RC
From: Fabio Estevam <[email protected]>
mx6 reference manual incorrectly states that the DEVICE_TYPE field of IOMUXC_GPR12 register should be configured as '0010' for setting the PCI controller in RC mode. The correct value should be '0100' instead.
This also aligns with the same value used in the mx6 pci kernel driver.
--- arch/arm/include/asm/arch-mx6/iomux.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/include/asm/arch-mx6/iomux.h +1 -1
@@ -39,7 +39,7 @@#define IOMUXC_GPR12_LOS_LEVEL_MASK (0x1f << 4)#define IOMUXC_GPR12_APPS_LTSSM_ENABLE (1 << 10)#define IOMUXC_GPR12_DEVICE_TYPE_EP (0x0 << 12) -#define IOMUXC_GPR12_DEVICE_TYPE_RC (0x2 << 12) +#define IOMUXC_GPR12_DEVICE_TYPE_RC (0x4 << 12)#define IOMUXC_GPR12_DEVICE_TYPE_MASK (0xf << 12)/*
Signature · 1 line
1.8.3.2
PATCH 1/1 mx6: Fix definition of IOMUXC_GPR12_DEVICE_TYPE_RC
Quoted 9 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
mx6 reference manual incorrectly states that the
DEVICE_TYPEfield ofIOMUXC_GPR12register should be configured as '0010' for setting the PCI controller in RC mode. The correct value should be '0100' instead.This also aligns with the same value used in the mx6 pci kernel driver.
Signed-off-by Fabio Estevam <[email protected]>
Best regards,
Marek Vasut
PATCH 1/1 mx6: Fix definition of IOMUXC_GPR12_DEVICE_TYPE_RC
In reply to Fabio EstevamHi Fabio,
Quoted 18 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
mx6 reference manual incorrectly states that the
DEVICE_TYPEfield ofIOMUXC_GPR12register should be configured as '0010' for setting the PCI controller in RC mode. The correct value should be '0100' instead.This also aligns with the same value used in the mx6 pci kernel driver.
Signed-off-by Fabio Estevam <[email protected]>--- arch/arm/include/asm/arch-mx6/iomux.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/include/asm/arch-mx6/iomux.h +0
-0
arch/arm/include/asm/arch-mx6/iomux.h line 44
Quoted 7 lines
arch/arm/include/asm/arch-mx6/iomux.h +1
-1@@ -39,7 +39,7 @@#define IOMUXC_GPR12_LOS_LEVEL_MASK (0x1f << 4)#define IOMUXC_GPR12_APPS_LTSSM_ENABLE (1 << 10)#define IOMUXC_GPR12_DEVICE_TYPE_EP (0x0 << 12) -#define IOMUXC_GPR12_DEVICE_TYPE_RC (0x2 << 12) +#define IOMUXC_GPR12_DEVICE_TYPE_RC (0x4 << 12)#define IOMUXC_GPR12_DEVICE_TYPE_MASK (0xf << 12)
I will merge it for the release.
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH 1/1 mx6: Fix definition of IOMUXC_GPR12_DEVICE_TYPE_RC
In reply to Fabio EstevamHi Fabio,
Quoted 18 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
mx6 reference manual incorrectly states that the
DEVICE_TYPEfield ofIOMUXC_GPR12register should be configured as '0010' for setting the PCI controller in RC mode. The correct value should be '0100' instead.This also aligns with the same value used in the mx6 pci kernel driver.
Signed-off-by Fabio Estevam <[email protected]>--- arch/arm/include/asm/arch-mx6/iomux.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/include/asm/arch-mx6/iomux.h +0
-0
arch/arm/include/asm/arch-mx6/iomux.h line 44
Quoted 7 lines
arch/arm/include/asm/arch-mx6/iomux.h +1
-1@@ -39,7 +39,7 @@#define IOMUXC_GPR12_LOS_LEVEL_MASK (0x1f << 4)#define IOMUXC_GPR12_APPS_LTSSM_ENABLE (1 << 10)#define IOMUXC_GPR12_DEVICE_TYPE_EP (0x0 << 12) -#define IOMUXC_GPR12_DEVICE_TYPE_RC (0x2 << 12) +#define IOMUXC_GPR12_DEVICE_TYPE_RC (0x4 << 12)#define IOMUXC_GPR12_DEVICE_TYPE_MASK (0xf << 12)
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================