Skip to contentSkip to conversation

rpi-userland/xbmc fixes

PATCH New Samuel Martin 5 participants 17 messages Jun 4, 2014 – Jun 8, 2014

lore
Share & tools
lore

Samuel Martin

author
#0 lore raw

v6 cover rpi-userland/xbmc fixes

Hi all,

Here is just more fixes about rpi-userland/xbmc and all.

Yours,
Samuel

Samuel Martin (3):
xbmc: fix missing libraries from rpi-userland
rpi-userland: add patch fix missing libvcilcs install rules
rpi-userland: cleanup *_CONF_OPT

Yann E. MORIN (1):
package/libcec: fix missing libraries from rpi-userland

 package/libcec/libcec.mk                           |  1 +
 ...vmcs_host-add-install-rules-for-libvcilcs.patch | 23 ++++++++++++++++++++++
 package/rpi-userland/rpi-userland.mk               |  2 +-
 package/xbmc/xbmc.mk                               |  3 ++-
 4 files changed, 27 insertions(+), 2 deletions(-)
 create mode 100644 package/rpi-userland/rpi-userland-003-interface-vmcs_host-add-install-rules-for-libvcilcs.patch

--
2.0.0

author
#1 lore raw

PATCH v6 1/4 package/libcec: fix missing libraries from rpi-userland

From: "Yann E. MORIN" <[email protected]>

When rpi-userland libraries are built as shared-objects, not all needed libraries are passed in the LD_FLAGS, leading to failure at linkage.

To avoid this issue, set the LIBS variable content in accordance with INCLUDES variable value.

This is needed because libcec does not use pkg-config to look for the ldflags needed for -lbcm_host, even though bcm_host provides a .pc file (even a correct one!)

Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Samuel Martin <[email protected]>
---
 package/libcec/libcec.mk | 1 +
 1 file changed, 1 insertion(+)
package/libcec/libcec.mk +1 -0
index 0aabb06..ad919fc 100644
@@ -26,6 +26,7 @@ ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
 LIBCEC_CONF_OPT = --enable-rpi \
    --with-rpi-include-path=$(STAGING_DIR)/usr/include
 LIBCEC_DEPENDENCIES += rpi-userland
+LIBCEC_CONF_ENV += LIBS="-lvcos -lvchostif"
 else
 LIBCEC_CONF_OPT = --disable-rpi
 endif
Signature · 1 line
2.0.0
#2 lore raw

PATCH v6 1/4 package/libcec: fix missing libraries from rpi-userland

Hi all,

This time on the right patch :)

Tested-by Maxime Hadjinlian <[email protected]>
Quoted 37 lines · Samuel Martin

From: "Yann E. MORIN" <[email protected]>

When rpi-userland libraries are built as shared-objects, not all needed libraries are passed in the LD_FLAGS, leading to failure at linkage.

To avoid this issue, set the LIBS variable content in accordance with INCLUDES variable value.

This is needed because libcec does not use pkg-config to look for the ldflags needed for -lbcm_host, even though bcm_host provides a .pc file (even a correct one!)

Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Samuel Martin <[email protected]>
---
 package/libcec/libcec.mk | 1 +
 1 file changed, 1 insertion(+)
package/libcec/libcec.mk +1 -1
index 0aabb06..ad919fc 100644
@@ -26,6 +26,7 @@ ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
 LIBCEC_CONF_OPT = --enable-rpi \
    --with-rpi-include-path=$(STAGING_DIR)/usr/include
 LIBCEC_DEPENDENCIES += rpi-userland
+LIBCEC_CONF_ENV += LIBS="-lvcos -lvchostif"
 else
 LIBCEC_CONF_OPT = --disable-rpi
 endif
--

2.0.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

author
#3 lore raw

PATCH v6 2/4 xbmc: fix missing libraries from rpi-userland

In reply to Samuel Martin

When rpi-userland libraries are built as shared-objects, not all needed libraries are passed in the LD_FLAGS, leading to failure at linkage.

To avoid this issue, set the LIBS variable content in accordance with the INCLUDES variable value.

The commit 5e3b1f31b3f82e3b163567f10d7131c9d649a2cf currently works around this issue by forcing rpi-userland to be statically linked, whereas it is actually a LIBS flags problem in xbmc package.

A follow-up patch fixes rpi-userland package.

Reported-by Maxime Hadjinlian <[email protected]>
Signed-off-by Samuel Martin <[email protected]>
Cc Maxime Hadjinlian <[email protected]>
Cc "Yann E. MORIN" <[email protected]>

---
changes v5 -> v6:
- rebase

changes v4 -> v5:
- rebase
- extend commit message

changes v3 -> v4:
- rebase

changes v2 -> v3:
- new patch

---
 package/xbmc/xbmc.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/xbmc/xbmc.mk +2 -1
index c7a4607..8c0146e 100644
@@ -53,7 +53,8 @@ ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
 XBMC_DEPENDENCIES += rpi-userland
 XBMC_CONF_OPT += --with-platform=raspberry-pi --enable-player=omxplayer
 XBMC_CONF_ENV += INCLUDES="-I$(STAGING_DIR)/usr/include/interface/vcos/pthreads \
-	-I$(STAGING_DIR)/usr/include/interface/vmcs_host/linux"
+	-I$(STAGING_DIR)/usr/include/interface/vmcs_host/linux" \
+	LIBS="-lvcos -lvchostif"
 endif
 
 ifeq ($(BR2_PACKAGE_DBUS),y)
Signature · 1 line
2.0.0
#4 lore raw

PATCH v6 2/4 xbmc: fix missing libraries from rpi-userland

Samuel, All,

On 2014-06-05 01:04 +0200, Samuel Martin spake thusly:

Quoted 10 lines

When rpi-userland libraries are built as shared-objects, not all needed libraries are passed in the LD_FLAGS, leading to failure at linkage.

To avoid this issue, set the LIBS variable content in accordance with the INCLUDES variable value.

The commit 5e3b1f31b3f82e3b163567f10d7131c9d649a2cf currently works around this issue by forcing rpi-userland to be statically linked, whereas it is actually a LIBS flags problem in xbmc package.

Quoted 6 lines

A follow-up patch fixes rpi-userland package.

Reported-by Maxime Hadjinlian <[email protected]>
Signed-off-by Samuel Martin <[email protected]>
Cc Maxime Hadjinlian <[email protected]>
Cc "Yann E. MORIN" <[email protected]>
Tested-by "Yann E. MORIN" <[email protected]>
Acked-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 34 lines

---
changes v5 -> v6:
- rebase

changes v4 -> v5:
- rebase
- extend commit message

changes v3 -> v4:
- rebase

changes v2 -> v3:
- new patch

---
 package/xbmc/xbmc.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/xbmc/xbmc.mk +2 -1
index c7a4607..8c0146e 100644
@@ -53,7 +53,8 @@ ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
 XBMC_DEPENDENCIES += rpi-userland
 XBMC_CONF_OPT += --with-platform=raspberry-pi --enable-player=omxplayer
 XBMC_CONF_ENV += INCLUDES="-I$(STAGING_DIR)/usr/include/interface/vcos/pthreads \
-	-I$(STAGING_DIR)/usr/include/interface/vmcs_host/linux"
+	-I$(STAGING_DIR)/usr/include/interface/vmcs_host/linux" \
+	LIBS="-lvcos -lvchostif"
 endif
 
 ifeq ($(BR2_PACKAGE_DBUS),y)
Signature · 1 line
2.0.0
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#5 lore raw

PATCH v6 2/4 xbmc: fix missing libraries from rpi-userland

Hi all,

Tested-by "Maxime Hadjinlian" <[email protected]>
Quoted 68 lines · Yann E. MORIN

Samuel, All,

On 2014-06-05 01:04 +0200, Samuel Martin spake thusly:

Quoted 10 lines

When rpi-userland libraries are built as shared-objects, not all needed libraries are passed in the LD_FLAGS, leading to failure at linkage.

To avoid this issue, set the LIBS variable content in accordance with the INCLUDES variable value.

The commit 5e3b1f31b3f82e3b163567f10d7131c9d649a2cf currently works around this issue by forcing rpi-userland to be statically linked, whereas it is actually a LIBS flags problem in xbmc package.

Quoted 6 lines

A follow-up patch fixes rpi-userland package.

Reported-by Maxime Hadjinlian <[email protected]>
Signed-off-by Samuel Martin <[email protected]>
Cc Maxime Hadjinlian <[email protected]>
Cc "Yann E. MORIN" <[email protected]>
Tested-by "Yann E. MORIN" <[email protected]>
Acked-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 32 lines

---
changes v5 -> v6:
- rebase

changes v4 -> v5:
- rebase
- extend commit message

changes v3 -> v4:
- rebase

changes v2 -> v3:
- new patch

---
 package/xbmc/xbmc.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/xbmc/xbmc.mk +2 -2
index c7a4607..8c0146e 100644
@@ -53,7 +53,8 @@ ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
 XBMC_DEPENDENCIES += rpi-userland
 XBMC_CONF_OPT += --with-platform=raspberry-pi --enable-player=omxplayer
 XBMC_CONF_ENV += INCLUDES="-I$(STAGING_DIR)/usr/include/interface/vcos/pthreads \
-     -I$(STAGING_DIR)/usr/include/interface/vmcs_host/linux"
+     -I$(STAGING_DIR)/usr/include/interface/vmcs_host/linux" \
+     LIBS="-lvcos -lvchostif"
 endif
 
 ifeq ($(BR2_PACKAGE_DBUS),y)
--
Quoted 2 lines

2.0.0

--
.-----------------.--------------------.------------------.--------------------.

|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |

'------------------------------^-------^------------------^--------------------'

author
#6 lore raw

PATCH v6 3/4 rpi-userland: add patch fix missing libvcilcs install rules

In reply to Samuel Martin

This change adds a patch fix the missing install rules for libvcilcs.

This is a pre-requisite to be able to build the shared libraries of the rpi-userland package, and most importantly avoid linkage failure (at link-time and/or runtime) in others libraries that link with it.

Reported-by "Yann E. MORIN" <[email protected]>
Signed-off-by Samuel Martin <[email protected]>
Tested-by "Yann E. MORIN" <[email protected]>

---
changes v5 -> v6:
- new patch

---
 ...vmcs_host-add-install-rules-for-libvcilcs.patch | 23 ++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 package/rpi-userland/rpi-userland-003-interface-vmcs_host-add-install-rules-for-libvcilcs.patch
package/rpi-userland/rpi-userland-003-interface-vmcs_host-add-install-rules-for-libvcilcs.patch new file +23 -0
new file mode 100644
index 0000000..05cf4b3
@@ -0,0 +1,23 @@
+From b60398837ddf39d4b605600abc167d4366e454a6 Mon Sep 17 00:00:00 2001
+From: Samuel Martin <[email protected]>
+Date: Thu, 5 Jun 2014 00:06:08 +0200
+Subject: [PATCH] interface/vmcs_host: add install rules for libvcilcs
+
+Signed-off-by: Samuel Martin <[email protected]>
+---
+ interface/vmcs_host/CMakeLists.txt | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/interface/vmcs_host/CMakeLists.txt b/interface/vmcs_host/CMakeLists.txt
+index 64ba2f8..8510f81 100755
+--- a/interface/vmcs_host/CMakeLists.txt
++++ b/interface/vmcs_host/CMakeLists.txt
+@@ -33,4 +33,5 @@ target_link_libraries(vchostif vchiq_arm vcos vcfiled_check)
+ 
+ add_subdirectory(linux/vcfiled)
+ install(TARGETS vchostif DESTINATION lib)
++install(TARGETS vcilcs DESTINATION lib)
+ 
+-- 
+2.0.0
+
Signature · 1 line
2.0.0
#7 lore raw

PATCH v6 3/4 rpi-userland: add patch fix missing libvcilcs install rules

Samuel, All,

On 2014-06-05 01:04 +0200, Samuel Martin spake thusly:

Quoted 9 lines

This change adds a patch fix the missing install rules for libvcilcs.

This is a pre-requisite to be able to build the shared libraries of the rpi-userland package, and most importantly avoid linkage failure (at link-time and/or runtime) in others libraries that link with it.

Reported-by "Yann E. MORIN" <[email protected]>
Signed-off-by Samuel Martin <[email protected]>
Tested-by "Yann E. MORIN" <[email protected]>
Acked-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 44 lines

---
changes v5 -> v6:
- new patch

---
 ...vmcs_host-add-install-rules-for-libvcilcs.patch | 23 ++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 package/rpi-userland/rpi-userland-003-interface-vmcs_host-add-install-rules-for-libvcilcs.patch
package/rpi-userland/rpi-userland-003-interface-vmcs_host-add-install-rules-for-libvcilcs.patch new file +23 -0
new file mode 100644
index 0000000..05cf4b3
@@ -0,0 +1,23 @@
+From b60398837ddf39d4b605600abc167d4366e454a6 Mon Sep 17 00:00:00 2001
+From: Samuel Martin <[email protected]>
+Date: Thu, 5 Jun 2014 00:06:08 +0200
+Subject: [PATCH] interface/vmcs_host: add install rules for libvcilcs
+
+Signed-off-by: Samuel Martin <[email protected]>
+---
+ interface/vmcs_host/CMakeLists.txt | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/interface/vmcs_host/CMakeLists.txt b/interface/vmcs_host/CMakeLists.txt
+index 64ba2f8..8510f81 100755
+--- a/interface/vmcs_host/CMakeLists.txt
++++ b/interface/vmcs_host/CMakeLists.txt
+@@ -33,4 +33,5 @@ target_link_libraries(vchostif vchiq_arm vcos vcfiled_check)
+ 
+ add_subdirectory(linux/vcfiled)
+ install(TARGETS vchostif DESTINATION lib)
++install(TARGETS vcilcs DESTINATION lib)
+ 
+-- 
+2.0.0
+
Signature · 6 lines
2.0.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#8 lore raw

PATCH v6 3/4 rpi-userland: add patch fix missing libvcilcs install rules

Hi all,

Tested-by Maxime Hadjinlian <[email protected]>
Quoted 74 lines · Yann E. MORIN

Samuel, All,

On 2014-06-05 01:04 +0200, Samuel Martin spake thusly:

Quoted 9 lines

This change adds a patch fix the missing install rules for libvcilcs.

This is a pre-requisite to be able to build the shared libraries of the rpi-userland package, and most importantly avoid linkage failure (at link-time and/or runtime) in others libraries that link with it.

Reported-by "Yann E. MORIN" <[email protected]>
Signed-off-by Samuel Martin <[email protected]>
Tested-by "Yann E. MORIN" <[email protected]>
Acked-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 40 lines

---
changes v5 -> v6:
- new patch

---
 ...vmcs_host-add-install-rules-for-libvcilcs.patch | 23 ++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 package/rpi-userland/rpi-userland-003-interface-vmcs_host-add-install-rules-for-libvcilcs.patch
package/rpi-userland/rpi-userland-003-interface-vmcs_host-add-install-rules-for-libvcilcs.patch new file +23 -1
new file mode 100644
index 0000000..05cf4b3
@@ -0,0 +1,23 @@
+From b60398837ddf39d4b605600abc167d4366e454a6 Mon Sep 17 00:00:00 2001
+From: Samuel Martin <[email protected]>
+Date: Thu, 5 Jun 2014 00:06:08 +0200
+Subject: [PATCH] interface/vmcs_host: add install rules for libvcilcs
+
+Signed-off-by: Samuel Martin <[email protected]>
+---
+ interface/vmcs_host/CMakeLists.txt | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/interface/vmcs_host/CMakeLists.txt b/interface/vmcs_host/CMakeLists.txt
+index 64ba2f8..8510f81 100755
+--- a/interface/vmcs_host/CMakeLists.txt
++++ b/interface/vmcs_host/CMakeLists.txt
+@@ -33,4 +33,5 @@ target_link_libraries(vchostif vchiq_arm vcos vcfiled_check)
+
+ add_subdirectory(linux/vcfiled)
+ install(TARGETS vchostif DESTINATION lib)
++install(TARGETS vcilcs DESTINATION lib)
+
+--
+2.0.0
+
--

2.0.0

Quoted 4 lines

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

--
.-----------------.--------------------.------------------.--------------------.

|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |

'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

author
#9 lore raw

PATCH v6 4/4 rpi-userland: cleanup *_CONF_OPT

In reply to Samuel Martin

This change reverts the commit 5e3b1f31b3f82e3b163567f10d7131c9d649a2cf because rpi-userland is correctly built whatever the value of the BUILD_SHARED_LIBS CMake flags.

The cset 5e3b1f31b3f82e3b163567f10d7131c9d649a2cf originally intends to fix linkage/runtime failure in xbmc package because of missing flags in xbmc LIBS env. var. This has been fixed in the previous patch.

So, for rpi-userland package, BUILD_SHARED_LIBS does no longer need to be forced to OFF, and can safely be driven by the CMake infrastructure.

Signed-off-by Samuel Martin <[email protected]>
Cc "Yann E. MORIN" <[email protected]>
Cc Thomas Petazzoni <[email protected]>

---
changes v5 -> v6:
- rebase

changes v4 -> v5:
- rebase
- extend commit log (ThomasP)

changes v3 -> v4:
- rebase

changes v2 -> v3:
- new patch

---
 package/rpi-userland/rpi-userland.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/rpi-userland/rpi-userland.mk +1 -1
index 8b225ba..2de6b92 100644
@@ -9,7 +9,7 @@ RPI_USERLAND_SITE = $(call github,raspberrypi,userland,$(RPI_USERLAND_VERSION))
 RPI_USERLAND_LICENSE = BSD-3c
 RPI_USERLAND_LICENSE_FILES = LICENCE
 RPI_USERLAND_INSTALL_STAGING = YES
-RPI_USERLAND_CONF_OPT = -DVMCS_INSTALL_PREFIX=/usr -DBUILD_SHARED_LIBS=OFF
+RPI_USERLAND_CONF_OPT = -DVMCS_INSTALL_PREFIX=/usr
 
 RPI_USERLAND_PROVIDES = libegl libgles libopenmax libopenvg
Signature · 1 line
2.0.0
#10 lore raw

PATCH v6 4/4 rpi-userland: cleanup *_CONF_OPT

Samuel, All,

On 2014-06-05 01:04 +0200, Samuel Martin spake thusly:

Quoted 8 lines

This change reverts the commit 5e3b1f31b3f82e3b163567f10d7131c9d649a2cf because rpi-userland is correctly built whatever the value of the BUILD_SHARED_LIBS CMake flags.

The cset 5e3b1f31b3f82e3b163567f10d7131c9d649a2cf originally intends to fix linkage/runtime failure in xbmc package because of missing flags in xbmc LIBS env. var. This has been fixed in the previous patch.

Quoted 6 lines

So, for rpi-userland package, BUILD_SHARED_LIBS does no longer need to be forced to OFF, and can safely be driven by the CMake infrastructure.

Signed-off-by Samuel Martin <[email protected]>
Cc "Yann E. MORIN" <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Tested-by "Yann E. MORIN" <[email protected]>
Acked-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 33 lines

---
changes v5 -> v6:
- rebase

changes v4 -> v5:
- rebase
- extend commit log (ThomasP)

changes v3 -> v4:
- rebase

changes v2 -> v3:
- new patch

---
 package/rpi-userland/rpi-userland.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/rpi-userland/rpi-userland.mk +1 -1
index 8b225ba..2de6b92 100644
@@ -9,7 +9,7 @@ RPI_USERLAND_SITE = $(call github,raspberrypi,userland,$(RPI_USERLAND_VERSION))
 RPI_USERLAND_LICENSE = BSD-3c
 RPI_USERLAND_LICENSE_FILES = LICENCE
 RPI_USERLAND_INSTALL_STAGING = YES
-RPI_USERLAND_CONF_OPT = -DVMCS_INSTALL_PREFIX=/usr -DBUILD_SHARED_LIBS=OFF
+RPI_USERLAND_CONF_OPT = -DVMCS_INSTALL_PREFIX=/usr
 
 RPI_USERLAND_PROVIDES = libegl libgles libopenmax libopenvg
Signature · 1 line
2.0.0
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#11 lore raw

PATCH v6 4/4 rpi-userland: cleanup *_CONF_OPT

Hi all,

Tested-by "Maxime Hadjinlian" <[email protected]>
Quoted 69 lines · Yann E. MORIN

Samuel, All,

On 2014-06-05 01:04 +0200, Samuel Martin spake thusly:

Quoted 8 lines

This change reverts the commit 5e3b1f31b3f82e3b163567f10d7131c9d649a2cf because rpi-userland is correctly built whatever the value of the BUILD_SHARED_LIBS CMake flags.

The cset 5e3b1f31b3f82e3b163567f10d7131c9d649a2cf originally intends to fix linkage/runtime failure in xbmc package because of missing flags in xbmc LIBS env. var. This has been fixed in the previous patch.

Quoted 6 lines

So, for rpi-userland package, BUILD_SHARED_LIBS does no longer need to be forced to OFF, and can safely be driven by the CMake infrastructure.

Signed-off-by Samuel Martin <[email protected]>
Cc "Yann E. MORIN" <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Tested-by "Yann E. MORIN" <[email protected]>
Acked-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 31 lines

---
changes v5 -> v6:
- rebase

changes v4 -> v5:
- rebase
- extend commit log (ThomasP)

changes v3 -> v4:
- rebase

changes v2 -> v3:
- new patch

---
 package/rpi-userland/rpi-userland.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/rpi-userland/rpi-userland.mk +1 -2
index 8b225ba..2de6b92 100644
@@ -9,7 +9,7 @@ RPI_USERLAND_SITE = $(call github,raspberrypi,userland,$(RPI_USERLAND_VERSION))
 RPI_USERLAND_LICENSE = BSD-3c
 RPI_USERLAND_LICENSE_FILES = LICENCE
 RPI_USERLAND_INSTALL_STAGING = YES
-RPI_USERLAND_CONF_OPT = -DVMCS_INSTALL_PREFIX=/usr -DBUILD_SHARED_LIBS=OFF
+RPI_USERLAND_CONF_OPT = -DVMCS_INSTALL_PREFIX=/usr
 
 RPI_USERLAND_PROVIDES = libegl libgles libopenmax libopenvg
 
--
Quoted 2 lines

2.0.0

--
.-----------------.--------------------.------------------.--------------------.

|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |

'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

#12 lore raw

PATCH v6 4/4 rpi-userland: cleanup *_CONF_OPT

In reply to Samuel Martin

Samuel, All,

On 2014-06-05 01:04 +0200, Samuel Martin spake thusly:

Quoted 10 lines

This change reverts the commit 5e3b1f31b3f82e3b163567f10d7131c9d649a2cf because rpi-userland is correctly built whatever the value of the BUILD_SHARED_LIBS CMake flags.

The cset 5e3b1f31b3f82e3b163567f10d7131c9d649a2cf originally intends to fix linkage/runtime failure in xbmc package because of missing flags in xbmc LIBS env. var. This has been fixed in the previous patch.

So, for rpi-userland package, BUILD_SHARED_LIBS does no longer need to be forced to OFF, and can safely be driven by the CMake infrastructure.

Fixes:

    http://autobuild.buildroot.net/results/6f3/6f36ad6a78d9c0e204d617ec6d15e7b577542c28/
    http://autobuild.buildroot.net/results/789/789fd88c66f898d0a2fd22acc27e9378dd4147af/
    http://autobuild.buildroot.net/results/588/58823900673d4b5304255c1c08ad529c262dd1ee/

Regards,
Yann E. MORIN.

Quoted 37 lines
Signed-off-by Samuel Martin <[email protected]>
Cc "Yann E. MORIN" <[email protected]>
Cc Thomas Petazzoni <[email protected]>

---
changes v5 -> v6:
- rebase

changes v4 -> v5:
- rebase
- extend commit log (ThomasP)

changes v3 -> v4:
- rebase

changes v2 -> v3:
- new patch

---
 package/rpi-userland/rpi-userland.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/rpi-userland/rpi-userland.mk +1 -1
index 8b225ba..2de6b92 100644
@@ -9,7 +9,7 @@ RPI_USERLAND_SITE = $(call github,raspberrypi,userland,$(RPI_USERLAND_VERSION))
 RPI_USERLAND_LICENSE = BSD-3c
 RPI_USERLAND_LICENSE_FILES = LICENCE
 RPI_USERLAND_INSTALL_STAGING = YES
-RPI_USERLAND_CONF_OPT = -DVMCS_INSTALL_PREFIX=/usr -DBUILD_SHARED_LIBS=OFF
+RPI_USERLAND_CONF_OPT = -DVMCS_INSTALL_PREFIX=/usr
 
 RPI_USERLAND_PROVIDES = libegl libgles libopenmax libopenvg
Signature · 1 line
2.0.0
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#13 lore raw

v6 cover rpi-userland/xbmc fixes

In reply to Samuel Martin

Samuel, All,

Quoted 4 lines · Samuel Martin

Samuel Martin (3):
xbmc: fix missing libraries from rpi-userland
rpi-userland: add patch fix missing libvcilcs install rules
rpi-userland: cleanup *_CONF_OPT

You forgot to propagate my acked-and-tested tags on patches 1 and 3.

Regards,
Yann E. MORIN.

Quoted 19 lines

Yann E. MORIN (1):
package/libcec: fix missing libraries from rpi-userland

package/libcec/libcec.mk | 1 +
...vmcs_host-add-install-rules-for-libvcilcs.patch | 23
++++++++++++++++++++++

package/rpi-userland/rpi-userland.mk               |  2 +-
package/xbmc/xbmc.mk                               |  3 ++-
4 files changed, 27 insertions(+), 2 deletions(-)

create mode 100644 package/rpi-userland/rpi-userland-003-interface-vmcs_host-add-install-rules-for-libvcilcs.patch

--
2.0.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 4 lines
Sent from my Android device with K-9 Mail. Please excuse my brevity.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140605/79256f66/attachment.html>
#14 lore raw

v6 cover rpi-userland/xbmc fixes

In reply to Samuel Martin

Samuel, All,

(Grr... K9 drops the text in the quoted part)

You forgot to propagate my tested-and-acked-tags to patches 1 and 3.

Regards,
Yann E MORIN.

Quoted 31 lines · Samuel Martin

Hi all,

Here is just more fixes about rpi-userland/xbmc and all.

Yours,
Samuel

Samuel Martin (3):
xbmc: fix missing libraries from rpi-userland
rpi-userland: add patch fix missing libvcilcs install rules
rpi-userland: cleanup *_CONF_OPT

Yann E. MORIN (1):
package/libcec: fix missing libraries from rpi-userland

package/libcec/libcec.mk | 1 +
...vmcs_host-add-install-rules-for-libvcilcs.patch | 23
++++++++++++++++++++++

package/rpi-userland/rpi-userland.mk               |  2 +-
package/xbmc/xbmc.mk                               |  3 ++-
4 files changed, 27 insertions(+), 2 deletions(-)

create mode 100644 package/rpi-userland/rpi-userland-003-interface-vmcs_host-add-install-rules-for-libvcilcs.patch

--
2.0.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 4 lines
Sent from my Android device with K-9 Mail. Please excuse my brevity.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140605/3cba6747/attachment.html>
#15 lore raw

v6 cover rpi-userland/xbmc fixes

Hi Yann,

Quoted 1 line · Yann E. MORIN

(Grr... K9 drops the text in the quoted part)

Your text appears correctly in the plaintext part of your email
(http://lists.busybox.net/pipermail/buildroot/2014-June/098501.html), but not the on HTML part
(http://article.gmane.org/gmane.comp.lib.uclibc.buildroot/86031).

baruch

Quoted 32 lines

You forgot to propagate my tested-and-acked-tags to patches 1 and 3.

Regards,
Yann E MORIN.

Quoted 26 lines · Samuel Martin

Hi all,

Here is just more fixes about rpi-userland/xbmc and all.

Yours,
Samuel

Samuel Martin (3):
xbmc: fix missing libraries from rpi-userland
rpi-userland: add patch fix missing libvcilcs install rules
rpi-userland: cleanup *_CONF_OPT

Yann E. MORIN (1):
package/libcec: fix missing libraries from rpi-userland

package/libcec/libcec.mk | 1 +
...vmcs_host-add-install-rules-for-libvcilcs.patch | 23
++++++++++++++++++++++

package/rpi-userland/rpi-userland.mk               |  2 +-
package/xbmc/xbmc.mk                               |  3 ++-
4 files changed, 27 insertions(+), 2 deletions(-)

create mode 100644 package/rpi-userland/rpi-userland-003-interface-vmcs_host-add-install-rules-for-libvcilcs.patch

--
2.0.0

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#16 lore raw

v6 cover rpi-userland/xbmc fixes

In reply to Samuel Martin

Dear Samuel Martin,

Quoted 7 lines · Samuel Martin

Samuel Martin (3):
xbmc: fix missing libraries from rpi-userland
rpi-userland: add patch fix missing libvcilcs install rules
rpi-userland: cleanup *_CONF_OPT

Yann E. MORIN (1):
package/libcec: fix missing libraries from rpi-userland

Series applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com