numa,sched: fix load_to_imbalanced logic inversion
PATCH 1/1 numa,sched: fix load_to_imbalanced logic inversion
This function is supposed to return true if the new load imbalance is worse than the old one. It didn't. I can only hope brown paper bags are in style.
Now things converge much better on both the 4 node and 8 node systems.
I am not sure why this did not seem to impact specjbb performance on the 4 node system, which is the system I have full-time access to.
This bug was introduced recently, with commit e63da036
Signed-off-by Rik van Riel <[email protected]>
--- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sched/fair.c +1 -1
@@ -1112,7 +1112,7 @@ static bool load_too_imbalanced(long orig_src_load, long orig_dst_load, old_imb = orig_dst_load *100 - orig_src_load * env->imbalance_pct;/* Would this change make things worse? */ -return (old_imb > imb); +return (imb > old_imb); }/*