possible typo

DISCUSSION Warren Turkal 4 participants 5 messages Jun 9, 2014 – Jun 10, 2014

Subsystems (2)

Documentation Kbuild

lore

Share & tools

lore

Warren Turkal

author

2014-06-09 05:40 UTC #0 lore raw

Hey,

I think I found a typo in the kbuild docs. A one line commit can be pulled from the "fix_typo" branch from the git repo @ [email protected]:wt/linux.git.

Can someone please take a look at this branch at some point?

Thanks,
wt

Sam Ravnborg

2014-06-09 07:46 UTC #1 lore raw

Quoted 6 lines · Warren Turkal

Hey,
I think I found a typo in the kbuild docs. A one line commit can be pulled from the "fix_typo" branch from the git repo @ [email protected]:wt/linux.git.
Can someone please take a look at this branch at some point?

No.
Please submit this as a regular patch - see Documentation/SubmittingPatches

Sam

Warren Turkal

author

2014-06-09 08:07 UTC #2 lore raw

commit 4ce2f36b4b06b7df569b1875c7ab834270786882

Author: Warren Turkal <[email protected]>
Date:   Sun Jun 8 22:19:29 2014 -0700

Fix a typo.

Signed-off-by Warren Turkal <[email protected]>

Documentation/kbuild/modules.txt +1 -1

index 69372fb..3fb39e0 100644
@@ -470,7 +470,7 @@ build.
 
 	Sometimes, an external module uses exported symbols from
 	another external module. kbuild needs to have full knowledge of
-	all symbols to avoid spliitting out warnings about undefined
+	all symbols to avoid spitting out warnings about undefined
 	symbols. Three solutions exist for this situation.
 
 	NOTE: The method with a top-level kbuild file is recommended

Quoted 12 lines · Sam Ravnborg

Quoted 6 lines · Warren Turkal
Hey,
I think I found a typo in the kbuild docs. A one line commit can be pulled from the "fix_typo" branch from the git repo @ [email protected]:wt/linux.git.
Can someone please take a look at this branch at some point?
No.
Please submit this as a regular patch - see Documentation/SubmittingPatches
Sam

Randy Dunlap

reviewer Acked-by

2014-06-10 00:29 UTC #3 lore raw

Quoted 7 lines · Warren Turkal

commit 4ce2f36b4b06b7df569b1875c7ab834270786882
Author: Warren Turkal <[email protected]>
Date:   Sun Jun 8 22:19:29 2014 -0700
Fix a typo.
Signed-off-by Warren Turkal <[email protected]>

Acked-by Randy Dunlap <[email protected]>

Thanks.

Quoted 28 lines

Documentation/kbuild/modules.txt +1 -1
index 69372fb..3fb39e0 100644
@@ -470,7 +470,7 @@ build.
 
     Sometimes, an external module uses exported symbols from
     another external module. kbuild needs to have full knowledge of
-    all symbols to avoid spliitting out warnings about undefined
+    all symbols to avoid spitting out warnings about undefined
     symbols. Three solutions exist for this situation.
 
     NOTE: The method with a top-level kbuild file is recommended
wt
Quoted 11 lines · Sam Ravnborg
Quoted 6 lines · Warren Turkal
Hey,
I think I found a typo in the kbuild docs. A one line commit can be pulled from the "fix_typo" branch from the git repo @ [email protected]:wt/linux.git.
Can someone please take a look at this branch at some point?
No.
Please submit this as a regular patch - see Documentation/SubmittingPatches
Sam

Signature · 1 line

~Randy

Michal Marek

2014-06-10 12:16 UTC #4 lore raw

In reply to Warren Turkal

Quoted 7 lines · Warren Turkal

commit 4ce2f36b4b06b7df569b1875c7ab834270786882
Author: Warren Turkal <[email protected]>
Date:   Sun Jun 8 22:19:29 2014 -0700
Fix a typo.
Signed-off-by Warren Turkal <[email protected]>

Thanks, I applied the patch to kbuild.git#misc. But please write a more meaningful subject line next time (I changed it to "kbuild: Fix a typo in documentation") and use git format-patch to generate the patch, so that the recipient can pipe your email git git am.

Michal