Skip to contentSkip to conversation

package/tvheadend: Add optional dependency to libiconv

PATCH Superseded Bernd Kuhls 4 participants 6 messages Jun 9, 2014 – Jun 11, 2014

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Bernd Kuhls

author
#0 lore raw

PATCH 1/1 package/tvheadend: Add optional dependency to libiconv

To get reproducable builds depend on libiconv if needed.

tvheadend configure either shows

checking for cc libiconv ... fail

or

checking for cc libiconv ... ok

depending on the presence of libiconv, and gets linked

output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/bin/tvheadend | grep NEEDED | grep iconv
0x00000001 (NEEDED) Shared library: [libiconv.so.2]

Tested with minimal defconfig

BR2_TOOLCHAIN_BUILDROOT_LARGEFILE=y
BR2_TOOLCHAIN_BUILDROOT_INET_IPV6=y
BR2_PACKAGE_LIBICONV=y
BR2_PACKAGE_TVHEADEND=y

Signed-off-by Bernd Kuhls <[email protected]>
---
 package/tvheadend/tvheadend.mk |    4 ++++
 1 file changed, 4 insertions(+)
package/tvheadend/tvheadend.mk +4 -0
index c582c07..4d0a16d 100644
@@ -14,6 +14,10 @@ ifeq ($(BR2_PACKAGE_AVAHI),y)
 TVHEADEND_DEPENDENCIES += avahi
 endif
 
+ifeq ($(BR2_PACKAGE_LIBICONV),y)
+TVHEADEND_DEPENDENCIES += libiconv
+endif
+
 TVHEADEND_DEPENDENCIES += dtv-scan-tables
 
 define TVHEADEND_CONFIGURE_CMDS
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 package/tvheadend: Add optional dependency to libiconv

Bernd, All,

On 2014-06-09 13:23 +0200, Bernd Kuhls spake thusly:

Quoted 15 lines

To get reproducable builds depend on libiconv if needed.

tvheadend configure either shows

checking for cc libiconv ... fail

or

checking for cc libiconv ... ok

depending on the presence of libiconv, and gets linked

output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/bin/tvheadend | grep NEEDED | grep iconv
0x00000001 (NEEDED) Shared library: [libiconv.so.2]

Quoted 8 lines

Tested with minimal defconfig

BR2_TOOLCHAIN_BUILDROOT_LARGEFILE=y
BR2_TOOLCHAIN_BUILDROOT_INET_IPV6=y
BR2_PACKAGE_LIBICONV=y
BR2_PACKAGE_TVHEADEND=y

Signed-off-by Bernd Kuhls <[email protected]>
Reviewed-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 26 lines
---
 package/tvheadend/tvheadend.mk |    4 ++++
 1 file changed, 4 insertions(+)
package/tvheadend/tvheadend.mk +4 -0
index c582c07..4d0a16d 100644
@@ -14,6 +14,10 @@ ifeq ($(BR2_PACKAGE_AVAHI),y)
 TVHEADEND_DEPENDENCIES += avahi
 endif
 
+ifeq ($(BR2_PACKAGE_LIBICONV),y)
+TVHEADEND_DEPENDENCIES += libiconv
+endif
+
 TVHEADEND_DEPENDENCIES += dtv-scan-tables
 
 define TVHEADEND_CONFIGURE_CMDS
Signature · 6 lines
1.7.10.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 package/tvheadend: Add optional dependency to libiconv

In reply to Bernd Kuhls

Dear Bernd Kuhls,

Quoted 4 lines · Bernd Kuhls

BR2_TOOLCHAIN_BUILDROOT_LARGEFILE=y
BR2_TOOLCHAIN_BUILDROOT_INET_IPV6=y
BR2_PACKAGE_LIBICONV=y
BR2_PACKAGE_TVHEADEND=y

You need libiconv because your toolchain does not have locale support. Therefore, your Config.in should have something like:

select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE

see all the other examples in Buildroot.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#3 lore raw

PATCH 1/1 package/tvheadend: Add optional dependency to libiconv

Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8 @public.gmane.org> wrote in news:20140609195850.2317401f at free-electrons.com:

Quoted 6 lines

You need libiconv because your toolchain does not have locale support. Therefore, your Config.in should have something like:

select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE

see all the other examples in Buildroot.

Hi,

libiconv is not a hard-dependency of tvheadend so I thought enabling libiconv in the !BR2_ENABLE_LOCALE case is not necessary here.

Regards, Bernd

#4 lore raw

PATCH 1/1 package/tvheadend: Add optional dependency to libiconv

Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Bernd" == Bernd Kuhls <[email protected]> writes:

Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8 @public.gmane.org> wrote in news:20140609195850.2317401f at free-electrons.com:

Quoted 3 lines

You need libiconv because your toolchain does not have locale support. Therefore, your Config.in should have something like:

Quoted 8 lines
Quoted 3 lines

select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE

see all the other examples in Buildroot.

Hi,

libiconv is not a hard-dependency of tvheadend so I thought enabling libiconv in the !BR2_ENABLE_LOCALE case is not necessary here.

Ahh, so it's just an optional dependency it CAN use if available? Then the patch is fine.

Somehow I don't see it anymore in patchwork though?

Signature · 1 line
Bye, Peter Korsgaard