Skip to contentSkip to conversation

IB/mlx4: Implement IB_QP_CREATE_USE_GFP_NOIO

DISCUSSION Dan Carpenter 1 participant 1 message Jun 9, 2014 InfiniBand

lore
Share & tools
lore
#0 lore raw

Hello Jiri Kosina,

The patch 40f2287bd583: "IB/mlx4: Implement IB_QP_CREATE_USE_GFP_NOIO" from May 11, 2014, leads to the following static checker warning:

	drivers/infiniband/hw/mlx4/qp.c:677 create_qp_common()
	warn: use 'gfp' here instead of GFP_XXX?

drivers/infiniband/hw/mlx4/qp.c
673 if (!*caller_qp) {
674 if (qp_type == MLX4_IB_QPT_SMI || qp_type == MLX4_IB_QPT_GSI ||
675 (qp_type & (MLX4_IB_QPT_PROXY_SMI | MLX4_IB_QPT_PROXY_SMI_OWNER |
676 MLX4_IB_QPT_PROXY_GSI | MLX4_IB_QPT_TUN_SMI_OWNER))) {

   677                          sqp = kzalloc(sizeof (struct mlx4_ib_sqp), GFP_KERNEL);
                                                                           ^^^^^^^^^^
   678                          if (!sqp)
   679                                  return -ENOMEM;
   680                          qp = &sqp->qp;
   681                          qp->pri.vid = 0xFFFF;
   682                          qp->alt.vid = 0xFFFF;
   683                  } else {
   684                          qp = kzalloc(sizeof (struct mlx4_ib_qp), GFP_KERNEL);
                                                                         ^^^^^^^^^^
   685                          if (!qp)
   686                                  return -ENOMEM;
   687                          qp->pri.vid = 0xFFFF;
   688                          qp->alt.vid = 0xFFFF;
   689                  }
   690          } else
   691                  qp = *caller_qp;

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html