Skip to contentSkip to conversation

video/mbx: indent some if statements

PATCH In review Dan Carpenter 2 participants 2 messages Jun 11, 2014 – Jun 23, 2014

Subsystems (2)
Kernel janitors Framebuffer layer
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 video/mbx: indent some if statements

Checkpatch.pl worries that we have left off the conditional bit because it isn't indented correctly.

WARNING: suspect code indent for conditional statements (24, 24)

Signed-off-by Dan Carpenter <[email protected]>
drivers/video/fbdev/mbx/mbxfb.c +2 -2
index 2bd52ed..698df954 100644
@@ -628,14 +628,14 @@ static int mbxfb_ioctl(struct fb_info *info, unsigned int cmd,
 		case MBXFB_IOCS_PLANEORDER:
 			if (copy_from_user(&porder, (void __user*)arg,
 					sizeof(struct mbxfb_planeorder)))
-			return -EFAULT;
+				return -EFAULT;
 
 			return mbxfb_ioctl_planeorder(&porder);
 
 		case MBXFB_IOCS_ALPHA:
 			if (copy_from_user(&alpha, (void __user*)arg,
 					sizeof(struct mbxfb_alphaCtl)))
-			return -EFAULT;
+				return -EFAULT;
 
 			return mbxfb_ioctl_alphactl(&alpha);
#1 lore raw
Quoted 19 lines · Dan Carpenter

Checkpatch.pl worries that we have left off the conditional bit because it isn't indented correctly.

WARNING: suspect code indent for conditional statements (24, 24)

Signed-off-by Dan Carpenter <[email protected]>
drivers/video/fbdev/mbx/mbxfb.c +1 -1
index 2bd52ed..698df954 100644
@@ -628,14 +628,14 @@ static int mbxfb_ioctl(struct fb_info *info, unsigned int cmd,
 		case MBXFB_IOCS_PLANEORDER:
 			if (copy_from_user(&porder, (void __user*)arg,
 					sizeof(struct mbxfb_planeorder)))
-			return -EFAULT;
+				return -EFAULT;

drivers/video/fbdev/mbx/mbxfb.c static int mbxfb_ioctl(struct fb_info *info, unsigned int cmd, · line 641

Quoted 10 lines
drivers/video/fbdev/mbx/mbxfb.c +1 -1
 			return mbxfb_ioctl_planeorder(&porder);
 
 		case MBXFB_IOCS_ALPHA:
 			if (copy_from_user(&alpha, (void __user*)arg,
 					sizeof(struct mbxfb_alphaCtl)))
-			return -EFAULT;
+				return -EFAULT;
 
 			return mbxfb_ioctl_alphactl(&alpha);

Thanks, queued for 3.17.

Tomi