Skip to contentSkip to conversation

Input: psmouse - switch to using dev_*() for messages

DISCUSSION Dan Carpenter 1 participant 1 message Jun 12, 2014 HID

lore
Share & tools
lore
#0 lore raw

Hello Dmitry Torokhov,

This is a semi-automatic email about new static checker warnings.

The patch b5d21704361e: "Input: psmouse - switch to using dev_*() for messages" from Oct 10, 2011, leads to the following Smatch complaint:

drivers/input/mouse/psmouse-base.c:1512 psmouse_reconnect()
error: we previously assumed 'psmouse' could be null (see line 1511)

drivers/input/mouse/psmouse-base.c
1510

  1511		if (!drv || !psmouse) {
                             ^^^^^^^

Old check.

1512 psmouse_dbg(psmouse,

                                    ^^^^^^^

New dereference.

1513 "reconnect request, but serio is disconnected, ignoring...\n");
1514 return -1;

regards,
dan carpenter