Skip to contentSkip to conversation

i2c: sun6-p2wi: fix erroneous error message

PATCH New Boris BREZILLON 2 participants 2 messages Jun 12, 2014 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 53994cdd.dj2lZ0lrPyPuIr9Z%[email protected]

#1 lore raw

PATCH 1/1 i2c: sun6-p2wi: fix erroneous error message

The variable containing the return value of platform_get_irq is irq not ret, this means the error code printed in the error message will be false.

---

Hello Wolfram,

This patch fixes a bug reported by Fengguang's build robot.

I know you've already applied my series to your for-next tree, but let me know if you want me to squash this patch into the P2WI series and send a v8.

Best Regards,

Boris

 drivers/i2c/busses/i2c-sun6i-p2wi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/i2c-sun6i-p2wi.c +1 -1
index f1d3e6f..5d2d678 100644
@@ -240,7 +240,7 @@ static int p2wi_probe(struct platform_device *pdev)
 	snprintf(p2wi->adapter.name, sizeof(p2wi->adapter.name), pdev->name);
 	irq = platform_get_irq(pdev, 0);
 	if (irq < 0) {
-		dev_err(dev, "failed to retrieve irq: %d\n", ret);
+		dev_err(dev, "failed to retrieve irq: %d\n", irq);
 		return irq;
 	}
 
Signature · 1 line
1.8.3.2
#2 lore raw

PATCH 1/1 i2c: sun6-p2wi: fix erroneous error message

Quoted 2 lines

I know you've already applied my series to your for-next tree, but let me know if you want me to squash this patch into the P2WI series and send a v8.

I can't rebase my for-next.

Had it already fixed locally, just forgot to send out due to NMI.

Thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140612/3a5f58ae/attachment.sig>