Skip to contentSkip to conversation

ARM: EXYNOS: Fix compilation warning

PATCH New Sachin Kamat 3 participants 4 messages May 5, 2014 – Jun 13, 2014

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm Samsung Exynos
lore
Share & tools
lore

Sachin Kamat

author
#0 lore raw

PATCH 1/1 ARM: EXYNOS: Fix compilation warning

of_get_flat_dt_prop return type is now const.
Fixes the following compilation warning introduced by commit 9d0c4dfedd96 ("of/fdt: update of_get_flat_dt_prop in prep for libfdt")

arch/arm/mach-exynos/exynos.c:259:6: warning:
assignment discards ?const? qualifier from pointer target type [enabled by default]

Signed-off-by Sachin Kamat <[email protected]>
Cc Rob Herring <[email protected]>

---
Based on linux-next (20140505)

---
 arch/arm/mach-exynos/exynos.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-exynos/exynos.c +1 -1
index 77293d39dfc9..f356c67a1fa9 100644
@@ -249,7 +249,7 @@ static int __init exynos_fdt_map_chipid(unsigned long node, const char *uname,
 					int depth, void *data)
 {
 	struct map_desc iodesc;
-	__be32 *reg;
+	const __be32 *reg;
 	int len;
 
 	if (!of_flat_dt_is_compatible(node, "samsung,exynos4210-chipid") &&
Signature · 1 line
1.7.9.5
author
#1 lore raw

PATCH 1/1 ARM: EXYNOS: Fix compilation warning

Quoted 29 lines · Sachin Kamat

of_get_flat_dt_prop return type is now const.
Fixes the following compilation warning introduced by commit 9d0c4dfedd96 ("of/fdt: update of_get_flat_dt_prop in prep for libfdt")

arch/arm/mach-exynos/exynos.c:259:6: warning:
assignment discards ?const? qualifier from pointer target type [enabled by default]

Signed-off-by Sachin Kamat <[email protected]>
Cc Rob Herring <[email protected]>

---
Based on linux-next (20140505)

---
 arch/arm/mach-exynos/exynos.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-exynos/exynos.c +1 -2
index 77293d39dfc9..f356c67a1fa9 100644
@@ -249,7 +249,7 @@ static int __init exynos_fdt_map_chipid(unsigned long node, const char *uname,
                                        int depth, void *data)
 {
        struct map_desc iodesc;
-       __be32 *reg;
+       const __be32 *reg;
        int len;
 
        if (!of_flat_dt_is_compatible(node, "samsung,exynos4210-chipid") &&
--
Quoted 2 lines

1.7.9.5

Ping. This warning is still seen in latest linux-next.

Signature · 2 lines
With warm regards,
Sachin
#2 lore raw

PATCH 1/1 ARM: EXYNOS: Fix compilation warning

Quoted 11 lines · Sachin Kamat
Quoted 10 lines · Sachin Kamat

of_get_flat_dt_prop return type is now const.
Fixes the following compilation warning introduced by commit 9d0c4dfedd96 ("of/fdt: update of_get_flat_dt_prop in prep for libfdt")

arch/arm/mach-exynos/exynos.c:259:6: warning:
assignment discards ?const? qualifier from pointer target type [enabled by default]

Signed-off-by Sachin Kamat <[email protected]>
Cc Rob Herring <[email protected]>

---

Change looks good.

Reviewed-by Tushar Behera <[email protected]>
Quoted 24 lines
Quoted 19 lines

Based on linux-next (20140505)

---
 arch/arm/mach-exynos/exynos.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-exynos/exynos.c +1 -2
index 77293d39dfc9..f356c67a1fa9 100644
@@ -249,7 +249,7 @@ static int __init exynos_fdt_map_chipid(unsigned long node, const char *uname,
                                        int depth, void *data)
 {
        struct map_desc iodesc;
-       __be32 *reg;
+       const __be32 *reg;
        int len;
 
        if (!of_flat_dt_is_compatible(node, "samsung,exynos4210-chipid") &&
--
Quoted 2 lines

1.7.9.5

Ping. This warning is still seen in latest linux-next.

Signature · 1 line
Tushar Behera
#3 lore raw

PATCH 1/1 ARM: EXYNOS: Fix compilation warning

Quoted 9 lines · Tushar Behera
Quoted 8 lines · Sachin Kamat
Quoted 7 lines · Sachin Kamat

of_get_flat_dt_prop return type is now const.
Fixes the following compilation warning introduced by commit 9d0c4dfedd96 ("of/fdt: update of_get_flat_dt_prop in prep for libfdt")

arch/arm/mach-exynos/exynos.c:259:6: warning:
assignment discards ?const? qualifier from pointer target type [enabled by default]

Quoted 7 lines
Quoted 3 lines
Quoted 3 lines
Signed-off-by Sachin Kamat <[email protected]>
Cc Rob Herring <[email protected]>

---

Change looks good.

Reviewed-by Tushar Behera <[email protected]>

This hasn't shown up in linux-next yet, and hte bug is still there, so I'm applying it directly to the fixes branch in arm-soc before we get more people sending the same patch. Thanks!

Arnd