dcron: new package
PATCH v2 1/1 dcron: new package
---
This version of the patch solves the whole lot of problems noted before. This patch, as is, would enable a system level cron daemon with hourly, daily, weekly and monthly crontabs.
However, it doesn't allow non root users to create their own crontab file. This is because /var/spool/cron/crontabs is non user writable.
Typically, a crontab group is created on the system and users allowed to create crontab entries are added into this group, while crontab executable is owned by root:crontab with sgid bit enabled.
package/Config.in | 1 + package/dcron/Config.in | 9 +++++++++ package/dcron/dcron.mk | 22 ++++++++++++++++++++++ 3 files changed, 32 insertions(+) create mode 100644 package/dcron/Config.in create mode 100644 package/dcron/dcron.mk
package/Config.in +1 -0
@@ -1090,6 +1090,7 @@ source "package/bootutils/Config.in" source "package/coreutils/Config.in" endif source "package/cpuload/Config.in" +source "package/dcron/Config.in" source "package/dsp-tools/Config.in" source "package/htop/Config.in" source "package/iprutils/Config.in"
package/dcron/Config.in new file +9 -0
@@ -0,0 +1,9 @@ +config BR2_PACKAGE_DCRON + bool "dcron" + depends on BR2_USE_MMU # fork() + help + dcron is a time-based job scheduler with anacron-like features. + It works as a background daemon that parses individual crontab + files and executes commands on behalf of the users in question. + + http://www.jimpryor.net/linux/dcron.html
package/dcron/dcron.mk new file +22 -0
@@ -0,0 +1,22 @@ +################################################################################ +# +# dcron +# +################################################################################ + +DCRON_VERSION = 4.5 +DCRON_SITE = http://www.jimpryor.net/linux/releases/ +DCRON_LICENSE = GPL + +define DCRON_BUILD_CMDS + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) $(TARGET_CONFIGURE_OPTS) +endef + +define DCRON_INSTALL_TARGET_CMDS + $(INSTALL) -D -m0644 $(@D)/extra/root.crontab $(TARGET_DIR)/etc/cron.d/system + $(INSTALL) -d -m0755 $(TARGET_DIR)/var/spool/cron/crontabs \ + $(TARGET_DIR)/etc/cron.daily $(TARGET_DIR)/etc/cron.hourly \ + $(TARGET_DIR)/etc/cron.monthly $(TARGET_DIR)/etc/cron.weekly +endef + +$(eval $(generic-package))
Signature · 1 line
2.0.0.rc2
PATCH v2 1/1 dcron: new package
Dear Alvaro G. M,
Thanks for this patch. A couple of comments below.
Quoted 6 lines · Alvaro G. M
Signed-off-by Alvaro G. M <[email protected]>---
This version of the patch solves the whole lot of problems noted before. This patch, as is, would enable a system level cron daemon with hourly, daily, weekly and monthly crontabs.
Quoted 6 lines
However, it doesn't allow non root users to create their own crontab file. This is because
/var/spool/cron/crontabsis non user writable.Typically, a crontab group is created on the system and users allowed to create crontab entries are added into this group, while crontab executable is owned by root:crontab with sgid bit enabled.
Probably, this should be explained in the help text of the Config.in option for the package.
Quoted 12 lines
package/Config.in | 1 + package/dcron/Config.in | 9 +++++++++ package/dcron/dcron.mk | 22 ++++++++++++++++++++++ 3 files changed, 32 insertions(+) create mode 100644 package/dcron/Config.in create mode 100644 package/dcron/dcron.mkpackage/Config.in +0
-0
package/Config.in source "package/bootutils/Config.in" · line 1093
Quoted 4 lines
package/Config.in +1
-0@@ -1090,6 +1090,7 @@ source "package/bootutils/Config.in" source "package/coreutils/Config.in" endif source "package/cpuload/Config.in" +source "package/dcron/Config.in"
It would be good to rebase on top of the latest master, we have changed the package/Config.in indentation.
Quoted 24 lines
package/Config.in +0
-0source "package/dsp-tools/Config.in" source "package/htop/Config.in" source "package/iprutils/Config.in"package/dcron/Config.in new file +9
-0@@ -0,0 +1,9 @@ +config BR2_PACKAGE_DCRON + bool "dcron" + depends on BR2_USE_MMU # fork() + help + dcron is a time-based job scheduler with anacron-like features. + It works as a background daemon that parses individual crontab + files and executes commands on behalf of the users in question. + + http://www.jimpryor.net/linux/dcron.htmlpackage/dcron/dcron.mk new file +0
-0
package/dcron/dcron.mk line 9
Quoted 9 lines
package/dcron/dcron.mk new file +9
-0@@ -0,0 +1,22 @@ +################################################################################ +# +# dcron +# +################################################################################ + +DCRON_VERSION = 4.5 +DCRON_SITE = http://www.jimpryor.net/linux/releases/ +DCRON_LICENSE = GPL
Would be good to add a comment above this saying:
# The source code does not specify the version of the GPL that is used.
package/dcron/dcron.mk line 20
Quoted 10 lines
package/dcron/dcron.mk new file +10
-0+define DCRON_BUILD_CMDS + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) $(TARGET_CONFIGURE_OPTS) +endef + +define DCRON_INSTALL_TARGET_CMDS + $(INSTALL) -D -m0644 $(@D)/extra/root.crontab $(TARGET_DIR)/etc/cron.d/system + $(INSTALL) -d -m0755 $(TARGET_DIR)/var/spool/cron/crontabs \ + $(TARGET_DIR)/etc/cron.daily $(TARGET_DIR)/etc/cron.hourly \ + $(TARGET_DIR)/etc/cron.monthly $(TARGET_DIR)/etc/cron.weekly +endef
And so there is nothing that installs the crond and crontab programs that are built by the dcron sources, so I don't see how this package can work.
In addition, since crond and crontab also exists in Busybox, this package should do:
ifeq ($(BR2_PACKAGE_BUSYBOX),y)DCRON_DEPENDENCIES += busybox
endif
to ensure that dcron is built *after* Busybox and that therefore, its files override the ones installed by Busybox.
And for the same reason, the 'source "package/dcron/Config.in"' in package/Config.in should be enclosed in a:
if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
...
endif
clause.
Could you fix those issues and post an updated version of your patch?
Thanks a lot!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com