Skip to contentSkip to conversation

hyperv: fix apparent cut-n-paste error in send path teardown

PATCH Dave Jones 3 participants 3 messages Jun 16, 2014 – Jun 17, 2014

Subsystems (3)
Networking Network drivers Hyper-V/Azure core and drivers
lore
Share & tools
lore

Dave Jones

author
#0 lore raw

c25aaf814a63: "hyperv: Enable sendbuf mechanism on the send path" added some teardown code that looks like it was copied from the recieve path above, but missed a variable name replacement.

Signed-off-by Dave Jones <[email protected]>
drivers/net/hyperv/netvsc.c +1 -1
index c041f63a6d30..4ed38eaecea8 100644
@@ -189,7 +189,7 @@ static int netvsc_destroy_buf(struct netvsc_device *net_device)
 				   "unable to teardown send buffer's gpadl\n");
 			return ret;
 		}
-		net_device->recv_buf_gpadl_handle = 0;
+		net_device->send_buf_gpadl_handle = 0;
 	}
 	if (net_device->send_buf) {
 		/* Free up the receive buffer */
maintainer
#1 lore raw

From: Dave Jones <[email protected]>
Date: Mon, 16 Jun 2014 16:59:02 -0400

Quoted 5 lines

c25aaf814a63: "hyperv: Enable sendbuf mechanism on the send path" added some teardown code that looks like it was copied from the recieve path above, but missed a variable name replacement.

Signed-off-by Dave Jones <[email protected]>

Good catch, applied, thanks Dave.

#2 lore raw
In reply to Dave Jones
Quoted 9 lines

-----Original Message-----
From: Dave Jones [mailto:[email protected]]
Sent: Monday, June 16, 2014 1:59 PM
To: [email protected]
Cc: KY Srinivasan
Subject: hyperv: fix apparent cut-n-paste error in send path teardown

Quoted 3 lines

c25aaf814a63: "hyperv: Enable sendbuf mechanism on the send path" added some teardown code that looks like it was copied from the recieve path above, but missed a variable name replacement.

Thank you.

K. Y

Quoted 18 lines
Signed-off-by Dave Jones <[email protected]>
drivers/net/hyperv/netvsc.c index renamed from drivers/net/hyperv/netvsc.c +0 -0

c041f63a6d30..4ed38eaecea8 100644

drivers/net/hyperv/netvsc.c +1 -1
@@ -189,7 +189,7 @@ static int netvsc_destroy_buf(struct netvsc_device
 *net_device)
 				   "unable to teardown send buffer's
 gpadl\n");
 			return ret;
 		}
-		net_device->recv_buf_gpadl_handle = 0;
+		net_device->send_buf_gpadl_handle = 0;
 	}
drivers/net/hyperv/netvsc.c +0 -0
 	if (net_device->send_buf) {
 		/* Free up the receive buffer */