Skip to contentSkip to conversation

ARM: bcm_defconfig: re-enable BCM Kona SDHCI driver

PATCH New Matt Porter 6 participants 6 messages Jun 16, 2014 – Jun 17, 2014

Subsystems (2)
Arm (32-bit) MMC, SD and SDIO
lore
Share & tools
lore

Matt Porter

author
#0 lore raw

PATCH 1/1 ARM: bcm_defconfig: re-enable BCM Kona SDHCI driver

Since 5d01b7684b7e "mmc: simplify SDHCI Kconfig dependencies", MMC_SDHCI_PLTFM is no longer selected by the BCM Kona SDHCI driver which is enabled in this defconfig. This results in the SDHCI driver not being built and a boot failure. Explictly enable MMC_SDHCI_PLTFM in bcm_defconfig so the BCM Kona SDHCI driver is built.

Fixes 5d01b7684b7e ("mmc: simplify SDHCI Kconfig dependencies")
Signed-off-by Matt Porter <[email protected]>
---
 arch/arm/configs/bcm_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/bcm_defconfig +1 -0
index 9d13dae..dcfc559 100644
@@ -98,6 +98,7 @@ CONFIG_MMC_UNSAFE_RESUME=y
 CONFIG_MMC_BLOCK_MINORS=32
 CONFIG_MMC_TEST=y
 CONFIG_MMC_SDHCI=y
+CONFIG_MMC_SDHCI_PLTFM=y
 CONFIG_MMC_SDHCI_BCM_KONA=y
 CONFIG_NEW_LEDS=y
 CONFIG_LEDS_CLASS=y
Signature · 1 line
1.8.4
#1 lore raw

PATCH 1/1 ARM: bcm_defconfig: re-enable BCM Kona SDHCI driver

Quoted 9 lines · Matt Porter

Since 5d01b7684b7e "mmc: simplify SDHCI Kconfig dependencies", MMC_SDHCI_PLTFM is no longer selected by the BCM Kona SDHCI driver which is enabled in this defconfig. This results in the SDHCI driver not being built and a boot failure. Explictly enable MMC_SDHCI_PLTFM in bcm_defconfig so the BCM Kona SDHCI driver is built.

Fixes 5d01b7684b7e ("mmc: simplify SDHCI Kconfig dependencies")
Signed-off-by Matt Porter <[email protected]>

Works for me.

Tested-by Alex Elder <[email protected]>
Quoted 17 lines
---
 arch/arm/configs/bcm_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/bcm_defconfig +1 -0
index 9d13dae..dcfc559 100644
@@ -98,6 +98,7 @@ CONFIG_MMC_UNSAFE_RESUME=y
 CONFIG_MMC_BLOCK_MINORS=32
 CONFIG_MMC_TEST=y
 CONFIG_MMC_SDHCI=y
+CONFIG_MMC_SDHCI_PLTFM=y
 CONFIG_MMC_SDHCI_BCM_KONA=y
 CONFIG_NEW_LEDS=y
 CONFIG_LEDS_CLASS=y
#2 lore raw

PATCH 1/1 ARM: bcm_defconfig: re-enable BCM Kona SDHCI driver

In reply to Matt Porter
Quoted 9 lines · Matt Porter

Since 5d01b7684b7e "mmc: simplify SDHCI Kconfig dependencies", MMC_SDHCI_PLTFM is no longer selected by the BCM Kona SDHCI driver which is enabled in this defconfig. This results in the SDHCI driver not being built and a boot failure. Explictly enable MMC_SDHCI_PLTFM in bcm_defconfig so the BCM Kona SDHCI driver is built.

Fixes 5d01b7684b7e ("mmc: simplify SDHCI Kconfig dependencies")
Signed-off-by Matt Porter <[email protected]>
Reviewed-by Ulf Hansson <[email protected]>

I suppose this goes through arm-soc, but ping me if want me to send this as a fix for 3.16.

Kind regards
Uffe

Quoted 23 lines
---
 arch/arm/configs/bcm_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/bcm_defconfig +1 -1
index 9d13dae..dcfc559 100644
@@ -98,6 +98,7 @@ CONFIG_MMC_UNSAFE_RESUME=y
 CONFIG_MMC_BLOCK_MINORS=32
 CONFIG_MMC_TEST=y
 CONFIG_MMC_SDHCI=y
+CONFIG_MMC_SDHCI_PLTFM=y
 CONFIG_MMC_SDHCI_BCM_KONA=y
 CONFIG_NEW_LEDS=y
 CONFIG_LEDS_CLASS=y
--

1.8.4

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw

PATCH 1/1 ARM: bcm_defconfig: re-enable BCM Kona SDHCI driver

In reply to Matt Porter
Quoted 6 lines · Matt Porter

Since 5d01b7684b7e "mmc: simplify SDHCI Kconfig dependencies", MMC_SDHCI_PLTFM is no longer selected by the BCM Kona SDHCI driver which is enabled in this defconfig. This results in the SDHCI driver not being built and a boot failure. Explictly enable MMC_SDHCI_PLTFM in bcm_defconfig so the BCM Kona SDHCI driver is built.

I really don't understand why MMC_SDHCI_PLTFM isn't selected by the sub-drivers. sdhci-pltfm.c is a library module, which is only useful with one of the sub-drivers enabled.

So, rather than providing a multitude of dependent options, why not present people with:

+ sdhci drivers
+ sdhci pci
+ sdhci acpi
+ Arasan
+ Freescale eSDHC
+ Nintendo Wii
+ Dove

and leave MMC_SDHCI_PLTFM as a hidden option whose purpose is to enable building of sdhci-pltfm.c.

Signature · 2 lines
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
#4 lore raw

PATCH 1/1 ARM: bcm_defconfig: re-enable BCM Kona SDHCI driver

Quoted 23 lines · Russell King - ARM Linux
Quoted 6 lines · Matt Porter

Since 5d01b7684b7e "mmc: simplify SDHCI Kconfig dependencies", MMC_SDHCI_PLTFM is no longer selected by the BCM Kona SDHCI driver which is enabled in this defconfig. This results in the SDHCI driver not being built and a boot failure. Explictly enable MMC_SDHCI_PLTFM in bcm_defconfig so the BCM Kona SDHCI driver is built.

I really don't understand why MMC_SDHCI_PLTFM isn't selected by the sub-drivers. sdhci-pltfm.c is a library module, which is only useful with one of the sub-drivers enabled.

So, rather than providing a multitude of dependent options, why not present people with:

+ sdhci drivers
+ sdhci pci
+ sdhci acpi
+ Arasan
+ Freescale eSDHC
+ Nintendo Wii
+ Dove

Quoted 2 lines

and leave MMC_SDHCI_PLTFM as a hidden option whose purpose is to enable building of sdhci-pltfm.c.

CC'ing Arnd, as author of 5d01b7684b7e "mmc: simplify SDHCI Kconfig dependencies". I also forgot to do that on the patch that fixed multi_v7_defconfig for this:-(

#5 lore raw

PATCH 1/1 ARM: bcm_defconfig: re-enable BCM Kona SDHCI driver

Quoted 24 lines · Stephen Warren
Quoted 23 lines · Russell King - ARM Linux
Quoted 6 lines · Matt Porter

Since 5d01b7684b7e "mmc: simplify SDHCI Kconfig dependencies", MMC_SDHCI_PLTFM is no longer selected by the BCM Kona SDHCI driver which is enabled in this defconfig. This results in the SDHCI driver not being built and a boot failure. Explictly enable MMC_SDHCI_PLTFM in bcm_defconfig so the BCM Kona SDHCI driver is built.

I really don't understand why MMC_SDHCI_PLTFM isn't selected by the sub-drivers. sdhci-pltfm.c is a library module, which is only useful with one of the sub-drivers enabled.

So, rather than providing a multitude of dependent options, why not present people with:

+ sdhci drivers
+ sdhci pci
+ sdhci acpi
+ Arasan
+ Freescale eSDHC
+ Nintendo Wii
+ Dove

Quoted 6 lines
Quoted 2 lines

and leave MMC_SDHCI_PLTFM as a hidden option whose purpose is to enable building of sdhci-pltfm.c.

CC'ing Arnd, as author of 5d01b7684b7e "mmc: simplify SDHCI Kconfig dependencies". I also forgot to do that on the patch that fixed multi_v7_defconfig for this:-(

I think doing it the other way round as Russell suggested is a good idea, and we can definitely do that. We have a similar situation in other subsystems, sometimes we do it one way and sometimes the other.

The problem I was addressing in my patch was that the SDHCI driver in particular was mixing the two approaches, which is much worse as that can cause Kconfig dependency loops and is rather confusing. I picked the approach that seemed simpler at the time.

Arnd