clkdev: Don't print errors on probe defer
PATCH 1/1 clkdev: Don't print errors on probe defer
This error message can spam the logs if you have lots of probe deferals due to missing clocks. Just silence the error in this case because the driver should try again later.
--- drivers/clk/clkdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/clk/clkdev.c +3 -2
@@ -101,8 +101,9 @@ struct clk *of_clk_get_by_name(struct device_node *np, const char *name)if (!IS_ERR (clk))break ;else if (name && index >=0 ) { -pr_err ("ERROR: could not get clock %s:%s(%i)\n" , - np->full_name, name ? name :"" , index); +if (PTR_ERR (clk) != -EPROBE_DEFER ) +pr_err ("ERROR: could not get clock %s:%s(%i)\n" , + np->full_name, name ? name :"" , index);return clk; }
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
Quoting Stephen Boyd (2014-06-13 16:36:31)
Quoted 5 lines
This error message can spam the logs if you have lots of probe deferals due to missing clocks. Just silence the error in this case because the driver should try again later.
Signed-off-by Stephen Boyd <[email protected]>
Looks OK to me. Russell?
Regards,
Mike
Quoted 24 lines
--- drivers/clk/clkdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/clk/clkdev.c +3
-2@@ -101,8 +101,9 @@ struct clk *of_clk_get_by_name(struct device_node *np, const char *name)if (!IS_ERR (clk))break ;else if (name && index >=0 ) { -pr_err ("ERROR: could not get clock %s:%s(%i)\n" , - np->full_name, name ? name :"" , index); +if (PTR_ERR (clk) != -EPROBE_DEFER ) +pr_err ("ERROR: could not get clock %s:%s(%i)\n" , + np->full_name, name ? name :"" , index);return clk; }Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
Russell King - ARM Linux
Acked-by Russell KingQuoted 8 lines · Mike Turquette
Quoting Stephen Boyd (2014-06-13 16:36:31)
Quoted 5 lines
This error message can spam the logs if you have lots of probe deferals due to missing clocks. Just silence the error in this case because the driver should try again later.
Signed-off-by Stephen Boyd <[email protected]>Looks OK to me. Russell?
Looks fine to me too. Should I assume you're looking to take it?
Signature · 2 lines
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly improving, and getting towards what was expected from it.
PATCH 1/1 clkdev: Don't print errors on probe defer
Quoting Russell King - ARM Linux (2014-06-17 15:48:06)
Quoted 11 lines · Mike Turquette
Quoted 8 lines
Quoting Stephen Boyd (2014-06-13 16:36:31)
Quoted 5 lines
This error message can spam the logs if you have lots of probe deferals due to missing clocks. Just silence the error in this case because the driver should try again later.
Signed-off-by Stephen Boyd <[email protected]>Looks OK to me. Russell?
Looks fine to me too. Should I assume you're looking to take it?
Yes, I'll take it.
Quoted 2 lines
Acked-by Russell King <[email protected]>
Thanks for the Ack.
Regards,
Mike
Quoted 4 lines
Signature · 3 lines
-- FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly improving, and getting towards what was expected from it.