Skip to contentSkip to conversation

939c7a4f04f: -46.4% cpuidle.C3-IVT.time

tracing Jet Chen 4 participants 5 messages Jun 18, 2014 – Jun 19, 2014

lore
Share & tools
lore

Jet Chen

author
#0 lore raw

Hi Yoshihiro,

FYI, we noticed the below changes on

commit 939c7a4f04fcd2162109744e8bf88194948a6e65 ("tracing: Introduce saved_cmdlines_size file")

test case: brickland3/aim7/3000-brk_test

beba4bb096201ce 939c7a4f04fcd2162109744e8
--------------- -------------------------

     352643 ~40%     -46.4%     189136 ~15%  TOTAL cpuidle.C3-IVT.time
        750 ~ 2%     -13.3%        650 ~ 2%  TOTAL vmstat.procs.b
     362016 ~ 3%      -6.0%     340296 ~ 3%  TOTAL proc-vmstat.pgmigrate_success
     362016 ~ 3%      -6.0%     340296 ~ 3%  TOTAL proc-vmstat.numa_pages_migrated
    1642328 ~ 3%     +13.3%    1860721 ~ 2%  TOTAL softirqs.RCU
    2278829 ~ 2%     -14.0%    1959647 ~ 2%  TOTAL time.voluntary_context_switches
        207 ~ 0%     -10.4%        185 ~ 0%  TOTAL time.user_time

~ 0% +8.5% ~ 0% TOTAL turbostat.RAM_W
4418246 ~ 3% -6.4% 4136447 ~ 1% TOTAL time.minor_page_faults
~ 0% +3.4% ~ 0% TOTAL turbostat.Cor_W
~ 0% +3.0% ~ 0% TOTAL turbostat.Pkg_W
11354889 ~ 0% +2.0% 11579897 ~ 0% TOTAL time.involuntary_context_switches

Legend:
~XX% - stddev percent
[+-]XX% - change percent

time.voluntary_context_switches

2.4e+06 ++---------------------------------------------------*------------+
*.. *.. .. .. |
2.3e+06 ++ .*.. *.. .. * |
| *..*. . .*.. .. * *.. + *.. *..*
| *. * . .*..*.. + .. |

   2.2e+06 ++                                 *..*.       *            *     |
           |                                                                 |
   2.1e+06 ++                                                                |
           |                                                                 |
     2e+06 O+                                 O           O            O     |
           |                     O     O                     O      O        |
           |        O   O  O  O                  O                           |
   1.9e+06 ++ O  O                                  O           O            |
           |                        O     O            O                     |

1.8e+06 ++----------------------------------------------------------------+

turbostat.Pkg_W

++--------------------------------------------------------------------+
O+ O O O O O |
| O O O O O O O O O O O O |
++ O O |
++ |
++ |
++ |
| |
++ |
++ |
++ *.. .*.. |
*+.*... .. *...*. *...*..*..*...*..*.. ..*.. *...*..*..*...*..*
| * *. .. |
++ * |
++--------------------------------------------------------------------+

turbostat.Cor_W

++--------------------------------------------------------------------+
O+ O O O O O O O O O |
| O O O O O O O O O O |
++ |
++ |
| |
++ |
++ |
++ |
| |
++ *.. |
*+.*... .. *...*..*..*...*..*..*...*..*.. ..*.. *... .*..*...*..*
| * *. .. *. |
++ * |
++--------------------------------------------------------------------+

turbostat.RAM_W

++---------------------------------------------------------------------+

   |  O      O         O                O   O         O         O  O      |
   O+     O         O      O  O  O   O         O  O      O  O             |
   |             O                                                        |
   ++                                                                     |
   |                                                                      |
   ++                                                                     |
   |                                                                      |
   ++                                                                     |
   |                   *                                                  |
   ++                .. +                      *..                        |
   |            .*..*    +    *..       *..   +     ..*..*..      .*...   |
   ++         ..          + ..        ..   . +    *.        *...*.     *..*
   *..*...*..*             *     *...*      *                             |

++---------------------------------------------------------------------+

[*] bisect-good sample
[O] bisect-bad sample

Disclaimer:
Results have been estimated based on internal Intel analysis and are provided for informational purposes only. Any difference in system hardware or software design or configuration may affect actual performance.

Thanks,
Jet

echo performance > /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu1/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu10/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu100/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu101/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu102/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu103/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu104/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu105/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu106/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu107/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu108/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu109/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu11/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu110/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu111/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu112/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu113/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu114/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu115/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu116/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu117/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu118/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu119/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu12/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu13/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu14/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu15/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu16/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu17/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu18/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu19/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu2/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu20/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu21/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu22/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu23/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu24/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu25/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu26/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu27/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu28/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu29/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu3/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu30/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu31/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu32/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu33/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu34/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu35/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu36/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu37/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu38/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu39/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu4/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu40/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu41/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu42/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu43/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu44/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu45/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu46/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu47/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu48/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu49/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu5/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu50/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu51/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu52/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu53/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu54/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu55/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu56/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu57/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu58/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu59/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu6/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu60/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu61/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu62/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu63/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu64/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu65/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu66/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu67/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu68/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu69/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu7/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu70/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu71/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu72/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu73/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu74/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu75/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu76/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu77/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu78/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu79/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu8/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu80/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu81/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu82/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu83/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu84/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu85/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu86/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu87/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu88/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu89/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu9/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu90/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu91/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu92/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu93/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu94/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu95/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu96/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu97/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu98/cpufreq/scaling_governor echo performance > /sys/devices/system/cpu/cpu99/cpufreq/scaling_governor

#1 lore raw
Quoted 7 lines · On Wed, 18 Jun 2014 11:15:44 +0800 Jet Chen <[email protected]> wrote:

Hi Yoshihiro,

FYI, we noticed the below changes on

commit 939c7a4f04fcd2162109744e8bf88194948a6e65 ("tracing: Introduce saved_cmdlines_size file")

test case: brickland3/aim7/3000-brk_test

Um, do these tests run with tracing enabled and on? If not, the code in the above mentioned commit is never executed.

Something may be whacky with your bisect.

-- Steve

Quoted 3 lines

beba4bb096201ce 939c7a4f04fcd2162109744e8
--------------- -------------------------

#2 lore raw
In reply to Jet Chen

Hi Jet,

Thank you for your report.
I have some questions for your test.

1. Did you enable ftrace?
This patch added a feature for ftrace. If you disabled ftrace in this test, my patch will not affect the system. Moreover, in my patch, arrays for saved_cmdlines were just changed from using static global variables to using kmalloc() on default setting. So, even if you enabled ftrace, this patch will not induce a big problem, I think.

2. How did you test it and what does the result mean? Please tell me the workload, how to calculate the score, system settings, etc...

Thanks,
Yoshihiro YUNOMAE

Quoted 139 lines · Jet Chen

Hi Yoshihiro,

FYI, we noticed the below changes on

commit 939c7a4f04fcd2162109744e8bf88194948a6e65 ("tracing: Introduce saved_cmdlines_size file")

test case: brickland3/aim7/3000-brk_test

beba4bb096201ce 939c7a4f04fcd2162109744e8
--------------- -------------------------

     352643 ~40%     -46.4%     189136 ~15%  TOTAL cpuidle.C3-IVT.time
        750 ~ 2%     -13.3%        650 ~ 2%  TOTAL vmstat.procs.b
     362016 ~ 3%      -6.0%     340296 ~ 3%  TOTAL
proc-vmstat.pgmigrate_success
     362016 ~ 3%      -6.0%     340296 ~ 3%  TOTAL
proc-vmstat.numa_pages_migrated
    1642328 ~ 3%     +13.3%    1860721 ~ 2%  TOTAL softirqs.RCU
    2278829 ~ 2%     -14.0%    1959647 ~ 2%  TOTAL

time.voluntary_context_switches
207 ~ 0% -10.4% 185 ~ 0% TOTAL time.user_time
~ 0% +8.5% ~ 0% TOTAL turbostat.RAM_W
4418246 ~ 3% -6.4% 4136447 ~ 1% TOTAL time.minor_page_faults
~ 0% +3.4% ~ 0% TOTAL turbostat.Cor_W
~ 0% +3.0% ~ 0% TOTAL turbostat.Pkg_W
11354889 ~ 0% +2.0% 11579897 ~ 0% TOTAL
time.involuntary_context_switches

Legend:
~XX% - stddev percent
[+-]XX% - change percent

time.voluntary_context_switches

   2.4e+06

++---------------------------------------------------*------------+
*.. *.. ..
.. |
2.3e+06 ++ .*.. *.. ..
* |

           |  *..*.    .  .*.. ..   *     *..               +
*..   *..*
           |            *.    *              .     .*..*.. +

.. |
2.2e+06 ++ *..*. *
* |

| |
2.1e+06
++ |

|                                                                 |
     2e+06 O+                                 O           O
O     |
           |                     O     O                     O
O        |
           |        O   O  O  O
O                           |
   1.9e+06 ++ O  O                                  O
O            |
           |                        O     O
O                     |

1.8e+06
++----------------------------------------------------------------+

turbostat.Pkg_W

++--------------------------------------------------------------------+
O+ O O O O O |
| O O O O O O O O O O O O |
++ O O |
++ |
++ |
++ |
| |
++ |
++ |
++ *.. .*.. |
*+.*... .. *...*. *...*..*..*...*..*.. ..*.. *...*..*..*...*..*
| * *. .. |
++ * |
++--------------------------------------------------------------------+

turbostat.Cor_W

++--------------------------------------------------------------------+
O+ O O O O O O O O O |
| O O O O O O O O O O |
++ |
++ |
| |
++ |
++ |
++ |
| |
++ *.. |
*+.*... .. *...*..*..*...*..*..*...*..*.. ..*.. *... .*..*...*..*
| * *. .. *. |
++ * |
++--------------------------------------------------------------------+

turbostat.RAM_W

++---------------------------------------------------------------------+

   |  O      O         O                O   O         O         O  O      |
   O+     O         O      O  O  O   O         O  O      O  O             |
   |             O                                                        |
   ++                                                                     |
   |                                                                      |
   ++                                                                     |
   |                                                                      |
   ++                                                                     |
   |                   *                                                  |
   ++                .. +                      *..                        |
   |            .*..*    +    *..       *..   +     ..*..*..      .*...   |
   ++         ..          + ..        ..   . +    *.        *...*.     *..*
   *..*...*..*             *     *...*      *                             |

++---------------------------------------------------------------------+

[*] bisect-good sample
[O] bisect-bad sample

Disclaimer:
Results have been estimated based on internal Intel analysis and are provided
for informational purposes only. Any difference in system hardware or software
design or configuration may affect actual performance.

Thanks,
Jet

Signature · 4 lines
Yoshihiro YUNOMAE
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: yoshihiro.yunomae.ez(a)hitachi.com
#3 lore raw

Hi Yoshihiro,

Quoted 6 lines · Yoshihiro YUNOMAE

Hi Jet,

Thank you for your report.
I have some questions for your test.

1. Did you enable ftrace?

Yes, ftrace is enabled. Attached is the kernel config.

Quoted 5 lines

This patch added a feature for ftrace. If you disabled ftrace in this test, my patch will not affect the system. Moreover, in my patch, arrays for saved_cmdlines were just changed from using static global variables to using kmalloc() on default setting. So, even if you enabled ftrace, this patch will not induce a big problem, I think.

Agreed, the patch itself looks good. Unfortunately sometimes a small change in one place may lead to subtle changes in other places due to data alignment etc. effects.

Quoted 3 lines

2. How did you test it and what does the result mean? Please tell me the workload, how to calculate the score, system settings, etc...

Workload is aim7's brk_test case, running on an Ivy Bridge-EX machine. However it's not aim7's throughput that's regressed, but there are changes in the C3 state, number of RCU softirqs and power consumption etc.

Thanks,
Fengguang

Quoted 150 lines

Thanks,
Yoshihiro YUNOMAE

Quoted 139 lines · Jet Chen

Hi Yoshihiro,

FYI, we noticed the below changes on

commit 939c7a4f04fcd2162109744e8bf88194948a6e65 ("tracing: Introduce saved_cmdlines_size file")

test case: brickland3/aim7/3000-brk_test

beba4bb096201ce 939c7a4f04fcd2162109744e8
--------------- -------------------------

    352643 ~40%     -46.4%     189136 ~15%  TOTAL cpuidle.C3-IVT.time
       750 ~ 2%     -13.3%        650 ~ 2%  TOTAL vmstat.procs.b
    362016 ~ 3%      -6.0%     340296 ~ 3%  TOTAL
proc-vmstat.pgmigrate_success
    362016 ~ 3%      -6.0%     340296 ~ 3%  TOTAL
proc-vmstat.numa_pages_migrated
   1642328 ~ 3%     +13.3%    1860721 ~ 2%  TOTAL softirqs.RCU
   2278829 ~ 2%     -14.0%    1959647 ~ 2%  TOTAL
time.voluntary_context_switches
       207 ~ 0%     -10.4%        185 ~ 0%  TOTAL time.user_time
            ~ 0%      +8.5%            ~ 0%  TOTAL turbostat.RAM_W
   4418246 ~ 3%      -6.4%    4136447 ~ 1%  TOTAL time.minor_page_faults
           ~ 0%      +3.4%            ~ 0%  TOTAL turbostat.Cor_W
           ~ 0%      +3.0%            ~ 0%  TOTAL turbostat.Pkg_W
  11354889 ~ 0%      +2.0%   11579897 ~ 0%  TOTAL

time.involuntary_context_switches

Legend:
~XX% - stddev percent
[+-]XX% - change percent

time.voluntary_context_switches

2.4e+06
++---------------------------------------------------*------------+
*.. *.. ..
.. |
2.3e+06 ++ .*.. *.. ..
* |

          |  *..*.    .  .*.. ..   *     *..               +
*..   *..*
          |            *.    *              .     .*..*.. +

.. |
2.2e+06 ++ *..*. *
* |

| |
2.1e+06
++ |

|                                                                 |
    2e+06 O+                                 O           O
O     |
          |                     O     O                     O
O        |
          |        O   O  O  O
O                           |
  1.9e+06 ++ O  O                                  O
O            |
          |                        O     O
O                     |

1.8e+06
++----------------------------------------------------------------+

turbostat.Pkg_W

++--------------------------------------------------------------------+

   O+ O   O     O      O                O                                |
   |         O      O     O   O  O  O      O      O     O   O  O  O      |
   ++                                         O      O                   |
   ++                                                                    |
   ++                                                                    |
   ++                                                                    |
   |                                                                     |
   ++                                                                    |
   ++                                                                    |
   ++        *..      .*..                                               |
   *+.*... ..   *...*.    *...*..*..*...*..*..  ..*..   *...*..*..*...*..*
   |      *                                   *.      ..                 |
   ++                                                *                   |

++--------------------------------------------------------------------+

turbostat.Cor_W

++--------------------------------------------------------------------+

   O+ O   O  O  O   O  O                O  O                      O      |
   |                      O   O  O  O         O   O  O  O   O  O         |
   ++                                                                    |
   ++                                                                    |
   |                                                                     |
   ++                                                                    |
   ++                                                                    |
   ++                                                                    |
   |                                                                     |
   ++        *..                                                         |
   *+.*... ..   *...*..*..*...*..*..*...*..*..  ..*..   *...  .*..*...*..*
   |      *                                   *.      ..    *.           |
   ++                                                *                   |

++--------------------------------------------------------------------+

turbostat.RAM_W

++---------------------------------------------------------------------+

  |  O      O         O                O   O         O         O  O      |
  O+     O         O      O  O  O   O         O  O      O  O             |
  |             O                                                        |
  ++                                                                     |
  |                                                                      |
  ++                                                                     |
  |                                                                      |
  ++                                                                     |
  |                   *                                                  |
  ++                .. +                      *..                        |
  |            .*..*    +    *..       *..   +     ..*..*..      .*...   |
  ++         ..          + ..        ..   . +    *.        *...*.     *..*
  *..*...*..*             *     *...*      *                             |

++---------------------------------------------------------------------+

[*] bisect-good sample
[O] bisect-bad sample

Disclaimer:
Results have been estimated based on internal Intel analysis and are provided
for informational purposes only. Any difference in system hardware or software
design or configuration may affect actual performance.

Thanks,
Jet

Signature · 4 lines
Yoshihiro YUNOMAE
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: yoshihiro.yunomae.ez(a)hitachi.com
#4 lore raw
Quoted 11 lines · On Fri, 20 Jun 2014 00:28:42 +0800 Fengguang Wu <[email protected]> wrote:

Hi Yoshihiro,

Quoted 6 lines · Yoshihiro YUNOMAE

Hi Jet,

Thank you for your report.
I have some questions for your test.

1. Did you enable ftrace?

Yes, ftrace is enabled. Attached is the kernel config.

I guess the question isn't about enabling it in the kernel, but actually enabling the tracing itself at runtime.

Just enabling it in the kernel, still does not make this code executed.

Quoted 10 lines
Quoted 6 lines

This patch added a feature for ftrace. If you disabled ftrace in this test, my patch will not affect the system. Moreover, in my patch, arrays for saved_cmdlines were just changed from using static global variables to using kmalloc() on default setting. So, even if you enabled ftrace, this patch will not induce a big problem, I think.

Agreed, the patch itself looks good. Unfortunately sometimes a small change in one place may lead to subtle changes in other places due to data alignment etc. effects.

There's nothing we can do to change that. We were lucky that we had some data alignment that gave us an improvement. But that's it. Shear luck! This isn't the fault of the patch then, it's the linker and compiler that you need to take issue with.

Quoted 9 lines
Quoted 4 lines

2. How did you test it and what does the result mean? Please tell me the workload, how to calculate the score, system settings, etc...

Workload is aim7's brk_test case, running on an Ivy Bridge-EX machine. However it's not aim7's throughput that's regressed, but there are changes in the C3 state, number of RCU softirqs and power consumption etc.

This is still rather weird. As if tracing wasn't happening, then this should not have had any affect at all. I mean really? The patch just changes some local code to kernel/trace/trace.c, which is not even remotely related to RCU softirqs or power consumption. It's dead code as far as you are concerned (unless you enabled running some tracing).

-- Steve